Skip to content

Extract logging handlers from DagsterInstance to EventDomain #31614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

Extract logging handlers from DagsterInstance to EventDomain #31614

merged 1 commit into from
Aug 7, 2025
+48 −42

Conversation

schrockn
Copy link
Member

@schrockn schrockn commented Aug 7, 2025 •
edited
Loading

Summary & Motivation

This PR extracts logging handler methods from DagsterInstance to EventDomain as part of the ongoing domain separation effort. The changes move three key logging methods:

  • get_yaml_python_handlers(): Processes YAML-defined Python logging configuration and returns configured handlers
  • get_event_log_handler(): Creates and configures the EventListenerLogHandler for capturing events
  • get_handlers(): Aggregates all logging handlers (event log handler + YAML-defined handlers)

The methods are moved from DagsterInstance to EventDomain with the public API remaining unchanged. The DagsterInstance.get_handlers() method now delegates to the EventDomain implementation.

How I Tested These Changes

Existing test suite validates the refactored functionality.

This was referenced Aug 7, 2025
Merged
Merged
@schrockn Graphite App
Copy link
Member Author

schrockn commented Aug 7, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@schrockn schrockn mentioned this pull request Aug 7, 2025
Merged
@schrockn schrockn changed the title get-yaml-python-handlers Refactor DagsterInstance: Extract factory methods and domain logic Aug 7, 2025
@schrockn schrockn changed the title Refactor DagsterInstance: Extract factory methods and domain logic Extract logging handlers from DagsterInstance to EventDomain Aug 7, 2025
@schrockn schrockn mentioned this pull request Aug 7, 2025
Merged
@schrockn schrockn force-pushed the schrockn/ir-4-more-asset-domain branch from 0213891 to c17714f Compare August 7, 2025 05:18
@schrockn schrockn force-pushed the schrockn/ir-5-get-yaml-python-handlers branch from 78f178c to babab60 Compare August 7, 2025 05:18
This was referenced Aug 7, 2025
Merged
Merged
@schrockn schrockn force-pushed the schrockn/ir-5-get-yaml-python-handlers branch from babab60 to 2f5efe9 Compare August 7, 2025 12:04
@schrockn schrockn force-pushed the schrockn/ir-4-more-asset-domain branch from c17714f to cacebe0 Compare August 7, 2025 12:04
This was referenced Aug 7, 2025
Closed
Merged
Merged
@schrockn schrockn force-pushed the schrockn/ir-4-more-asset-domain branch from cacebe0 to f7a85a6 Compare August 7, 2025 13:32
@schrockn schrockn force-pushed the schrockn/ir-5-get-yaml-python-handlers branch from 2f5efe9 to e64e157 Compare August 7, 2025 13:32
@schrockn schrockn marked this pull request as ready for review August 7, 2025 13:36
@schrockn schrockn force-pushed the schrockn/ir-4-more-asset-domain branch from f7a85a6 to 277af2f Compare August 7, 2025 15:43
@schrockn schrockn force-pushed the schrockn/ir-5-get-yaml-python-handlers branch 2 times, most recently from 3186763 to c498f18 Compare August 7, 2025 16:29
@schrockn schrockn force-pushed the schrockn/ir-4-more-asset-domain branch 2 times, most recently from 9bfb7fd to 00ecf97 Compare August 7, 2025 17:20
@schrockn schrockn force-pushed the schrockn/ir-5-get-yaml-python-handlers branch 2 times, most recently from c7fdc44 to 7954648 Compare August 7, 2025 18:17
@schrockn schrockn force-pushed the schrockn/ir-4-more-asset-domain branch from 00ecf97 to 5cd3e9e Compare August 7, 2025 18:17
This was referenced Aug 7, 2025
Merged
Merged
@schrockn schrockn requested a review from OwenKephart August 7, 2025 21:40
@schrockn schrockn force-pushed the schrockn/ir-4-more-asset-domain branch from 5cd3e9e to 4d5a624 Compare August 7, 2025 22:11
@schrockn schrockn force-pushed the schrockn/ir-5-get-yaml-python-handlers branch from 7954648 to 1ae5711 Compare August 7, 2025 22:11
@schrockn Graphite App
Copy link
Member Author

schrockn commented Aug 7, 2025 •
edited
Loading

Merge activity

  • Aug 7, 10:43 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 7, 10:51 PM UTC: Graphite rebased this pull request as part of a merge.
  • Aug 7, 10:52 PM UTC: @schrockn merged this pull request with Graphite.

@schrockn schrockn changed the base branch from schrockn/ir-4-more-asset-domain to graphite-base/31614 August 7, 2025 22:47
@schrockn schrockn changed the base branch from graphite-base/31614 to master August 7, 2025 22:49
@schrockn schrockn force-pushed the schrockn/ir-5-get-yaml-python-handlers branch from 1ae5711 to b107661 Compare August 7, 2025 22:50
@schrockn schrockn merged commit 346f3b4 into master Aug 7, 2025
4 of 5 checks passed
@schrockn schrockn deleted the schrockn/ir-5-get-yaml-python-handlers branch August 7, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OwenKephart OwenKephart OwenKephart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schrockn @OwenKephart