Skip to content

Remove obsolete DagsterInstance refactoring planning document #31616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

Remove obsolete DagsterInstance refactoring planning document #31616

merged 1 commit into from
Aug 7, 2025
+0 −732

Conversation

schrockn
Copy link
Member

@schrockn schrockn commented Aug 7, 2025 •
edited
Loading

Summary & Motivation

Remove obsolete DagsterInstance refactoring planning document that is no longer needed. The document contained detailed plans for extracting domains from the monolithic DagsterInstance class, but all planned refactoring work has been completed.

The 732-line planning document tracked:

  • Status of 6 domain extractions (Runs, Assets, Events, Daemon, Scheduling, Storage)
  • Implementation plans for each domain
  • Progress tracking and success metrics

Since all domains have been successfully extracted and the refactoring is complete, this planning document can be safely removed.

How I Tested These Changes

Verified the file is no longer referenced anywhere in the codebase.

This was referenced Aug 7, 2025
Merged
Merged
Merged
Merged
@schrockn Graphite App
Copy link
Member Author

schrockn commented Aug 7, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Aug 7, 2025
Merged
Merged
@schrockn schrockn changed the title Delete plan doc Remove obsolete DagsterInstance refactoring planning document Aug 7, 2025
@schrockn schrockn force-pushed the schrockn/6-ir-domains-mixin branch from 38c6a49 to d9ad4af Compare August 7, 2025 12:04
@schrockn schrockn force-pushed the schrockn/ir-7-delete-plan branch from 1193b2e to 1e869f5 Compare August 7, 2025 12:04
This was referenced Aug 7, 2025
Closed
Merged
Merged
@schrockn schrockn force-pushed the schrockn/ir-7-delete-plan branch from 1e869f5 to a8f0d09 Compare August 7, 2025 13:32
@schrockn schrockn force-pushed the schrockn/6-ir-domains-mixin branch from d9ad4af to 9ba23a5 Compare August 7, 2025 13:32
@schrockn schrockn marked this pull request as ready for review August 7, 2025 13:36
@schrockn schrockn force-pushed the schrockn/ir-7-delete-plan branch 2 times, most recently from a457021 to fc22533 Compare August 7, 2025 15:43
@schrockn schrockn force-pushed the schrockn/6-ir-domains-mixin branch 2 times, most recently from f8f4e85 to e079c02 Compare August 7, 2025 16:29
@schrockn schrockn force-pushed the schrockn/ir-7-delete-plan branch from fc22533 to bb36051 Compare August 7, 2025 16:29
@schrockn schrockn force-pushed the schrockn/6-ir-domains-mixin branch from e079c02 to 5b5a0d9 Compare August 7, 2025 17:21
@schrockn schrockn force-pushed the schrockn/ir-7-delete-plan branch 2 times, most recently from 6f73e93 to 8884733 Compare August 7, 2025 18:17
@schrockn schrockn force-pushed the schrockn/6-ir-domains-mixin branch from 5b5a0d9 to 4d88ce7 Compare August 7, 2025 18:17
This was referenced Aug 7, 2025
Merged
Merged
@schrockn schrockn requested a review from OwenKephart August 7, 2025 21:40
@schrockn schrockn force-pushed the schrockn/6-ir-domains-mixin branch from 4d88ce7 to a6d8436 Compare August 7, 2025 22:11
@schrockn schrockn force-pushed the schrockn/ir-7-delete-plan branch from 8884733 to b03a8f7 Compare August 7, 2025 22:11
@schrockn Graphite App
Copy link
Member Author

schrockn commented Aug 7, 2025 •
edited
Loading

Merge activity

  • Aug 7, 10:43 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 7, 10:57 PM UTC: Graphite rebased this pull request as part of a merge.
  • Aug 7, 10:58 PM UTC: @schrockn merged this pull request with Graphite.

@schrockn schrockn changed the base branch from schrockn/6-ir-domains-mixin to graphite-base/31616 August 7, 2025 22:53
@schrockn schrockn changed the base branch from graphite-base/31616 to master August 7, 2025 22:55
@schrockn
Remove obsolete DagsterInstance refactoring planning document
6d3bb91 
Remove 732-line planning document that tracked the progress and plans for extracting domains from DagsterInstance. All planned refactoring work has been completed, making this document obsolete.
@schrockn schrockn force-pushed the schrockn/ir-7-delete-plan branch from b03a8f7 to 6d3bb91 Compare August 7, 2025 22:56
@schrockn schrockn merged commit c5b88fb into master Aug 7, 2025
4 of 5 checks passed
@schrockn schrockn deleted the schrockn/ir-7-delete-plan branch August 7, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OwenKephart OwenKephart OwenKephart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schrockn @OwenKephart