Skip to content

Extract instigator functionality into InstigatorMixin #31620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2025
Merged

Extract instigator functionality into InstigatorMixin #31620

merged 2 commits into from
Aug 8, 2025
+339 −189

Conversation

schrockn
Copy link
Member

@schrockn schrockn commented Aug 7, 2025 •
edited
Loading

Summary & Motivation

Extracts all instigator, schedule, and sensor-related functionality from the class into a new class. This refactoring improves code organization by separating concerns and follows the existing mixin pattern used in the codebase.

The provides all the instigator-related methods including:

  • Schedule control (start/stop/reset schedules)
  • Sensor control (start/stop/reset sensors)
  • Instigator state management
  • Tick operations and queries
  • Maintenance operations

How I Tested These Changes

Existing test suite covers all moved functionality.

Changelog

No public API changes - this is an internal refactoring.

This was referenced Aug 7, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
@schrockn Graphite App
Copy link
Member Author

schrockn commented Aug 7, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@schrockn schrockn force-pushed the schrockn/asset-mixin branch from 0b9e343 to b04e9ec Compare August 7, 2025 13:32
@schrockn schrockn force-pushed the schrockn/instigator-mixin branch from 09c1d80 to 9ab361b Compare August 7, 2025 13:32
@schrockn schrockn marked this pull request as ready for review August 7, 2025 13:36
@schrockn schrockn force-pushed the schrockn/asset-mixin branch from b04e9ec to 2e3dfd7 Compare August 7, 2025 13:49
@schrockn schrockn force-pushed the schrockn/instigator-mixin branch from 9ab361b to c28a0b8 Compare August 7, 2025 13:49
@schrockn schrockn changed the title instigator Extract instigator functionality into InstigatorMixin Aug 7, 2025
@schrockn schrockn force-pushed the schrockn/instigator-mixin branch from c28a0b8 to 6a68ffd Compare August 7, 2025 14:06
@schrockn schrockn force-pushed the schrockn/asset-mixin branch from 0039e52 to aa59675 Compare August 7, 2025 15:13
@schrockn schrockn force-pushed the schrockn/instigator-mixin branch 2 times, most recently from b9b5f95 to 94287a6 Compare August 7, 2025 15:43
@schrockn schrockn force-pushed the schrockn/asset-mixin branch 2 times, most recently from 5897b3c to 440381f Compare August 7, 2025 16:29
@schrockn schrockn force-pushed the schrockn/instigator-mixin branch from 94287a6 to 15f6676 Compare August 7, 2025 16:29
@schrockn schrockn force-pushed the schrockn/asset-mixin branch from 440381f to 0d8fe89 Compare August 7, 2025 17:23
@schrockn schrockn force-pushed the schrockn/instigator-mixin branch from 15f6676 to ad75846 Compare August 7, 2025 17:24
@schrockn schrockn force-pushed the schrockn/asset-mixin branch from 0d8fe89 to efefbde Compare August 7, 2025 18:17
@schrockn schrockn force-pushed the schrockn/instigator-mixin branch from ad75846 to 152838e Compare August 7, 2025 18:17
This was referenced Aug 7, 2025
Merged
Merged
@schrockn schrockn force-pushed the schrockn/asset-mixin branch from efefbde to 9d7d1cc Compare August 7, 2025 22:11
@schrockn schrockn mentioned this pull request Aug 8, 2025
Merged
@schrockn schrockn force-pushed the schrockn/instigator-mixin branch from 60b73f3 to dd250dc Compare August 8, 2025 17:51
@schrockn schrockn force-pushed the schrockn/asset-mixin branch from bf4d8c7 to 84e8f70 Compare August 8, 2025 17:51
@schrockn schrockn force-pushed the schrockn/instigator-mixin branch 2 times, most recently from aff9467 to 85b1e41 Compare August 8, 2025 19:51
@schrockn schrockn force-pushed the schrockn/asset-mixin branch from ce6565c to 61ec23c Compare August 8, 2025 19:51
This was referenced Aug 8, 2025
Merged
Merged
@schrockn schrockn force-pushed the schrockn/instigator-mixin branch from 85b1e41 to ad69b88 Compare August 8, 2025 20:23
@schrockn schrockn requested a review from OwenKephart August 8, 2025 20:31
@schrockn schrockn force-pushed the schrockn/instigator-mixin branch from ad69b88 to cb3cd39 Compare August 8, 2025 21:03
@schrockn schrockn force-pushed the schrockn/asset-mixin branch from 27b7053 to 520ac48 Compare August 8, 2025 21:03
OwenKephart
OwenKephart approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@OwenKephart OwenKephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note comments, have some leftover comments that can be removed

@schrockn schrockn changed the base branch from schrockn/asset-mixin to graphite-base/31620 August 8, 2025 22:17
@schrockn schrockn force-pushed the graphite-base/31620 branch from 520ac48 to d4a0384 Compare August 8, 2025 22:19
@schrockn schrockn force-pushed the schrockn/instigator-mixin branch from cb3cd39 to 8489104 Compare August 8, 2025 22:19
@graphite-app graphite-app bot changed the base branch from graphite-base/31620 to master August 8, 2025 22:20
@schrockn schrockn force-pushed the schrockn/instigator-mixin branch from 8489104 to c226524 Compare August 8, 2025 22:20
@schrockn schrockn force-pushed the schrockn/instigator-mixin branch from c226524 to 5abb147 Compare August 8, 2025 22:35
@schrockn Graphite App
Copy link
Member Author

schrockn commented Aug 8, 2025

rm'ing comments in last diff in stack

@schrockn Graphite App
Copy link
Member Author

schrockn commented Aug 8, 2025 •
edited
Loading

Merge activity

  • Aug 8, 11:04 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 8, 11:04 PM UTC: @schrockn merged this pull request with Graphite.

@schrockn schrockn merged commit 22349c5 into master Aug 8, 2025
5 of 6 checks passed
@schrockn schrockn deleted the schrockn/instigator-mixin branch August 8, 2025 23:04
This was referenced Aug 8, 2025
Draft
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OwenKephart OwenKephart OwenKephart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schrockn @OwenKephart