Refactor: Extract compute log operations into ComputeLogDomain #31610
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Extracts compute log operations from DagsterInstance into a dedicated ComputeLogDomain following the established domain pattern used by other areas like RunDomain, DaemonDomain, etc. This addresses an API inconsistency where compute log operations required direct access to
instance.compute_log_manager.*
rather than having wrapper methods on DagsterInstance like other functional areas.The refactor provides:
instance.get_compute_log_data()
,instance.capture_compute_logs()
, etc.instance.compute_log_manager.*
calls continue to work unchangedKey new methods include:
How I Tested These Changes
New unit tests verify all wrapper methods delegate correctly to the underlying ComputeLogManager. All existing functionality remains unchanged.