Remove __all__ from subpackage init files #31609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
OwenKephart
approved these changes
Aug 7, 2025
This was referenced Aug 7, 2025
This was referenced Aug 7, 2025
47e733f to
1da2df9
Compare
This was referenced Aug 7, 2025
1da2df9 to
bba4857
Compare
8273a15 to
e03609e
Compare
bba4857 to
d5147ed
Compare
This was referenced Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Remove
__all__declaration fromdagster/_core/instance/scheduling/__init__.pysubpackage. This follows the established coding convention that__all__should only be used in top-level package__init__.pyfiles to define public APIs, not in subpackages.The change also updates the development documentation in
CLAUDE.mdto explicitly document this convention for future contributors.How I Tested These Changes
Existing test suite.