-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Consolidate DagsterInstance architecture: merge mixins and domains into Methods classes #31634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+926
−1,610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2025
8af97e1
to
97d7399
Compare
dd1f5d3
to
5dbdcae
Compare
97d7399
to
b397919
Compare
749437f
to
b79f160
Compare
65682a3
to
ca22ca1
Compare
b79f160
to
377eaa3
Compare
377eaa3
to
a4ab586
Compare
ca22ca1
to
7031804
Compare
a4ab586
to
a310cab
Compare
d6a13ef
to
8fe47c7
Compare
a310cab
to
7dd60b6
Compare
7dd60b6
to
de1c931
Compare
9a9a539
to
347c75e
Compare
de1c931
to
15a8cc8
Compare
ff1f56f
to
9057a37
Compare
5fa42b5
to
8103da3
Compare
9057a37
to
92c01b4
Compare
92c01b4
to
19a89bf
Compare
8103da3
to
62fda75
Compare
@OwenKephart we need the AssetMethods syntax because of multiple inheritance. Otherwise we're relying on MRO which is fragile. |
dd05d66
to
4a5770e
Compare
36a5889
to
53e4379
Compare
4a5770e
to
fd5beff
Compare
53e4379
to
64586b8
Compare
6 tasks
64586b8
to
baccbd4
Compare
Merged
baccbd4
to
87e3221
Compare
0b6e577
to
7a02864
Compare
87e3221
to
c3a78bf
Compare
c3a78bf
to
06e3479
Compare
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-d769zu5ux-elementl.vercel.app Direct link to changed pages: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Consolidates DagsterInstance architecture from a 3-layer structure (Instance → Mixins → Domains) to a streamlined 2-layer structure (Instance → Methods). This eliminates the delegation overhead and complexity while preserving all existing functionality and APIs.
Key Changes
methods/
folder for clear separation of concernsCompleted Domain Consolidations
How I Tested These Changes
Existing test suite passes with all domain consolidations. Each Methods class preserves identical functionality to the original mixin+domain implementation.
Changelog
Internal architectural improvement - no user-facing API changes.