fix: Move orphaned filter to Filters block #7082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad41d0e to
c68b3b7
Compare
alexmt
requested changes
Aug 26, 2021
| @@ -105,6 +123,15 @@ export const Filters = (props: { | |||
| })) | |||
| })} | |||
| {namespaces.length > 1 && ResourceFilter({label: 'NAMESPACES', prefix: 'namespace', options: (namespaces || []).filter(l => l && l !== '').map(toOption), field: true})} | |||
| {/* {(tree.orphanedNodes || []).length > 0 && */} | |||
There was a problem hiding this comment.
It makes sense to don't show orphaned nodes filter if application does not have any orphaned nodes. Please uncomment this check to hide orphaned filters filter if there are no orphaned nodes
There was a problem hiding this comment.
Please do show it!
- I've sometimes needed to untick it before performing an action that will create orphans
- I assume the filters are still "global"? -> sometimes I have had an application with thousands of orphans which crashes the UI when I look at it: I have to go to another application to toggle the filter.
- It can be annoying to have it appear/disappear as orphans are added/removed.
| label={'ORPHANED'} | ||
| content={orphanedCheckbox} | ||
| header={<></>} | ||
| isClearButtonVisible={true} |
There was a problem hiding this comment.
The orphaned nodes filter looks a bit strange now:
The Clear button is always visible and overlaps with collapse/expand button:
Is it possible to re-use existing ResourceFilter component ?
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Feat retry app creation
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Retry app creation
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
We at Technacy love using Argo CD Signed-off-by: Omar <omar.dedonato@technacy.it> Signed-off-by: viktorplakida <plakyda1@gmail.com>
fix: make codegen Signed-off-by: pashavictorovich <pavel@codefresh.io> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: Remington Breeze <remington@breeze.software> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: Remington Breeze <remington@breeze.software> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
* fix: password reset meet requirement Signed-off-by: May Zhang <may_zhang@intuit.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
The instructions for telling the CLI how to automatically use port-forward were intertwined with the instructions for registering a repo; this separates them. This also moves the port-forward flags instructions to the first place in the doc a user would need them. Signed-off-by: Josh Gavant <joshgavant@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: benmanifold <benmanifold@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
feat: Scoped clusters (argoproj#7039) Signed-off-by: pashavictorovich <pavel@codefresh.io> Signed-off-by: viktorplakida <plakyda1@gmail.com>
feat: goreman option to exclude (argoproj#7080) Signed-off-by: pashavictorovich <pavel@codefresh.io> Signed-off-by: viktorplakida <plakyda1@gmail.com>
…goproj#7081) feat: resource name filter + filter block for resource table view (argoproj#7081) Signed-off-by: viktorplakida <plakyda1@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: pashavictorovich <pavel@codefresh.io> Signed-off-by: viktorplakida <plakyda1@gmail.com>
…google fonts (argoproj#7253) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Bumps [nth-check](https://github.com/fb55/nth-check) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/fb55/nth-check/releases) - [Commits](fb55/nth-check@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: nth-check dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Bumps [prismjs](https://github.com/PrismJS/prism) from 1.24.1 to 1.25.0. - [Release notes](https://github.com/PrismJS/prism/releases) - [Changelog](https://github.com/PrismJS/prism/blob/master/CHANGELOG.md) - [Commits](PrismJS/prism@v1.24.1...v1.25.0) --- updated-dependencies: - dependency-name: prismjs dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: yangtian9999 <yangtian9999@163.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
…rgoproj#7274) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
It is not immediately clear what the `<current-user-password>` should be as shown by this issue: argoproj#4096. This comment should make it more clear that when users are setting passwords as the default `admin` user, they should be using the `admin` password here. Signed-off-by: John Chen <johnchen456@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
feat: retry option app creation (argoproj#7252) Signed-off-by: viktorplakida <plakyda1@gmail.com>
* remove not existing repo Signed-off-by: pashavictorovich <pavel@codefresh.io> * fix test Signed-off-by: pashavictorovich <pavel@codefresh.io> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: ml <ml@visu.li> Signed-off-by: viktorplakida <plakyda1@gmail.com>
…nifests in argoproj/argoproj-deployments (argoproj#7299) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: Regina Scott <rescott@redhat.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
feat: Project autocomplete (Connect repo SSH) (argoproj#7286) Signed-off-by: viktorplakida <plakyda1@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
…d permission denied error (argoproj#7300) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
feat: rename app identifier (argoproj#7251) Signed-off-by: pashavictorovich <pavel@codefresh.io> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
c91141e to
d1818c5
Compare
Codecov Report
@@ Coverage Diff @@
## master #7082 +/- ##
=======================================
Coverage 41.15% 41.15%
=======================================
Files 161 161
Lines 21553 21553
=======================================
Hits 8871 8871
Misses 11415 11415
Partials 1267 1267
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: