refactor: cache virtual project calculation to improve performance #7274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
plakyda-codefresh
pushed a commit
to plakyda-codefresh/argo-cd
that referenced
this pull request
Sep 28, 2021
…rgoproj#7274) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
Application controller uses
argo.GetAppProjectByNamemethod to get application project object that includes "global" project restrictions and project scoped repo/clusters. This logic might be CPU-consuming if Argo CD installation has a lot of repositories/clusters. Our internal dev Argo CD has ~300 repos and consumes 4.5 CPU. PR implements project caching (cache is reset every time when any repo/cluster or project changes). This reduces CPU usage in the same dev Argo CD instance to ~0.05 CPU