Skip to content

Conversation

ml-
Copy link
Contributor

@ml- ml- commented Sep 17, 2021

Signed-off-by: ml ml@visu.li

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: ml <ml@visu.li>
@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #7248 (8d7bdcb) into master (b264729) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7248   +/-   ##
=======================================
  Coverage   41.10%   41.10%           
=======================================
  Files         160      160           
  Lines       21505    21505           
=======================================
  Hits         8840     8840           
  Misses      11399    11399           
  Partials     1266     1266           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b264729...8d7bdcb. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alexmt alexmt merged commit 2f6e91a into argoproj:master Sep 27, 2021
@ml- ml- deleted the fix-typo-namesapce branch September 27, 2021 18:54
plakyda-codefresh pushed a commit to plakyda-codefresh/argo-cd that referenced this pull request Sep 28, 2021
Signed-off-by: ml <ml@visu.li>
Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants