refactor: stop using @beyonk/google-fonts-webpack-plugin to download google fonts #7253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…google fonts Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #7253 +/- ##
=======================================
Coverage 41.08% 41.08%
=======================================
Files 160 160
Lines 21475 21475
=======================================
Hits 8823 8823
Misses 11387 11387
Partials 1265 1265 Continue to review full report at Codecov.
|
plakyda-codefresh
pushed a commit
to plakyda-codefresh/argo-cd
that referenced
this pull request
Sep 21, 2021
…google fonts (argoproj#7253) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
plakyda-codefresh
pushed a commit
to plakyda-codefresh/argo-cd
that referenced
this pull request
Sep 28, 2021
…google fonts (argoproj#7253) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
The
@beyonk/google-fonts-webpack-pluginplugin downloads google fonts during build time. Apparently it depends on third party helper service which is not very reliable. It is down right now. The worst part is that UI build fails silently is we get an image without UI assets.The PR remotes the plugin and instead adds font files into git repository.