fix: password reset requirements #7071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Signed-off-by: May Zhang <may_zhang@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #7071 +/- ##
==========================================
+ Coverage 41.06% 41.08% +0.02%
==========================================
Files 158 158
Lines 21305 21313 +8
==========================================
+ Hits 8748 8756 +8
+ Misses 11304 11301 -3
- Partials 1253 1256 +3
Continue to review full report at Codecov.
|
alexmt
requested changes
Aug 24, 2021
There was a problem hiding this comment.
Thank you @mayzhang2000 . Added couple comments.
Please also document config map settings in https://github.com/argoproj/argo-cd/blob/master/docs/operator-manual/argocd-cm.yaml
alexmt
requested changes
Aug 24, 2021
Signed-off-by: May Zhang <may_zhang@intuit.com>
alexmt
approved these changes
Aug 25, 2021
alexmt
pushed a commit
that referenced
this pull request
Aug 25, 2021
* fix: password reset meet requirement Signed-off-by: May Zhang <may_zhang@intuit.com>
plakyda-codefresh
pushed a commit
to plakyda-codefresh/argo-cd
that referenced
this pull request
Sep 28, 2021
* fix: password reset meet requirement Signed-off-by: May Zhang <may_zhang@intuit.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
fixes: #5787