feat: rename app identifier #7251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
This was referenced Sep 17, 2021
Signed-off-by: pashavictorovich <pavel@codefresh.io>
jannfis
reviewed
Sep 19, 2021
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
…resh/argo-cd into rename-app-id � Conflicts: � reposerver/apiclient/repository.pb.go
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
…resh/argo-cd into rename-app-id � Conflicts: � util/settings/settings.go
Codecov Report
@@ Coverage Diff @@
## master #7251 +/- ##
==========================================
+ Coverage 41.11% 41.15% +0.04%
==========================================
Files 160 161 +1
Lines 21505 21553 +48
==========================================
+ Hits 8842 8871 +29
- Misses 11398 11415 +17
- Partials 1265 1267 +2
Continue to review full report at Codecov.
|
…resh/argo-cd into rename-app-id
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
…resh/argo-cd into rename-app-id
Signed-off-by: pashavictorovich <pavel@codefresh.io>
alexmt
requested changes
Sep 28, 2021
There was a problem hiding this comment.
Thank you @pasha-codefresh !
Added one suggestion to rename setting key and couple minor comments about tests.
Can you please update PR description as well so that everyone understands which part of feature it covers. E.g.
PR introduces system-level resource tracking method setting that allows using annotation
instead of label to track application resources. PR does not cover the whole feature.
Following parts will be converted in follow PRs:
* ...
* ...Signed-off-by: pashavictorovich <pavel@codefresh.io>
This was referenced Sep 28, 2021
Closed
plakyda-codefresh
pushed a commit
to plakyda-codefresh/argo-cd
that referenced
this pull request
Sep 28, 2021
feat: rename app identifier (argoproj#7251) Signed-off-by: pashavictorovich <pavel@codefresh.io> Signed-off-by: viktorplakida <plakyda1@gmail.com>
This was referenced Sep 28, 2021
Merged
This was referenced Oct 4, 2021
This was referenced Oct 6, 2021
|
I know this has been merged but what version will this be available in? |
|
2.2 @cten |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6425
PR introduces system-level resource tracking method setting that allows using annotation
instead of label to track application resources. PR does not cover the whole feature.
Following parts will be converted in follow PRs: