fix: keep uid_entrypoint.sh for backward compatibility #7047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
|
@jannfis WDYT? |
Codecov Report
@@ Coverage Diff @@
## master #7047 +/- ##
=======================================
Coverage 40.98% 40.98%
=======================================
Files 158 158
Lines 21305 21305
=======================================
Hits 8731 8731
Misses 11334 11334
Partials 1240 1240
Continue to review full report at Codecov.
|
jannfis
approved these changes
Aug 23, 2021
jannfis
pushed a commit
that referenced
this pull request
Aug 23, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
2 tasks
plakyda-codefresh
pushed a commit
to plakyda-codefresh/argo-cd
that referenced
this pull request
Sep 28, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: viktorplakida <plakyda1@gmail.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
Closes argoproj/argo-helm#882
Closes #7044
I think renaming of uid_entrypoint.sh to entrypoint.sh should be considered a backward-incompatible change. To make it easier to migrate let's create
uid_entrypoint.shsymlink and delete it in next release.