TODO doesn't really make sense. It would turn some public global
variables into private global variables, but really they shouldn't be
global variables at all. They should be block manager member variables
or chainstate manager member variables.

TODO was added by MarcoFalke <falke.marco@gmail.com> in
fa247a3 in bitcoin#21727 and noticed by Samuel
Dobson <dobsonsa68@gmail.com>
bitcoin#23497 (comment)

…_node.a

172096e scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a (Russell Yanofsky)

Pull request description:

  Goal along with namespacing PR #23497 is to make code organization more obvious and have `src/node/` code in `node::` namespace in `libbitcoin_node.a` library

ACKs for top commit:
  MarcoFalke:
    cr ACK 172096e

Tree-SHA512: a2e787eeaa3ab769b0f5376473072cae584d237aa8b67b677bea833bb36b0134a0eca17eb01722389639473b8463f4953bc3a5e4801a6b2c8965ac1075cba005

Updated auxpow code for the new namespaces (e.g. where it uses miner
functions that are now in node::), and added the wallet/rpc/auxpow code
to the wallet:: namespace.  This is in relation to upstream
bitcoin/bitcoin#23497.

Updated name code for the new namespaces from upstream
bitcoin/bitcoin#23497.  The wallet/rpc/name code
was added to wallet::.

Goal along with namespacing PR bitcoin#23497 is to have src/node/ code in
node:: namespace in libbitcoin_node.a library

-BEGIN VERIFY SCRIPT-
bash -c ' # Bash shell needed for brace expansion {a,b}
git mv build_msvc/libbitcoin_{server,node}
git mv build_msvc/libbitcoin_node/libbitcoin_{server,node}.vcxproj.in
ren() { git grep -l "$1" src build_msvc | xargs sed -i "s/$1/$2/g"; }
ren LIBBITCOIN_{SERVER,NODE}
ren libbitcoin_{server,node}
'
-END VERIFY SCRIPT-

Goal along with namespacing PR bitcoin#23497 is to have src/node/ code in
node:: namespace in libbitcoin_node.a library

-BEGIN VERIFY SCRIPT-
bash -c ' # Bash shell needed for brace expansion {a,b}
git mv build_msvc/libbitcoin_{server,node}
git mv build_msvc/libbitcoin_node/libbitcoin_{server,node}.vcxproj.in
ren() { git grep -l "$1" src build_msvc | xargs sed -i "s/$1/$2/g"; }
ren LIBBITCOIN_{SERVER,NODE}
ren libbitcoin_{server,node}
'
-END VERIFY SCRIPT-

Summary:
Overall PR:
> There are no code changes, this is just adding namespace and `using` declarations and `node::` or `wallet::` qualifiers in some places.
>
> Motivations for this change are:
>
>  -  To make it easier to see when node and wallet code is being accessed places where it shouldn't be. For example if GUI code is accessing node and wallet internals or if wallet and node code are referencing each other.
>  -  To make source code organization clearer (core#15732), being able to know that `wallet::` code is in `src/wallet/`, `node:: code` is in `src/node/`, `init::` code is in `src/init/`, `util::` code is in `src/util/`, etc.
>

Notes:
 - CBlockIndexWorkComparator is not part of the node namespace for Bitcoin ABC because it is defined in its own header file rather than src/node/blockstorage.h
 - some fuzzers and minisketchwrapper.* changes are not applicable due to missing backports (see [[bitcoin/bitcoin#23114 | core#23114]]).

This is a partial backport of [[bitcoin/bitcoin#23497 | core#23497]]
bitcoin/bitcoin@90fc8b0

Test Plan: `ninja all check-all bitcoin-fuzzers bench-bitcoin`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D12763

Summary:
> CBlockFileInfo class is declared in src/chain.h, so move ToString
> definition to src/chain.cpp instead of src/node/blockstorage.cpp

`CBlockFileInfo` was moved to its own header file in D1654, so "where class is declared" is a new blockfileinfo.cpp file.
The class is used in txdb.h and validation.h, which are both in the `server` library, so put this new file in this library as well.

This is a partial backport of [[bitcoin/bitcoin#23497 | core#23497]]
bitcoin/bitcoin@e5b6aef

Test Plan: `ninja all check-all`

Reviewers: #bitcoin_abc, sdulfari

Reviewed By: #bitcoin_abc, sdulfari

Differential Revision: https://reviews.bitcoinabc.org/D12768