scripted-diff: Rename libbitcoin_server.a to libbitcoin_node.a #23828
Conversation
Goal along with namespacing PR bitcoin#23497 is to have src/node/ code in node:: namespace in libbitcoin_node.a library -BEGIN VERIFY SCRIPT- bash -c ' # Bash shell needed for brace expansion {a,b} git mv build_msvc/libbitcoin_{server,node} git mv build_msvc/libbitcoin_node/libbitcoin_{server,node}.vcxproj.in ren() { git grep -l "$1" src build_msvc | xargs sed -i "s/$1/$2/g"; } ren LIBBITCOIN_{SERVER,NODE} ren libbitcoin_{server,node} ' -END VERIFY SCRIPT-
|
Concept ACK. |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
I cancelled this because the script failed. Maybe the bash doesn't resolve the |
8ef044b to
172096e
Compare
Yes it looks like there is a problem with Updated 8ef044b -> 172096e ( |
|
cr ACK 172096e |
Goal along with namespacing PR #23497 is to make code organization more obvious and have
src/node/code innode::namespace inlibbitcoin_node.alibrary