Skip to content

rpc: Add and use EnsureArgsman helper #23936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2022
Merged

rpc: Add and use EnsureArgsman helper #23936

merged 2 commits into from
Jan 4, 2022

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jan 2, 2022

This refactor doesn't change anything for the rpc layer, but it helps a bit with removing gArgs (See #21005)

shaavan
shaavan approved these changes Jan 2, 2022
View reviewed changes
Copy link
Contributor

@shaavan shaavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review ACK fa5bb37

  • The newly added helper functions: EnsureArgsman and EnsureAnyArgsman together allow getting node arguments from a given (any) context.
    These simplify the code wherever we need arguments based on a request context.

  • Checked that the function EnsureAnyArgsman is used correctly in rpc/blockchain.cpp

  • Checked that out of the remaining instances of NodeContext& node none can be replaced with args{EnsureAnyArgsman(request.context)} in this PR.

  • Finally, I am concept ACK on #21005, so I think it’s a step forward, replacing gArgs with args in the codebase.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 2, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #23497 (Add src/node/ and src/wallet/ code to node:: and wallet:: namespaces by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot mentioned this pull request Jan 2, 2022
Merged
@maflcko maflcko merged commit 300124d into bitcoin:master Jan 4, 2022
@maflcko maflcko deleted the 2201-rpcArgs branch January 4, 2022 14:57
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 4, 2022
Merge bitcoin#23936: rpc: Add and use EnsureArgsman helper
d87288f
@bitcoin bitcoin locked and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@shaavan shaavan shaavan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maflcko @DrahtBot @shaavan