The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• fuzz: Add fuzzing syscall sandbox: detect use of unexpected syscalls when fuzzing ("syscall sanitizer") #21538 (fuzz: Add fuzzing syscall sandbox: detect use of unexpected syscalls when fuzzing ("syscall sanitizer") by practicalswift)
• Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) #20487 (Add syscall sandboxing using seccomp-bpf (Linux secure computing mode) by practicalswift)
• util: Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17) #20452 (util: Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17) by practicalswift)
• allow -loadblock blocks to be unsorted #20331 (allow -loadblock blocks to be unsorted by LarryRuane)
• Introduce deploymentstatus #19438 (Introduce deploymentstatus by ajtowns)
• Replace uses of boost::trim* with locale-independent alternatives #18130 (Replace uses of boost::trim* with locale-independent alternatives by Empact)
• interfaces: Expose settings.json methods to GUI #15936 (Unify bitcoin-qt and bitcoind persistent settings by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Rebased.

git range-diff bitcoin-core/master fa8cf6fae7 fab20c8f73 --word-diff-regex=.

Concept ACK

I don't know if that would belong in this PR or in a follow-up PR, but perhaps we want to introduce namespace blockstorage similar to how namespace init is introduced in #21732?

I think a namespace is not the right solution here. Blockstorage is inherently stateful, so a class makes more sense. I expect that BlockManager can be recycled to be this class (after it is moved here), but this will happen in later pull requests. The changes here are focussed on move-only to simply collect the code that is blockstorage related.

ACK fa09a9e

ACK fa09a9e

• Checked diff via dimmed-zebra.
• Compiled each individual commit - success.
• (Noticed only that IsBlockPruned is no longer an inline function.)

🕵️ @sipa has been requested to review this pull request as specified in the REVIEWERS file.

Code review ACK fa09a9e