Move BlockManager to node/blockstorage #23581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5beaff2 to
8888475
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Nov 24, 2021
fa53f20 to
fa0ecc1
Compare
This was referenced Dec 2, 2021
Merged
fa0ecc1 to
faaf493
Compare
faaf493 to
1e1117f
Compare
added 2 commits
January 2, 2022 17:05
Can be reviewed with --color-moved=dimmed-zebra
Can be reviewed with --word-diff-regex=. -U0 --ignore-all-space
1e1117f to
fa7efc9
Compare
|
Rebased |
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 16, 2022
Summary: Can be reviewed with --color-moved=dimmed-zebra This is a backport of [[bitcoin/bitcoin#23581 | core#23581]] bitcoin/bitcoin@fade2a4 Depends on D12487 Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D12507
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockManageris responsible for reading and writing block(headers). So move it to the existingblockstoragemodule innode. Also, move validation code unrelated to block-storage out fromBlockManager.