Support output descriptors in scantxoutset #13697

sipa · 2018-07-17T23:18:13Z

As promised, here is an implementation of my output descriptor concept (https://gist.github.com/sipa/e3d23d498c430bb601c5bca83523fa82) and integration within the scantxoutset RPC that was just added through #12196.

It changes the RPC to use descriptors for everything; I hope the interface is simple enough to encompass all use cases. It includes support for P2PK, P2PKH, P2WPKH, P2SH, P2WSH, multisig, xpubs, xprvs, and chains of keys - combined in every possible way.

Empact · 2018-07-18T03:26:51Z

src/script/descriptor.cpp

@@ -0,0 +1,615 @@
+#include <script/descriptor.h>


~~Missing copyright block~~

promag

Few nits, it this for 0.17? Is scantxoutset considered API experimental?

promag · 2018-07-18T13:17:58Z

src/script/sign.h

+    bool GetCScript(const CScriptID& scriptid, CScript& script) const override;
+    bool GetPubKey(const CKeyID& keyid, CPubKey& pubkey) const override;
+    bool GetKey(const CKeyID& keyid, CKey& key) const override;
+


nit, remove empty line.

promag · 2018-07-18T13:22:42Z

src/script/sign.h

+
+};
+
+FlatSigningProvider Merge(const FlatSigningProvider& a, const FlatSigningProvider& b);


At the moment this is only used in tests, move there?

I'd rather not. I think more things will be able to use this.

promag · 2018-07-18T13:33:16Z

src/script/descriptor.cpp

+        return true;
+    }
+};
+#endif


nit, add // KEY_ORIGIN_SUPPORT.

promag · 2018-07-18T13:34:13Z

src/script/descriptor.cpp

+typedef std::vector<uint32_t> KeyPath;
+
+/** Interface for public key objects in descriptors. */
+struct PubkeyProvider {


nit, { in new line.

promag · 2018-07-18T13:34:31Z

src/script/descriptor.cpp

+
+/** Interface for public key objects in descriptors. */
+struct PubkeyProvider {
+    virtual ~PubkeyProvider(){};


nit, = default?

Done, here and elsewhere.

promag · 2018-07-18T15:34:18Z

src/script/descriptor.cpp

+    std::vector<Span<const char>> ret;
+    auto it = sp.begin();
+    auto start = it;
+    while (it != sp.end()) {


Add

if (it == sp.end()) return ret;

for when string is empty.

The statement ret.emplace_back(start, it); below should not be executed if sp is empty.

I mean, should Split("", sep) equal []?

No, it should be [""]. Callers can rely on there always being at least one argument in the result.

In that case 👍

promag · 2018-07-18T16:01:21Z

src/script/descriptor.cpp

+{
+    Span<const char> sp(descriptor.data(), descriptor.size());
+    auto ret = ParseScript(sp, ParseScriptContext::TOP, out);
+    if (sp.size() == 0 && ret) return std::move(ret);


Compiler warning:

script/descriptor.cpp:617:39: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] if (sp.size() == 0 && ret) return std::move(ret); ^ script/descriptor.cpp:617:39: note: remove std::move call here if (sp.size() == 0 && ret) return std::move(ret); ^~~~~~~~~~

promag · 2018-07-18T16:20:05Z

src/rpc/blockchain.cpp

-            "          }\n"
+            "2. \"scanobjects\"                  (array, required) Array of scan objects\n"
+            "    [                             Every scan object is either a string descriptor or an object:\n"
+            "        \"descriptor\",             (string, optional) An output descriptor\n"


Why give both options? [{ "desc": "...", ...}, ...] is enough?

It's pretty verbose to use the long form, and probably not all that often needed.

It's pretty verbose

On the client side I think it doesn't matter (unless it's a human making the call).

Yes, the reason to support the short notation is to simplify things for humans.

promag · 2018-07-18T16:20:57Z

src/rpc/blockchain.cpp

+                desc_str = scanobject.get_str();
+            } else if (scanobject.isObject()) {
+                UniValue desc_uni = find_value(scanobject, "desc");
+                if (desc_uni.isNull()) throw JSONRPCError(RPC_INVALID_PARAMETER, "Descriptor needs to be provided in scan object");


Could have a test.

Yes, will add when there's sufficient agreement about RPC.

promag · 2018-07-18T16:21:01Z

src/rpc/blockchain.cpp

+                UniValue range_uni = find_value(scanobject, "range");
+                if (!range_uni.isNull()) {
+                    range = range_uni.get_int();
+                    if (range < 1 || range > 1000000) throw JSONRPCError(RPC_INVALID_PARAMETER, "range out of range");


Could have a test.

promag · 2018-07-18T16:31:47Z

src/script/descriptor.cpp

+    if (Func("pk", expr)) {
+        auto pubkey = ParsePubkey(expr, ctx != ParseScriptContext::P2WSH, out);
+        if (pubkey) return MakeUnique<SingleKeyDescriptor>(std::move(pubkey), P2PKGetScript, "pk");
+    }


Why not return nullptr in these cases?

Done, here and elsewhere.

promag · 2018-07-18T16:32:36Z

src/script/descriptor.h

+/** Parse a descriptor string. Included private keys are put in out. Returns nullptr if parsing fails. */
+std::unique_ptr<Descriptor> Parse(const std::string& descriptor, FlatSigningProvider& out);
+
+#endif


#endif // BITCOIN_SCRIPT_DESCRIPTOR_H

sipa · 2018-07-18T19:31:46Z

Rebased, removed future "key origin" support (not needed right now, ignore).

Also, I'd like people to first review the descriptor language itself (a very short summary is in the RPC help, more of a reference in script/descriptor.h, and a design document in https://gist.github.com/sipa/e3d23d498c430bb601c5bca83523fa82). In particular, I'm not convinced about the "old" function (which maps pubkeys to P2PK,P2PKH,P2WPKH, and P2SH-PWPKH) - it's very useful for dealing with existing Core wallets, but "old" doesn't really convey the right meaning. However, I don't see what else to use. "legacy" is confusing (as it would have a different meaning than legacy in -addresstype). "default" sounds like it could change over time (the intention is that it wouldn't). "sk" or "singlekey" sounds like it's encouraged and/or could change over time, ...

achow101

Concept ACK

achow101 · 2018-07-18T19:11:07Z

src/script/descriptor.cpp

+        CExtKey key;
+        if (!GetExtKey(arg, key)) return false;
+        out = EncodeExtKey(key);
+        for (auto entry : m_path) {


Can the path writing be separated out into another function to avoid code duplication and so that we can use it elsewhere?

promag · 2018-07-18T20:56:27Z

Regarding the "old" function, I think it could receive the version, for instance default(args..., version) — it should validate if args are compatible with the version specified (at the moment args should be only a pubkey).

sipa · 2018-07-18T21:06:36Z

@promag There is no intention of ever adding another of those "defaults". Future versions should work with specific derivations (only P2WSH directly for example, rather than a collection). It's only for compatibility with the backward way we used to derive what scriptPubKeys are ours that such a default is useful.

Sjors

Concept ACK, and lightly tested on Ledger (P2SH-P2WPKH) and Blockchain (P2PKH) xpubs.

Sjors · 2018-07-21T18:01:04Z

src/rpc/blockchain.cpp

            "        },\n"
-            "      ]\n"
+            "        ...\n"
+            "    ]\n"


Don't forget to add a command-line example here, it look me a while to figure out the syntax from reading the above.

I suggest an example with a typical BIP44 (legacy) xpub + BIP49 xpub:

["pkh(legacy_xpub/0/*)", "pkh(legacy_xpub/1/*)", "sh(wpkh(segwit_xpub/0/*)", "sh(wpkh(segwit_xpub/1/*)"]

A second example could show the root master xpriv and then do hardened derivation of xpriv/44'/0'/0'/0/* or xpriv/49'/0'/0'/1/*

Sjors · 2018-07-21T18:02:28Z

src/rpc/blockchain.cpp

+            "    addr(<address>)                      Outputs whose scriptPubKey corresponds to the specified address (does not include P2PK)\n"
+            "    raw(<hex script>)                    Outputs whose scriptPubKey equals the specified hex scripts\n"
+            "    old(<pubkey>)                        P2PK, P2PKH, P2WPKH, and P2SH-P2WPKH outputs for the given pubkey\n"
+            "    pkh(<pubkey>)                        P2PKH outputs for the given pubkey\n"


sh(wpkh()) is probably quite common, so maybe add that here?

DrahtBot · 2018-07-22T13:27:28Z

No more conflicts as of last run.

flack · 2018-07-25T13:30:03Z

@sipa since you write that old is a "combination of P2PK, P2PKH, P2WPKH, and P2SH-P2WPKH for public key P.", you could call it combo instead. Or ck if you want it to look more like the other things that use P. And potentially prepend bc to indicate it's for backwards compatibility (but in that case someone should check urban dictionary to make sure bcck isn't some newfangled swear word :-))

sipa · 2018-07-26T19:11:02Z

@flack Oh, I like that. Changed to "combo".

maflcko · 2018-07-26T20:08:16Z

Travis failure:

test_framework.authproxy.JSONRPCException: Invalid descriptor 'old(03abcaca414970a8d36624011628045855cb01cded780445a33688a0b905a47224)' (-5)

bitcoin@29943a9

partial merge bitcoin#13697, bitcoin#18591, bitcoin#19387, bitcoin#18468: update constructors to match c++20 draft spec

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

a1f3aed util: make EncodeBase64 consume Spans (furszy) c36754f Add MakeUCharSpan, to help constructing Span<[const] unsigned char> (Pieter Wuille) 1f18199 Make uint256 Span-convertible by adding ::data() (Pieter Wuille) 0067590 Add lifetimebound to attributes for general-purpose usage (Cory Fields) 26eb256 span: add lifetimebound attribute (Cory Fields) 696e91f span: (almost) match std::span's constructor behavior (Cory Fields) da207d4 doc: Mention Span in developer-notes.md (Pieter Wuille) 138053d doc: Document Span pitfalls (Pieter Wuille) e2216d7 Add sanity check asserts to span when -DDEBUG (Pieter Wuille) ebcc978 Add Span constructors for arrays and vectors (Pieter Wuille) 38f105b Make pointer-based Span construction safer (Pieter Wuille) 33d5297 Make Span size type unsigned (Pieter Wuille) 17118e1 Support conversion between Spans of compatible types (Pieter Wuille) f36042f Span front() and back() methods and SpanPopBack function backport (furszy) 1b2e7c8 Add more methods to Span class (Pieter Wuille) Pull request description: Another decouple from #2411. Purely focused on updating the Span sources to be up-to-date with current upstream. Following PRs/commits were back ported: * bitcoin#13697 (only 29943a9) * 2b0fcff (only span changes). * bitcoin#18591 (only 0fbde48). * bitcoin#18468 (without 2676aea). * bitcoin#19367. * bitcoin#19387. * bitcoin#19326 (only 5678250 and e63dcc3 here). * bitcoin#19687 (only e2aa1a5 here, 2bc2071 is inside #2411 and require net related commits that are introduced down the commits line there). Extra side note: Some of the current serialization compiler warnings in master will be fixed with this, other ones are coming down 2411 commits line as they need other previous PRs. ACKs for top commit: random-zebra: Tested ACK a1f3aed Tree-SHA512: 256bc2064724ea6d4f6fac722fafb4ed3e2b4590cdad61bf1e4a5be25e0632bafcff39235ea6ed7badbef4f79dbb4f866356372a1b3c201af23873884baedfea

merge bitcoin#12196, bitcoin#13697: Add scantxoutset RPC method

… output of public descriptors c77f092 Fix descriptor_tests not checking ToString output of public descriptors (Russell Yanofsky) Pull request description: This fixes a minor test bug introduced in bitcoin#13697 that I noticed while reviewing bitcoin#14646 Tree-SHA512: efed91200cdff5f86ba5de3461ac00759d285e2905f6cb24cea15d3e23e0581ce5fc14b24a40db093f7ebd662ee1ee2cf67f8798bac1903a78298eda08909cfb

ecde04a [Consensus] Bump Active Protocol version to 70923 for v5.3 (random-zebra) b63e4f5 Consensus: Add v5.3 enforcement height for testnet. (furszy) f44be94 Only relay IPv4, IPv6, Tor addresses (Pieter Wuille) 015298c fix: tor: Call event_base_loopbreak from the event's callback (furszy) 34ff7a8 Consensus: Add mnb ADDRv2 guard. (furszy) b4515dc GUI: Present v3 onion addresses properly in MNs list. (furszy) 337d43d tests: don't export in6addr_loopback (Vasil Dimov) 2cde8e0 GUI: Do not show the tor v3 onion address in the topbar. (furszy) 0b5f406 Doc: update tor.md with latest upstream information. (furszy) 89df7f2 addrman: ensure old versions don't parse peers.dat (Vasil Dimov) bb90c5c test: add getnetworkinfo network name regression tests (Jon Atack) d8e01b5 rpc: update GetNetworksInfo() to not return unsupported networks (Jon Atack) 57fc7b0 net: update GetNetworkName() with all enum Network cases (Jon Atack) 647d60b tests: Modify rpc_bind to conform to bitcoin#14532 behaviour. (Carl Dong) d4d6729 Allow running rpc_bind.py --nonloopback test without IPv6 (Kristaps Kaupe) 4a034d8 test: Add rpc_bind test to default-run tests (Wladimir J. van der Laan) 61a08af [tests] bind functional test nodes to 127.0.0.1 Prevents OSX firewall (Sjors Provoost) 6a4f1e0 test: Add basic addr relay test (furszy) 78aa61c net: Make addr relay mockable (furszy) ba954ca Send and require SENDADDRV2 before VERACK (Pieter Wuille) 61c2ed4 Bump net protocol version + don't send 'sendaddrv2' to pre-70923 software (furszy) ccd508a tor: make a TORv3 hidden service instead of TORv2 (Vasil Dimov) 6da9a14 net: advertise support for ADDRv2 via new message (furszy) e58d5d0 Migrate to test_large_inv() to Misbehaving logging. (furszy) d496b64 [QA] fix mininode CAddress ser/deser (Jonas Schnelli) cec9567 net: CAddress & CAddrMan: (un)serialize as ADDRv2 Change the serialization of `CAddrMan` to serialize its addresses in ADDRv2/BIP155 format by default. Introduce a new `CAddrMan` format version (3). (furszy) b8c1dda streams update: get rid of nType and nVersion. (furszy) 3eaa273 Support bypassing range check in ReadCompactSize (Pieter Wuille) a237ba4 net: recognize TORv3/I2P/CJDNS networks (Vasil Dimov) 8e50853 util: make EncodeBase32 consume Spans (Sebastian Falbesoner) 1f67e30 net: CNetAddr: add support to (un)serialize as ADDRv2 (Vasil Dimov) 2455420 test: move HasReason so it can be reused (furszy) d41adb4 util: move HasPrefix() so it can be reused (Vasil Dimov) f6f86af Unroll Keccak-f implementation (Pieter Wuille) 45222e6 Implement keccak-f[1600] and SHA3-256 (Pieter Wuille) 08ad06d net: change CNetAddr::ip to have flexible size (furszy) 3337219 net: improve encapsulation of CNetAddr. (furszy) 910d5c4 test: Do not instantiate CAddrDB for static call (Hennadii Stepanov) 6b607ef Drop IsLimited in favor of IsReachable (Ben Woosley) a40711b IsReachable is the inverse of IsLimited (DRY). Includes unit tests (marcaiaf) 8839828 net: don't accept non-left-contiguous netmasks (Vasil Dimov) 5d7f864 rpcbind: Warn about exposing RPC to untrusted networks (Luke Dashjr) 2a6abd8 CNetAddr: Add IsBindAny method to check for INADDR_ANY (Luke Dashjr) 4fdfa45 net: Always default rpcbind to localhost, never "all interfaces" (Luke Dashjr) 31064a8 net: Minor accumulated cleanups (furszy) 9f9c871 tests: Avoid using C-style NUL-terminated strings as arguments (practicalswift) f6c52a3 tests: Add tests to make sure lookup methods fail on std::string parameters with embedded NUL characters (practicalswift) a751b9b net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface (furszy) f30869d test: add IsRFC2544 tests (Mark Tyneway) ed5abe1 Net: Proper CService deserialization + GetIn6Addr return false if addr isn't an IPv6 addr (furszy) 86d73fb net: save the network type explicitly in CNetAddr (Vasil Dimov) ad57dfc net: document `enum Network` (Vasil Dimov) cb160de netaddress: Update CNetAddr for ORCHIDv2 (Carl Dong) c3c04e4 net: Better misbehaving logging (furszy) 3660487 net: Use C++11 member initialization in protocol (Marco) 082baa3 refactor: Drop unused CBufferedFile::Seek() (Hennadii Stepanov) e2d776a util: CBufferedFile fixes (Larry Ruane) 6921f42 streams: backport OverrideStream class (furszy) Pull request description: Conjunction of a large number of back ports, updates and refactorings that made with the final goal of implementing v3 Onion addresses support (BIP155 https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki) before the tor v2 addresses EOL, scheduled, by the Tor project, for (1) July 15th: v2 addr support removal from the code base, and (2) October 15th: v2 addr network disable, where **every peer in our network running under Tor will loose the connection and drop the network**. As BIP155 describes, this is introducing a new P2P message to gossip longer node addresses over the P2P network. This is required to support new-generation Onion addresses, I2P, and potentially other networks that have longer endpoint addresses than fit in the 128 bits of the current addr message. In order to achieve the end goal, had to: 1. Create Span class and push it up to latest Bitcoin implementation. 2. Update the whole serialization framework and every object using it up to latest Bitcoin implementation (3-4 years ahead of what we currently are in master). 3. Update the address manager implementing ASN-based bucketing of the network nodes. 4. Update and refactor the netAddress and address manager tests to latest Bitcoin implementation (4 years ahead of what we currently are in master). 5. Several util string, vector, encodings, parsing, hashing backports and more.. Important note: This PR it is not meant to be merged as a standalone PR, will decouple smaller ones moving on. Adding on each sub-PR its own description isolated from this big monster. Second note: This is still a **work-in-progress**, not ready for testing yet. I'm probably missing to mention few PRs that have already adapted to our sources. Just making it public so can decouple the changes, we can start merging them and i can continue working a bit more confortable (rebase a +170 commits separate branch is not fun..). ### List of back ported and adapted PRs: Span and Serialization: ---------------- * bitcoin#12886. * bitcoin#12916. * bitcoin#13558. * bitcoin#13697. (Only Span's commit 29943a9) * bitcoin#17850. * bitcoin#17896. * bitcoin#12752. * bitcoin#16577. * bitcoin#16670. (without faebf62) * bitcoin#17957. * bitcoin#18021. * bitcoin#18087. * bitcoin#18112 (only from 353f376 that we don't support). * bitcoin#18167. * bitcoin#18317. * bitcoin#18591 (only Span's commit 0fbde48) * bitcoin#18468. * bitcoin#19020. * bitcoin#19032. * bitcoin#19367. * bitcoin#19387. Net, NetAddress and AddrMan: ---------------- * bitcoin#7932. * bitcoin#10756. * bitcoin#10765. * bitcoin#12218. * bitcoin#12855. * bitcoin#13532. * bitcoin#13575. * bitcoin#13815. * bitcoin#14532. * bitcoin#15051. * bitcoin#15138. * bitcoin#15689. * bitcoin#16702. * bitcoin#17243. * bitcoin#17345. * bitcoin#17754. * bitcoin#17758. * bitcoin#17812. * bitcoin#18023. * bitcoin#18454. * bitcoin#18512. * bitcoin#19314. * bitcoin#19687 Keys and Addresses encoding: ---------------- * bitcoin#11372. * bitcoin#17511. * bitcoin#17721. Util: ---------------- * bitcoin#9140. * bitcoin#16577. * bitcoin#16889. * bitcoin#19593. Bench: ---------------- * bitcoin#16299. BIP155: ---------------- * bitcoin#19351. * bitcoin#19360. * bitcoin#19534. * bitcoin#19628. * bitcoin#19841. * bitcoin#19845. * bitcoin#19954. * bitcoin#19991 (pending). * bitcoin#19845. * bitcoin#20000 (pending). * bitcoin#20120. * bitcoin#20284. * bitcoin#20564. * bitcoin#21157 (pending). * bitcoin#21564 (pending). * Fully removed v2 onion addr support. * Add hardcoded seeds. * Add release-notes, changes to files.md and every needed documentation. I'm currently working on the PRs marked as "pending", this isn't over, but I'm pretty pretty close :). What a long road.. ACKs for top commit: random-zebra: utACK ecde04a Fuzzbawls: ACK ecde04a Tree-SHA512: 82c95fbda76fce63f96d8a9af7fa9a89cb1e1b302b7891e27118a6103af0be23606bf202c7332fa61908205e6b6351764e2ec23d753f1e2484028f57c2e8b51a

Empact reviewed Jul 18, 2018

View reviewed changes

sipa force-pushed the 201806_minedesc branch from a6eba69 to 1b7c0c7 Compare July 18, 2018 03:30

laanwj added the RPC/REST/ZMQ label Jul 18, 2018

promag reviewed Jul 18, 2018

View reviewed changes

sipa force-pushed the 201806_minedesc branch from 1b7c0c7 to 4a5cd30 Compare July 18, 2018 19:25

achow101 reviewed Jul 18, 2018

View reviewed changes

sipa force-pushed the 201806_minedesc branch 2 times, most recently from ee40f42 to 895a46d Compare July 18, 2018 22:41

laanwj added this to the 0.17.0 milestone Jul 19, 2018

jonasschnelli self-requested a review July 19, 2018 21:21

sipa force-pushed the 201806_minedesc branch from 895a46d to 79b8939 Compare July 20, 2018 21:00

Sjors approved these changes Jul 21, 2018

View reviewed changes

sipa force-pushed the 201806_minedesc branch 2 times, most recently from bc9778b to 30efb13 Compare July 21, 2018 20:25

sipa mentioned this pull request Jul 26, 2018

Utils and libraries: Drops the boost/algorithm/string/split.hpp dependency #13751

Closed

sipa force-pushed the 201806_minedesc branch from 30efb13 to 4145314 Compare July 26, 2018 19:10

fanquake removed the Needs release note label Mar 20, 2019

kwvg mentioned this pull request Mar 8, 2021

partial #8149 and merge #19845, #19954: Complete the BIP155 implementation and upgrade to TORv3 dashpay/dash#4025

Closed

kwvg added a commit to kwvg/dash that referenced this pull request Mar 10, 2021

Partial bitcoin#13697: Add more methods to Span class

a1e043a

bitcoin@29943a9

kwvg mentioned this pull request Mar 10, 2021

partial merge #13697, #18591, #19387, #18468: update constructors to match c++20 draft spec dashpay/dash#4036

Merged

kwvg added a commit to kwvg/dash that referenced this pull request Mar 23, 2021

Partial bitcoin#13697: Add more methods to Span class

494d99c

bitcoin@29943a9

kwvg added a commit to kwvg/dash that referenced this pull request Apr 18, 2021

Partial bitcoin#13697: Support output descriptors in scantxoutset

10f923b

bitcoin@29943a9

UdjinM6 added a commit to dashpay/dash that referenced this pull request Apr 27, 2021

Merge pull request #4036 from kittywhiskers/spans

bf01ed7

partial merge bitcoin#13697, bitcoin#18591, bitcoin#19387, bitcoin#18468: update constructors to match c++20 draft spec

kwvg added a commit to kwvg/dash that referenced this pull request Jun 4, 2021

Merge bitcoin#13697: Support output descriptors in scantxoutset

24fb455

kwvg mentioned this pull request Jun 4, 2021

merge #12196, #13697: Add scantxoutset RPC method dashpay/dash#4187

Merged

furszy mentioned this pull request Jun 7, 2021

Road to Tor v3 support (BIP155) PIVX-Project/PIVX#2411

Merged

kwvg added a commit to kwvg/dash that referenced this pull request Jun 9, 2021

Merge bitcoin#13697: Support output descriptors in scantxoutset

cbe1968

furszy mentioned this pull request Jul 6, 2021

Span sources updates, up-to-date with current upstream. PIVX-Project/PIVX#2470

Merged

kwvg added a commit to kwvg/dash that referenced this pull request Jul 9, 2021

Merge bitcoin#13697: Support output descriptors in scantxoutset

3a39207

kwvg added a commit to kwvg/dash that referenced this pull request Jul 13, 2021

Merge bitcoin#13697: Support output descriptors in scantxoutset

572170d

kwvg added a commit to kwvg/dash that referenced this pull request Jul 13, 2021

Merge bitcoin#13697: Support output descriptors in scantxoutset

30a49a9

kwvg added a commit to kwvg/dash that referenced this pull request Jul 14, 2021

Merge bitcoin#13697: Support output descriptors in scantxoutset

5024e2b

kwvg added a commit to kwvg/dash that referenced this pull request Jul 15, 2021

Merge bitcoin#13697: Support output descriptors in scantxoutset

463dca7

kwvg added a commit to kwvg/dash that referenced this pull request Jul 15, 2021

Merge bitcoin#13697: Support output descriptors in scantxoutset

262a770

kwvg added a commit to kwvg/dash that referenced this pull request Jul 20, 2021

Merge bitcoin#13697: Support output descriptors in scantxoutset

6113107

kwvg added a commit to kwvg/dash that referenced this pull request Jul 20, 2021

Merge bitcoin#13697: Support output descriptors in scantxoutset

9edc8ca

kwvg added a commit to kwvg/dash that referenced this pull request Jul 20, 2021

Merge bitcoin#13697: Support output descriptors in scantxoutset

e3f4888

kwvg added a commit to kwvg/dash that referenced this pull request Jul 21, 2021

Merge bitcoin#13697: Support output descriptors in scantxoutset

2bdb854

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>

PastaPastaPasta added a commit to dashpay/dash that referenced this pull request Jul 26, 2021

Merge pull request #4187 from kittywhiskers/scantxout

edf0552

merge bitcoin#12196, bitcoin#13697: Add scantxoutset RPC method

theStack mentioned this pull request Sep 11, 2021

refactor: introduce single-separator split helper (boost::split replacement) #22953

Merged

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021


		};

		FlatSigningProvider Merge(const FlatSigningProvider& a, const FlatSigningProvider& b);

Support output descriptors in scantxoutset #13697

Support output descriptors in scantxoutset #13697

Uh oh!

Conversation

sipa commented Jul 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Empact Jul 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

promag left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sipa commented Jul 18, 2018

Uh oh!

achow101 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

sipa commented Jul 17, 2018 •

edited

Loading

Empact Jul 18, 2018 •

edited

Loading

promag commented Jul 18, 2018 •

edited

Loading

sipa commented Jul 18, 2018 •

edited

Loading

Sjors Jul 21, 2018 •

edited

Loading

DrahtBot commented Jul 22, 2018 •

edited

Loading