net: CNetAddr: add support to (un)serialize as ADDRv2 #19845

vasild · 2020-08-31T13:15:49Z

(chopped off from #19031 to ease review)

Add an optional support to serialize/unserialize CNetAddr in ADDRv2 format (BIP155). The new serialization is engaged by ORing a flag into the stream version.

So far this is only used in tests to ensure the new code works as expected.

DrahtBot · 2020-08-31T14:47:48Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

Complete the BIP155 implementation and upgrade to TORv3 #19954 (tor: make a TORv3 hidden service instead of TORv2 by vasild)
Implement ADDRv2 support (part of BIP155) #19031 (Implement ADDRv2 support (part of BIP155) by vasild)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

vasild · 2020-09-01T10:25:41Z

If #19503 gets merged then it could be used to configure the stream to (un)ser in V2 format instead of the currently used ADDRV2_FORMAT flag that is ORed into the stream version.

jonatack · 2020-09-01T13:46:42Z

Concept ACK. First read-through looks promising and happy to see the additional unit test coverage.

Edit: noting here for myself that local debug build is clean and unit tests are green.

vasild · 2020-09-02T08:03:21Z

This PR now contains #19841, needed for the SHA3_256 implementation.

maflcko · 2020-09-05T13:03:57Z

Would it make sense to benchmark how fast addr2 messages are deserialized? Maybe we should even benchmark every message type?

vasild · 2020-09-07T13:38:07Z

Would it make sense to benchmark how fast addr2 messages are deserialized? Maybe we should even benchmark every message type?

benchmark

diff --git i/src/bench/addrman.cpp w/src/bench/addrman.cpp
index ebdad5a4b..db6b1c9fa 100644
--- i/src/bench/addrman.cpp
+++ w/src/bench/addrman.cpp
@@ -1,20 +1,24 @@
 // Copyright (c) 2020-2020 The Bitcoin Core developers
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or http://www.opensource.org/licenses/mit-license.php.
 
 #include <addrman.h>
 #include <bench/bench.h>
+#include <netaddress.h>
 #include <random.h>
+#include <serialize.h>
+#include <streams.h>
 #include <util/time.h>
+#include <version.h>
 
 #include <vector>
 
 /* A "source" is a source address from which we have received a bunch of other addresses. */
 
-static constexpr size_t NUM_SOURCES = 64;
+static constexpr size_t NUM_SOURCES = 1000;
 static constexpr size_t NUM_ADDRESSES_PER_SOURCE = 256;
 
 static std::vector<CAddress> g_sources;
 static std::vector<std::vector<CAddress>> g_addresses;
 
 static void CreateAddresses()
@@ -135,6 +139,36 @@ static void AddrManGood(benchmark::Bench& bench)
 }
 
 BENCHMARK(AddrManAdd);
 BENCHMARK(AddrManSelect);
 BENCHMARK(AddrManGetAddr);
 BENCHMARK(AddrManGood);
+
+static void AddressUnser(benchmark::Bench& bench, int add_to_version)
+{
+    CreateAddresses();
+
+    CDataStream s_orig(SER_NETWORK, PROTOCOL_VERSION | add_to_version);
+    s_orig << g_sources;
+
+    bench.run([&] {
+        CDataStream s(s_orig);
+
+        std::vector<CAddress> unserialized;
+        s >> unserialized;
+
+        assert(s.empty());
+    });
+}
+
+static void AddressUnserV1(benchmark::Bench& bench)
+{
+    AddressUnser(bench, 0);
+}
+
+static void AddressUnserV2(benchmark::Bench& bench)
+{
+    AddressUnser(bench, ADDRV2_FORMAT);
+}
+
+BENCHMARK(AddressUnserV1);
+BENCHMARK(AddressUnserV2);

Results (one operation is "unserialize 1000 addresses"):

$ ./src/bench/bench_bitcoin -filter="AddressUnser.*"

|               ns/op |                op/s |    err% |     total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
|           39,362.00 |           25,405.21 |    0.3% |      0.00 | `AddressUnserV1`
|           49,457.00 |           20,219.58 |    0.0% |      0.00 | `AddressUnserV2`

Unserialize in V2 is expected to be somewhat slower and it is indeed. Looks ok to me.

vasild · 2020-09-10T18:45:50Z

Rebased now that the SHA3_256 implementation is in master.

sipa

Concept/approach ACK. Code looks good, with just a few nits.

I'm a bit surprised that string serialization of TORv3 is implemented (CNetAddr::ToStringIP), but parsing (CNetAddr::SetSpecial) is not. The latter would enable passing TORv3 addresses in -addnode etc. Not a requirement for this PR, but I wanted to point it out as I also don't see it in a follow-up either.

src/netaddress.h

src/test/net_tests.cpp

jonatack

Concept and approach ACK on first pass through the changeset. The unit tests are very helpful. I'm looking forward to this functionality.

src/test/net_tests.cpp

src/netaddress.h

Move the function `HasPrefix()` from `netaddress.cpp` to `util/string.h` so it can be reused by `CNetAddr` methods (and possibly others).

vasild · 2020-09-11T13:44:54Z

Addressed review suggestions and added TORv3 address parsing with some tests.

sipa · 2020-09-11T18:01:24Z

As a test I created a TORv3 bitcoin service, and connected to it with this branch:


$ ./src/bitcoin-cli getpeerinfo
[
  {
    "id": 1,
    "addr": "kpgvmscirrdqpekbqjsvw5teanhatztpp2gl6eee4zkowvwfxwenqaid.onion",

Address suggestions: bitcoin#19845 (comment) bitcoin#19845 (comment)

Address suggestions: bitcoin#19845 (comment) bitcoin#19845 (comment) bitcoin#19845 (comment)

…rksInfo, regression tests 7b5bd31 test: add getnetworkinfo network name regression tests (Jon Atack) 9a75e1e rpc: update GetNetworksInfo() to not return unsupported networks (Jon Atack) ba8997f net: update GetNetworkName() with all enum Network cases (Jon Atack) Pull request description: Following up on the BIP155 addrv2 changes, and starting with 7be6ff6 in #19845, RPC getnetworkinfo began returning networks with empty names. <details><summary><code>getnetworkinfo</code> on current master</summary> ``` "networks": [ { "name": "ipv4", "limited": false, "reachable": true, "proxy": "", "proxy_randomize_credentials": false }, { "name": "ipv6", "limited": false, "reachable": true, "proxy": "", "proxy_randomize_credentials": false }, { "name": "onion", "limited": false, "reachable": true, "proxy": "127.0.0.1:9050", "proxy_randomize_credentials": true }, { "name": "", "limited": false, "reachable": true, "proxy": "", "proxy_randomize_credentials": false }, { "name": "", "limited": false, "reachable": true, "proxy": "", "proxy_randomize_credentials": false } ], ``` </details> <details><summary><code>getnetworkinfo</code> on this branch</summary> ``` "networks": [ { "name": "ipv4", "limited": false, "reachable": true, "proxy": "", "proxy_randomize_credentials": false }, { "name": "ipv6", "limited": false, "reachable": true, "proxy": "", "proxy_randomize_credentials": false }, { "name": "onion", "limited": false, "reachable": true, "proxy": "127.0.0.1:9050", "proxy_randomize_credentials": true } ], ``` </details> This patch: - updates `GetNetworkName()` to the current Network enum - updates `getNetworksInfo()` to ignore as-yet unsupported networks - adds regression tests ACKs for top commit: hebasto: re-ACK 7b5bd31 vasild: ACK 7b5bd31 Tree-SHA512: 8f12363eb430e6f45e59e3b1d69c2f2eb5ead254ce7a67547d116c3b70138d763157335a3c85b51f684a3b3b502c6aace4f6fa60ac3b988cf7a9475a7423c4d7

…etNetworksInfo, regression tests 7b5bd31 test: add getnetworkinfo network name regression tests (Jon Atack) 9a75e1e rpc: update GetNetworksInfo() to not return unsupported networks (Jon Atack) ba8997f net: update GetNetworkName() with all enum Network cases (Jon Atack) Pull request description: Following up on the BIP155 addrv2 changes, and starting with 7be6ff6 in bitcoin#19845, RPC getnetworkinfo began returning networks with empty names. <details><summary><code>getnetworkinfo</code> on current master</summary> ``` "networks": [ { "name": "ipv4", "limited": false, "reachable": true, "proxy": "", "proxy_randomize_credentials": false }, { "name": "ipv6", "limited": false, "reachable": true, "proxy": "", "proxy_randomize_credentials": false }, { "name": "onion", "limited": false, "reachable": true, "proxy": "127.0.0.1:9050", "proxy_randomize_credentials": true }, { "name": "", "limited": false, "reachable": true, "proxy": "", "proxy_randomize_credentials": false }, { "name": "", "limited": false, "reachable": true, "proxy": "", "proxy_randomize_credentials": false } ], ``` </details> <details><summary><code>getnetworkinfo</code> on this branch</summary> ``` "networks": [ { "name": "ipv4", "limited": false, "reachable": true, "proxy": "", "proxy_randomize_credentials": false }, { "name": "ipv6", "limited": false, "reachable": true, "proxy": "", "proxy_randomize_credentials": false }, { "name": "onion", "limited": false, "reachable": true, "proxy": "127.0.0.1:9050", "proxy_randomize_credentials": true } ], ``` </details> This patch: - updates `GetNetworkName()` to the current Network enum - updates `getNetworksInfo()` to ignore as-yet unsupported networks - adds regression tests ACKs for top commit: hebasto: re-ACK 7b5bd31 vasild: ACK 7b5bd31 Tree-SHA512: 8f12363eb430e6f45e59e3b1d69c2f2eb5ead254ce7a67547d116c3b70138d763157335a3c85b51f684a3b3b502c6aace4f6fa60ac3b988cf7a9475a7423c4d7

…nd remove template (followup to #19845) 89836a8 style: minor improvements as a followup to #19845 (Vasil Dimov) Pull request description: Address suggestions: bitcoin/bitcoin#19845 (comment) bitcoin/bitcoin#19845 (comment) bitcoin/bitcoin#19845 (comment) ACKs for top commit: jonatack: re-ACK 89836a8 change since previous review is replacing std::runtime_error with std::exception, built/ran unit tests with gcc debian 10.2.0-15, then broke a few v3 net_tests involving `BOOST_CHECK_EXCEPTION`, rebuilt, ran `src/test/test_bitcoin -t net_tests -l all` and checked the error reporting. hebasto: re-ACK 89836a8 theStack: ACK 89836a8 Tree-SHA512: 36477fdccabe5a8ad91fbabb4655cc363a3a7ca237a98ae6dd4a9fae4a4113762040f864d4ca13a47d081f7d16e5bd487edbfb61ab50a37e4a0424e9bec30b24

…expr/ and remove template (followup to bitcoin#19845) 89836a8 style: minor improvements as a followup to bitcoin#19845 (Vasil Dimov) Pull request description: Address suggestions: bitcoin#19845 (comment) bitcoin#19845 (comment) bitcoin#19845 (comment) ACKs for top commit: jonatack: re-ACK 89836a8 change since previous review is replacing std::runtime_error with std::exception, built/ran unit tests with gcc debian 10.2.0-15, then broke a few v3 net_tests involving `BOOST_CHECK_EXCEPTION`, rebuilt, ran `src/test/test_bitcoin -t net_tests -l all` and checked the error reporting. hebasto: re-ACK 89836a8 theStack: ACK 89836a8 Tree-SHA512: 36477fdccabe5a8ad91fbabb4655cc363a3a7ca237a98ae6dd4a9fae4a4113762040f864d4ca13a47d081f7d16e5bd487edbfb61ab50a37e4a0424e9bec30b24

Address suggestions: bitcoin/bitcoin#19845 (comment) bitcoin/bitcoin#19845 (comment) bitcoin/bitcoin#19845 (comment)

Summary: ``` Move the function `HasPrefix()` from `netaddress.cpp` to `util/string.h` so it can be reused by `CNetAddr` methods (and possibly others). ``` Partial backport (1/4) of core [[bitcoin/bitcoin#19845 | PR19845]]: bitcoin/bitcoin@d2bb681 Test Plan: ninja all check-all Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D9186

Summary: Partial backport (3/4) of core [[bitcoin/bitcoin#19845 | PR19845]]: bitcoin/bitcoin@e0d7357 Depends on D9186 and D9187. Test Plan: ninja all check-all Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Subscribers: majcosta Differential Revision: https://reviews.bitcoinabc.org/D9188

Summary: ``` Recognizing addresses from those networks allows us to accept and gossip them, even though we don't know how to connect to them (yet). ``` Completes backport (4/4) of core [[bitcoin/bitcoin#19845 | PR19845]]: bitcoin/bitcoin@7be6ff6 Depends on D9185 and D9188. Test Plan: ninja all check-all Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Subscribers: majcosta Differential Revision: https://reviews.bitcoinabc.org/D9189

ecde04a [Consensus] Bump Active Protocol version to 70923 for v5.3 (random-zebra) b63e4f5 Consensus: Add v5.3 enforcement height for testnet. (furszy) f44be94 Only relay IPv4, IPv6, Tor addresses (Pieter Wuille) 015298c fix: tor: Call event_base_loopbreak from the event's callback (furszy) 34ff7a8 Consensus: Add mnb ADDRv2 guard. (furszy) b4515dc GUI: Present v3 onion addresses properly in MNs list. (furszy) 337d43d tests: don't export in6addr_loopback (Vasil Dimov) 2cde8e0 GUI: Do not show the tor v3 onion address in the topbar. (furszy) 0b5f406 Doc: update tor.md with latest upstream information. (furszy) 89df7f2 addrman: ensure old versions don't parse peers.dat (Vasil Dimov) bb90c5c test: add getnetworkinfo network name regression tests (Jon Atack) d8e01b5 rpc: update GetNetworksInfo() to not return unsupported networks (Jon Atack) 57fc7b0 net: update GetNetworkName() with all enum Network cases (Jon Atack) 647d60b tests: Modify rpc_bind to conform to bitcoin#14532 behaviour. (Carl Dong) d4d6729 Allow running rpc_bind.py --nonloopback test without IPv6 (Kristaps Kaupe) 4a034d8 test: Add rpc_bind test to default-run tests (Wladimir J. van der Laan) 61a08af [tests] bind functional test nodes to 127.0.0.1 Prevents OSX firewall (Sjors Provoost) 6a4f1e0 test: Add basic addr relay test (furszy) 78aa61c net: Make addr relay mockable (furszy) ba954ca Send and require SENDADDRV2 before VERACK (Pieter Wuille) 61c2ed4 Bump net protocol version + don't send 'sendaddrv2' to pre-70923 software (furszy) ccd508a tor: make a TORv3 hidden service instead of TORv2 (Vasil Dimov) 6da9a14 net: advertise support for ADDRv2 via new message (furszy) e58d5d0 Migrate to test_large_inv() to Misbehaving logging. (furszy) d496b64 [QA] fix mininode CAddress ser/deser (Jonas Schnelli) cec9567 net: CAddress & CAddrMan: (un)serialize as ADDRv2 Change the serialization of `CAddrMan` to serialize its addresses in ADDRv2/BIP155 format by default. Introduce a new `CAddrMan` format version (3). (furszy) b8c1dda streams update: get rid of nType and nVersion. (furszy) 3eaa273 Support bypassing range check in ReadCompactSize (Pieter Wuille) a237ba4 net: recognize TORv3/I2P/CJDNS networks (Vasil Dimov) 8e50853 util: make EncodeBase32 consume Spans (Sebastian Falbesoner) 1f67e30 net: CNetAddr: add support to (un)serialize as ADDRv2 (Vasil Dimov) 2455420 test: move HasReason so it can be reused (furszy) d41adb4 util: move HasPrefix() so it can be reused (Vasil Dimov) f6f86af Unroll Keccak-f implementation (Pieter Wuille) 45222e6 Implement keccak-f[1600] and SHA3-256 (Pieter Wuille) 08ad06d net: change CNetAddr::ip to have flexible size (furszy) 3337219 net: improve encapsulation of CNetAddr. (furszy) 910d5c4 test: Do not instantiate CAddrDB for static call (Hennadii Stepanov) 6b607ef Drop IsLimited in favor of IsReachable (Ben Woosley) a40711b IsReachable is the inverse of IsLimited (DRY). Includes unit tests (marcaiaf) 8839828 net: don't accept non-left-contiguous netmasks (Vasil Dimov) 5d7f864 rpcbind: Warn about exposing RPC to untrusted networks (Luke Dashjr) 2a6abd8 CNetAddr: Add IsBindAny method to check for INADDR_ANY (Luke Dashjr) 4fdfa45 net: Always default rpcbind to localhost, never "all interfaces" (Luke Dashjr) 31064a8 net: Minor accumulated cleanups (furszy) 9f9c871 tests: Avoid using C-style NUL-terminated strings as arguments (practicalswift) f6c52a3 tests: Add tests to make sure lookup methods fail on std::string parameters with embedded NUL characters (practicalswift) a751b9b net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface (furszy) f30869d test: add IsRFC2544 tests (Mark Tyneway) ed5abe1 Net: Proper CService deserialization + GetIn6Addr return false if addr isn't an IPv6 addr (furszy) 86d73fb net: save the network type explicitly in CNetAddr (Vasil Dimov) ad57dfc net: document `enum Network` (Vasil Dimov) cb160de netaddress: Update CNetAddr for ORCHIDv2 (Carl Dong) c3c04e4 net: Better misbehaving logging (furszy) 3660487 net: Use C++11 member initialization in protocol (Marco) 082baa3 refactor: Drop unused CBufferedFile::Seek() (Hennadii Stepanov) e2d776a util: CBufferedFile fixes (Larry Ruane) 6921f42 streams: backport OverrideStream class (furszy) Pull request description: Conjunction of a large number of back ports, updates and refactorings that made with the final goal of implementing v3 Onion addresses support (BIP155 https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki) before the tor v2 addresses EOL, scheduled, by the Tor project, for (1) July 15th: v2 addr support removal from the code base, and (2) October 15th: v2 addr network disable, where **every peer in our network running under Tor will loose the connection and drop the network**. As BIP155 describes, this is introducing a new P2P message to gossip longer node addresses over the P2P network. This is required to support new-generation Onion addresses, I2P, and potentially other networks that have longer endpoint addresses than fit in the 128 bits of the current addr message. In order to achieve the end goal, had to: 1. Create Span class and push it up to latest Bitcoin implementation. 2. Update the whole serialization framework and every object using it up to latest Bitcoin implementation (3-4 years ahead of what we currently are in master). 3. Update the address manager implementing ASN-based bucketing of the network nodes. 4. Update and refactor the netAddress and address manager tests to latest Bitcoin implementation (4 years ahead of what we currently are in master). 5. Several util string, vector, encodings, parsing, hashing backports and more.. Important note: This PR it is not meant to be merged as a standalone PR, will decouple smaller ones moving on. Adding on each sub-PR its own description isolated from this big monster. Second note: This is still a **work-in-progress**, not ready for testing yet. I'm probably missing to mention few PRs that have already adapted to our sources. Just making it public so can decouple the changes, we can start merging them and i can continue working a bit more confortable (rebase a +170 commits separate branch is not fun..). ### List of back ported and adapted PRs: Span and Serialization: ---------------- * bitcoin#12886. * bitcoin#12916. * bitcoin#13558. * bitcoin#13697. (Only Span's commit 29943a9) * bitcoin#17850. * bitcoin#17896. * bitcoin#12752. * bitcoin#16577. * bitcoin#16670. (without faebf62) * bitcoin#17957. * bitcoin#18021. * bitcoin#18087. * bitcoin#18112 (only from 353f376 that we don't support). * bitcoin#18167. * bitcoin#18317. * bitcoin#18591 (only Span's commit 0fbde48) * bitcoin#18468. * bitcoin#19020. * bitcoin#19032. * bitcoin#19367. * bitcoin#19387. Net, NetAddress and AddrMan: ---------------- * bitcoin#7932. * bitcoin#10756. * bitcoin#10765. * bitcoin#12218. * bitcoin#12855. * bitcoin#13532. * bitcoin#13575. * bitcoin#13815. * bitcoin#14532. * bitcoin#15051. * bitcoin#15138. * bitcoin#15689. * bitcoin#16702. * bitcoin#17243. * bitcoin#17345. * bitcoin#17754. * bitcoin#17758. * bitcoin#17812. * bitcoin#18023. * bitcoin#18454. * bitcoin#18512. * bitcoin#19314. * bitcoin#19687 Keys and Addresses encoding: ---------------- * bitcoin#11372. * bitcoin#17511. * bitcoin#17721. Util: ---------------- * bitcoin#9140. * bitcoin#16577. * bitcoin#16889. * bitcoin#19593. Bench: ---------------- * bitcoin#16299. BIP155: ---------------- * bitcoin#19351. * bitcoin#19360. * bitcoin#19534. * bitcoin#19628. * bitcoin#19841. * bitcoin#19845. * bitcoin#19954. * bitcoin#19991 (pending). * bitcoin#19845. * bitcoin#20000 (pending). * bitcoin#20120. * bitcoin#20284. * bitcoin#20564. * bitcoin#21157 (pending). * bitcoin#21564 (pending). * Fully removed v2 onion addr support. * Add hardcoded seeds. * Add release-notes, changes to files.md and every needed documentation. I'm currently working on the PRs marked as "pending", this isn't over, but I'm pretty pretty close :). What a long road.. ACKs for top commit: random-zebra: utACK ecde04a Fuzzbawls: ACK ecde04a Tree-SHA512: 82c95fbda76fce63f96d8a9af7fa9a89cb1e1b302b7891e27118a6103af0be23606bf202c7332fa61908205e6b6351764e2ec23d753f1e2484028f57c2e8b51a

…ssion tests Summary: PR description: > Following up on the BIP155 addrv2 changes, and starting with [[bitcoin/bitcoin#19845 | core#19845]], RPC getnetworkinfo began returning networks with empty names. > > This patch: > > - updates `GetNetworkName()` to the current Network enum > - updates `getNetworksInfo()` to ignore as-yet unsupported networks > - adds regression tests This is a backport of [[bitcoin/bitcoin#20120 | core#20120]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10720

Summary: Minor follow-up to [[bitcoin/bitcoin#19845 | core#19845]] (D10720). The template was thought to be needed to handle both `std::ios_base::failure` and `std::runtime_error`, but they both inherit `std:eexception` so it is not necessary. This is a backport of [[bitcoin/bitcoin#20033 | core#20033]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10732

vasild mentioned this pull request Aug 31, 2020

Implement ADDRv2 support (part of BIP155) #19031

Closed

11 tasks

DrahtBot added Build system P2P Utils/log/libs labels Aug 31, 2020

This was referenced Aug 31, 2020

Implement Keccak and SHA3_256 #19841

Merged

Erlay: bandwidth-efficient transaction relay protocol #18261

Closed

net: Add NAT-PMP port forwarding support #18077

Merged

maflcko removed Build system Utils/log/libs labels Sep 1, 2020

vasild force-pushed the ser_addrv2_cnetaddr branch from 08fa894 to b64283c Compare September 1, 2020 08:15

vasild mentioned this pull request Sep 1, 2020

net: change CNetAddr::ip to have flexible size #19628

Merged

This was referenced Sep 1, 2020

Add hash_type MUHASH for gettxoutsetinfo #19145

Merged

Add MuHash3072 implementation #19055

Merged

lib: Optimizing siphash implementation #18014

Closed

DrahtBot added the Needs rebase label Sep 10, 2020

vasild force-pushed the ser_addrv2_cnetaddr branch from b64283c to 9eb5b08 Compare September 10, 2020 18:44

DrahtBot removed the Needs rebase label Sep 10, 2020

sipa reviewed Sep 10, 2020

View reviewed changes

src/netaddress.h Outdated Show resolved Hide resolved

src/netaddress.h Outdated Show resolved Hide resolved

src/netaddress.h Outdated Show resolved Hide resolved

src/test/net_tests.cpp Outdated Show resolved Hide resolved

jonatack reviewed Sep 11, 2020

View reviewed changes

src/test/net_tests.cpp Outdated Show resolved Hide resolved

src/test/net_tests.cpp Outdated Show resolved Hide resolved

src/netaddress.h Show resolved Hide resolved

util: move HasPrefix() so it can be reused

d2bb681

Move the function `HasPrefix()` from `netaddress.cpp` to `util/string.h` so it can be reused by `CNetAddr` methods (and possibly others).

vasild force-pushed the ser_addrv2_cnetaddr branch from 9eb5b08 to e55631e Compare September 11, 2020 13:36

vasild added a commit to vasild/bitcoin that referenced this pull request Sep 29, 2020

style: minor improvements as a followup to bitcoin#19845

7db9bf3

Address suggestions: bitcoin#19845 (comment) bitcoin#19845 (comment)

vasild mentioned this pull request Sep 29, 2020

refactor: minor whitespace fixups, s/const/constexpr/ and remove template (followup to #19845) #20033

Merged

jonatack mentioned this pull request Oct 7, 2020

Implement BIP 340-342 validation (Schnorr/taproot/tapscript) #19953

Merged

hebasto mentioned this pull request Oct 14, 2020

net, rpc, test, bugfix: update GetNetworkName, GetNetworksInfo, regression tests #20120

Merged

vasild added a commit to vasild/bitcoin that referenced this pull request Oct 31, 2020

style: minor improvements as a followup to bitcoin#19845

b763174

Address suggestions: bitcoin#19845 (comment) bitcoin#19845 (comment) bitcoin#19845 (comment)

vasild added a commit to vasild/bitcoin that referenced this pull request Oct 31, 2020

style: minor improvements as a followup to bitcoin#19845

89836a8

Address suggestions: bitcoin#19845 (comment) bitcoin#19845 (comment) bitcoin#19845 (comment)

jonatack mentioned this pull request Nov 30, 2020

util: Avoid invalid integer negation in FormatMoney and ValueFromAmount #20406

Merged

janus pushed a commit to janus/bitgesell that referenced this pull request Dec 13, 2020

style: minor improvements as a followup to #19845

5e6fe52

Address suggestions: bitcoin/bitcoin#19845 (comment) bitcoin/bitcoin#19845 (comment) bitcoin/bitcoin#19845 (comment)

jonatack mentioned this pull request Dec 22, 2020

validation: UTXO snapshot activation #19806

Merged

kwvg mentioned this pull request Mar 8, 2021

partial #8149 and merge #19845, #19954: Complete the BIP155 implementation and upgrade to TORv3 dashpay/dash#4025

Closed

Empact mentioned this pull request Apr 2, 2021

net: Avoid calling getnameinfo when formatting IPv4 addresses in CNetAddr::ToStringIP #21564

Merged

kwvg pushed a commit to kwvg/dash that referenced this pull request May 25, 2021

merge bitcoin#19845: add support to (un)serialize as ADDRv2

b5f18ce

kwvg added a commit to kwvg/dash that referenced this pull request May 25, 2021

merge bitcoin#19845: add support to (un)serialize as ADDRv2

42872e5

kwvg added a commit to kwvg/dash that referenced this pull request May 25, 2021

merge bitcoin#19845: add support to (un)serialize as ADDRv2

41ed5a8

kwvg added a commit to kwvg/dash that referenced this pull request May 25, 2021

merge bitcoin#19845: add support to (un)serialize as ADDRv2

7770341

UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request May 28, 2021

merge bitcoin#19845: add support to (un)serialize as ADDRv2

beac6df

UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request May 28, 2021

merge bitcoin#19845: add support to (un)serialize as ADDRv2

9d4f908

UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request May 29, 2021

merge bitcoin#19845: add support to (un)serialize as ADDRv2

20bd301

furszy mentioned this pull request Jun 7, 2021

Road to Tor v3 support (BIP155) PIVX-Project/PIVX#2411

Merged

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

net: CNetAddr: add support to (un)serialize as ADDRv2 #19845

net: CNetAddr: add support to (un)serialize as ADDRv2 #19845

Uh oh!

vasild commented Aug 31, 2020 •

edited

Loading

Uh oh!

DrahtBot commented Aug 31, 2020 •

edited

Loading

Uh oh!

vasild commented Sep 1, 2020

Uh oh!

jonatack commented Sep 1, 2020 •

edited

Loading

Uh oh!

vasild commented Sep 2, 2020

Uh oh!

maflcko commented Sep 5, 2020

Uh oh!

vasild commented Sep 7, 2020

Uh oh!

vasild commented Sep 10, 2020

Uh oh!

sipa left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonatack left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vasild commented Sep 11, 2020

Uh oh!

sipa commented Sep 11, 2020

Uh oh!

Uh oh!

net: CNetAddr: add support to (un)serialize as ADDRv2 #19845

net: CNetAddr: add support to (un)serialize as ADDRv2 #19845

Uh oh!

Conversation

vasild commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Aug 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

vasild commented Sep 1, 2020

Uh oh!

jonatack commented Sep 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vasild commented Sep 2, 2020

Uh oh!

maflcko commented Sep 5, 2020

Uh oh!

vasild commented Sep 7, 2020

Uh oh!

vasild commented Sep 10, 2020

Uh oh!

sipa left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vasild commented Sep 11, 2020

Uh oh!

sipa commented Sep 11, 2020

Uh oh!

Uh oh!

vasild commented Aug 31, 2020 •

edited

Loading

DrahtBot commented Aug 31, 2020 •

edited

Loading

jonatack commented Sep 1, 2020 •

edited

Loading

sipa left a comment •

edited

Loading