span: update constructors to match c++20 draft spec and add lifetimebound attribute #19387

theuni · 2020-06-26T18:24:02Z

Replaces #19382 with a different approach. See this comment for the reasoning behind the switch.

--

Description from #19382:

See here for more detail on lifetimebound.

This is implemented using preprocesor macros rather than configure checks in order to keep span.h self-contained.

The [[clang::lifetimebound]] syntax was chosen over __attribute__((lifetimebound)) because the former is more flexible and works to guard this as well as function parameters, and also because at least for now, it's available only in clang.

There are currently no violations in our codebase, but this can easily be tested by inserting one like this somewhere and compiling with a modern clang:

Span<const int> bad(std::vector<int>{1,2,3});

The result:

warning: temporary whose address is used as value of local variable 'bad' will be destroyed at the end of the full-expression [-Wdangling]
Span bad(std::vector{1,2,3});

src/span.h

sipa · 2020-06-26T22:07:39Z

ACK apart from nit above.

I've tested this by rebasing #13062 and #19326 on top, and compiling with Clang 10; no warnings. Adding an obvious Span<const int> bad{std::vector<int>{}}; does produce a warning.

It does seem that no warning is produced when MakeSpan is used in between, and I can't get that fixed. I think that's fine, but it'd be nice to improve upon.

practicalswift · 2020-06-28T13:02:43Z

Concept ACK: [[clang::lifetimebound]] is great! :)

I think this will be useful also outside of src/span.{cpp,h}. What about adding it to src/attributes.h as LIFETIMEBOUND?

diff --git a/src/attributes.h b/src/attributes.h
index 45099bd8b..9d5c1d44a 100644
--- a/src/attributes.h
+++ b/src/attributes.h
@@ -19,4 +19,14 @@
 #  endif
 #endif
 
+#if defined(__clang__)
+#  if __has_attribute(lifetimebound)
+#    define LIFETIMEBOUND [[clang::lifetimebound]]
+#  else
+#    define LIFETIMEBOUND
+#  endif
+#else
+#  define LIFETIMEBOUND
+#endif
+
 #endif // BITCOIN_ATTRIBUTES_H

jonatack · 2020-06-28T13:29:10Z

Concept ACK

c++20's draft of std::span no longer includes move constructors.

theuni · 2020-06-29T17:57:32Z

Updated and squashed.

@practicalswift I'd rather wait to add it there until there's a use for it, if that's ok. By the time we have it to use somewhere else, it may not be clang-only anymore.

~~I did change it to use __has_cpp_attribute to match our existing attribute check, though.~~

Edit: whoops, __has_cpp_attribute doesn't actually work here! Back to __has_attribute.

See http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0936r0.pdf for reference. This helps to guard against dangling references caused by construction from temporaries such as: Span<const int> sp(std::vector<int>{1,2,3});

theuni · 2020-06-29T19:22:23Z

Sorry for the pushing/rebasing noise, done now.

It does seem that no warning is produced when MakeSpan is used in between, and I can't get that fixed. I think that's fine, but it'd be nice to improve upon.

@sipa It turns out that this warning does work for MakeSpan, but only in c++17 mode and above:

$ clang++ spantest.cpp -o spantest -std=c++17

spantest.cpp:10:26: warning: temporary whose address is used as value of local variable 'temp' will be destroyed at the end of the full-expression [-Wdangling]
auto temp = MakeSpan(std::vector{1,2,3});

I've gone ahead and added the annotations there as well, so they should just magically work when we switch to c++17.

sipa · 2020-07-01T04:27:59Z

so they should just magically work when we switch to c++17.

I like magic.

ACK 1d58cc7

maflcko · 2020-07-01T12:25:19Z

Instead of magic, I'd rather remove them and add the corresponding constructors from c++20 when we switched to c++17

second-commit-only review ACK 1d58cc7

maflcko · 2020-07-01T20:14:24Z

src/span.h

@@ -18,6 +18,16 @@
 #define ASSERT_IF_DEBUG(x)
 #endif

+#if defined(__clang__)
+#if __has_attribute(lifetimebound)
+#define SPAN_ATTR_LIFETIMEBOUND [[clang::lifetimebound]]


Suggested change

#define SPAN_ATTR_LIFETIMEBOUND [[clang::lifetimebound]]

#define ATTR_LIFETIMEBOUND [[clang::lifetimebound]]

Can this be named a bit more generic, so that it can be used in other places such as #19426 ?

I namespaced it to avoid colliding with a more general define. As span.h is designed to be an abstraction, I'd really prefer to keep it an island and not require that it include another header.

Since @sipa was quick to point out a few places where this could already be useful, how about going with @practicalswift's idea of adding a second, more generic define in attributes.h ?

@theuni Not sure how to weigh code duplication vs. a dependency on attributes.h. I'm fine with either.

sipa · 2020-07-01T23:30:28Z

@MarcoFalke Well, no reason why we can't have both. The attribute as argument to MakeSpan makes sense - even if the compiler doesn't do anything useful with it - as it documents behavior to the user as well. And perhaps clang 123091137.4 will support it even in C++11 mode - who knows.

sipa · 2020-07-02T00:19:39Z

There are a lot more cases in the codebase where a data type stores a reference or pointer to another object provided to the constructor exist. For example:

In src/stream.h: OverrideStream, CVectorReader, BitStreamReader, BitStreamWriter
In src/script/sign.h: MutableTransactionSignatureCreator (refactor: Change * to & in MutableTransactionSignatureCreator #19426).
In src/script/interpreter.h: GenericTransactionSignatureChecker
In src/serialize.h: Wrapper, Using
In src/wallet/rpcwallet.cpp: DescribeWalletAddressVisitor
In src/key_io.cpp: DestinationEncoder
In src/dbwrapper.h: CDBBatch, CDBIterator
In src/flatfile.h: FlatFileSeq
In src/hash.h: CHashVerifier
In src/miner.h: CBlockAssembler
In src/net_processing.h: PeerLogicValidation
In src/scheduler.h: SingleThreadedSchedulerClient
In src/sync.h: CSemaphoreGrant
In src/validation.h: CScriptCheck, ChainstateManager, CChainState

Several of these accept const lvalue references, and store them, and are at risk already. Others take in a mutable lvalue reference or pointers, but would make sense to support rvalue/universal references as input (so that temporaries can be passed to it). In all those cases, having a lifetimebound attribute would be useful.

So I think that means we should just put it in attributes.h. There is plenty of potential for it.

jonatack

Non-expert code review ACK 1d58cc7

Looked at the linked doc and other docs/implementations I could find, abseil/span.h etc. This compiled fine including with it added to src/attributes.h. Unfortunately I am currently stuck on Debian Clang 6 which is less helpful.

jonatack · 2020-07-04T22:48:07Z

Upgraded to Clang 11 and now see the -Wdangling warning mentioned in the PR description.

wallet/rpcwallet.cpp:42:22: warning: temporary whose address is used as value of local variable
'a_bad_vec' will be destroyed at the end of the full-expression [-Wdangling]
Span<const int> a_bad_vec(std::vector<int>{1,2,3});
                     ^~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Co-authored-by: practicalswift <practicalswift@users.noreply.github.com>

sipa · 2020-07-08T17:46:12Z

ACK e3e7446

sipa · 2020-07-08T17:46:33Z

Sorry, I misclicked.

jonatack

ACK e3e7446 change since last review is adding [[clang::lifetimebound]] as LIFETIMEBOUND to src/attributes.h as suggested in #19387 (comment).

src/attributes.h

…pec and…

…rpose usage bitcoin@e3e7446

bitcoin@62733fe

bitcoin@1d58cc7

…rpose usage bitcoin@e3e7446

bitcoin@62733fe

bitcoin@1d58cc7

…ose usage bitcoin@e3e7446

bitcoin@62733fe

bitcoin@1d58cc7

…ose usage bitcoin@e3e7446

bitcoin@62733fe

bitcoin@1d58cc7

…ose usage bitcoin@e3e7446

…pec and add lifetimebound attribute bitcoin@62733fe bitcoin@1d58cc7 bitcoin@e3e7446

partial merge bitcoin#13697, bitcoin#18591, bitcoin#19387, bitcoin#18468: update constructors to match c++20 draft spec

a1f3aed util: make EncodeBase64 consume Spans (furszy) c36754f Add MakeUCharSpan, to help constructing Span<[const] unsigned char> (Pieter Wuille) 1f18199 Make uint256 Span-convertible by adding ::data() (Pieter Wuille) 0067590 Add lifetimebound to attributes for general-purpose usage (Cory Fields) 26eb256 span: add lifetimebound attribute (Cory Fields) 696e91f span: (almost) match std::span's constructor behavior (Cory Fields) da207d4 doc: Mention Span in developer-notes.md (Pieter Wuille) 138053d doc: Document Span pitfalls (Pieter Wuille) e2216d7 Add sanity check asserts to span when -DDEBUG (Pieter Wuille) ebcc978 Add Span constructors for arrays and vectors (Pieter Wuille) 38f105b Make pointer-based Span construction safer (Pieter Wuille) 33d5297 Make Span size type unsigned (Pieter Wuille) 17118e1 Support conversion between Spans of compatible types (Pieter Wuille) f36042f Span front() and back() methods and SpanPopBack function backport (furszy) 1b2e7c8 Add more methods to Span class (Pieter Wuille) Pull request description: Another decouple from #2411. Purely focused on updating the Span sources to be up-to-date with current upstream. Following PRs/commits were back ported: * bitcoin#13697 (only 29943a9) * 2b0fcff (only span changes). * bitcoin#18591 (only 0fbde48). * bitcoin#18468 (without 2676aea). * bitcoin#19367. * bitcoin#19387. * bitcoin#19326 (only 5678250 and e63dcc3 here). * bitcoin#19687 (only e2aa1a5 here, 2bc2071 is inside #2411 and require net related commits that are introduced down the commits line there). Extra side note: Some of the current serialization compiler warnings in master will be fixed with this, other ones are coming down 2411 commits line as they need other previous PRs. ACKs for top commit: random-zebra: Tested ACK a1f3aed Tree-SHA512: 256bc2064724ea6d4f6fac722fafb4ed3e2b4590cdad61bf1e4a5be25e0632bafcff39235ea6ed7badbef4f79dbb4f866356372a1b3c201af23873884baedfea

ecde04a [Consensus] Bump Active Protocol version to 70923 for v5.3 (random-zebra) b63e4f5 Consensus: Add v5.3 enforcement height for testnet. (furszy) f44be94 Only relay IPv4, IPv6, Tor addresses (Pieter Wuille) 015298c fix: tor: Call event_base_loopbreak from the event's callback (furszy) 34ff7a8 Consensus: Add mnb ADDRv2 guard. (furszy) b4515dc GUI: Present v3 onion addresses properly in MNs list. (furszy) 337d43d tests: don't export in6addr_loopback (Vasil Dimov) 2cde8e0 GUI: Do not show the tor v3 onion address in the topbar. (furszy) 0b5f406 Doc: update tor.md with latest upstream information. (furszy) 89df7f2 addrman: ensure old versions don't parse peers.dat (Vasil Dimov) bb90c5c test: add getnetworkinfo network name regression tests (Jon Atack) d8e01b5 rpc: update GetNetworksInfo() to not return unsupported networks (Jon Atack) 57fc7b0 net: update GetNetworkName() with all enum Network cases (Jon Atack) 647d60b tests: Modify rpc_bind to conform to bitcoin#14532 behaviour. (Carl Dong) d4d6729 Allow running rpc_bind.py --nonloopback test without IPv6 (Kristaps Kaupe) 4a034d8 test: Add rpc_bind test to default-run tests (Wladimir J. van der Laan) 61a08af [tests] bind functional test nodes to 127.0.0.1 Prevents OSX firewall (Sjors Provoost) 6a4f1e0 test: Add basic addr relay test (furszy) 78aa61c net: Make addr relay mockable (furszy) ba954ca Send and require SENDADDRV2 before VERACK (Pieter Wuille) 61c2ed4 Bump net protocol version + don't send 'sendaddrv2' to pre-70923 software (furszy) ccd508a tor: make a TORv3 hidden service instead of TORv2 (Vasil Dimov) 6da9a14 net: advertise support for ADDRv2 via new message (furszy) e58d5d0 Migrate to test_large_inv() to Misbehaving logging. (furszy) d496b64 [QA] fix mininode CAddress ser/deser (Jonas Schnelli) cec9567 net: CAddress & CAddrMan: (un)serialize as ADDRv2 Change the serialization of `CAddrMan` to serialize its addresses in ADDRv2/BIP155 format by default. Introduce a new `CAddrMan` format version (3). (furszy) b8c1dda streams update: get rid of nType and nVersion. (furszy) 3eaa273 Support bypassing range check in ReadCompactSize (Pieter Wuille) a237ba4 net: recognize TORv3/I2P/CJDNS networks (Vasil Dimov) 8e50853 util: make EncodeBase32 consume Spans (Sebastian Falbesoner) 1f67e30 net: CNetAddr: add support to (un)serialize as ADDRv2 (Vasil Dimov) 2455420 test: move HasReason so it can be reused (furszy) d41adb4 util: move HasPrefix() so it can be reused (Vasil Dimov) f6f86af Unroll Keccak-f implementation (Pieter Wuille) 45222e6 Implement keccak-f[1600] and SHA3-256 (Pieter Wuille) 08ad06d net: change CNetAddr::ip to have flexible size (furszy) 3337219 net: improve encapsulation of CNetAddr. (furszy) 910d5c4 test: Do not instantiate CAddrDB for static call (Hennadii Stepanov) 6b607ef Drop IsLimited in favor of IsReachable (Ben Woosley) a40711b IsReachable is the inverse of IsLimited (DRY). Includes unit tests (marcaiaf) 8839828 net: don't accept non-left-contiguous netmasks (Vasil Dimov) 5d7f864 rpcbind: Warn about exposing RPC to untrusted networks (Luke Dashjr) 2a6abd8 CNetAddr: Add IsBindAny method to check for INADDR_ANY (Luke Dashjr) 4fdfa45 net: Always default rpcbind to localhost, never "all interfaces" (Luke Dashjr) 31064a8 net: Minor accumulated cleanups (furszy) 9f9c871 tests: Avoid using C-style NUL-terminated strings as arguments (practicalswift) f6c52a3 tests: Add tests to make sure lookup methods fail on std::string parameters with embedded NUL characters (practicalswift) a751b9b net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface (furszy) f30869d test: add IsRFC2544 tests (Mark Tyneway) ed5abe1 Net: Proper CService deserialization + GetIn6Addr return false if addr isn't an IPv6 addr (furszy) 86d73fb net: save the network type explicitly in CNetAddr (Vasil Dimov) ad57dfc net: document `enum Network` (Vasil Dimov) cb160de netaddress: Update CNetAddr for ORCHIDv2 (Carl Dong) c3c04e4 net: Better misbehaving logging (furszy) 3660487 net: Use C++11 member initialization in protocol (Marco) 082baa3 refactor: Drop unused CBufferedFile::Seek() (Hennadii Stepanov) e2d776a util: CBufferedFile fixes (Larry Ruane) 6921f42 streams: backport OverrideStream class (furszy) Pull request description: Conjunction of a large number of back ports, updates and refactorings that made with the final goal of implementing v3 Onion addresses support (BIP155 https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki) before the tor v2 addresses EOL, scheduled, by the Tor project, for (1) July 15th: v2 addr support removal from the code base, and (2) October 15th: v2 addr network disable, where **every peer in our network running under Tor will loose the connection and drop the network**. As BIP155 describes, this is introducing a new P2P message to gossip longer node addresses over the P2P network. This is required to support new-generation Onion addresses, I2P, and potentially other networks that have longer endpoint addresses than fit in the 128 bits of the current addr message. In order to achieve the end goal, had to: 1. Create Span class and push it up to latest Bitcoin implementation. 2. Update the whole serialization framework and every object using it up to latest Bitcoin implementation (3-4 years ahead of what we currently are in master). 3. Update the address manager implementing ASN-based bucketing of the network nodes. 4. Update and refactor the netAddress and address manager tests to latest Bitcoin implementation (4 years ahead of what we currently are in master). 5. Several util string, vector, encodings, parsing, hashing backports and more.. Important note: This PR it is not meant to be merged as a standalone PR, will decouple smaller ones moving on. Adding on each sub-PR its own description isolated from this big monster. Second note: This is still a **work-in-progress**, not ready for testing yet. I'm probably missing to mention few PRs that have already adapted to our sources. Just making it public so can decouple the changes, we can start merging them and i can continue working a bit more confortable (rebase a +170 commits separate branch is not fun..). ### List of back ported and adapted PRs: Span and Serialization: ---------------- * bitcoin#12886. * bitcoin#12916. * bitcoin#13558. * bitcoin#13697. (Only Span's commit 29943a9) * bitcoin#17850. * bitcoin#17896. * bitcoin#12752. * bitcoin#16577. * bitcoin#16670. (without faebf62) * bitcoin#17957. * bitcoin#18021. * bitcoin#18087. * bitcoin#18112 (only from 353f376 that we don't support). * bitcoin#18167. * bitcoin#18317. * bitcoin#18591 (only Span's commit 0fbde48) * bitcoin#18468. * bitcoin#19020. * bitcoin#19032. * bitcoin#19367. * bitcoin#19387. Net, NetAddress and AddrMan: ---------------- * bitcoin#7932. * bitcoin#10756. * bitcoin#10765. * bitcoin#12218. * bitcoin#12855. * bitcoin#13532. * bitcoin#13575. * bitcoin#13815. * bitcoin#14532. * bitcoin#15051. * bitcoin#15138. * bitcoin#15689. * bitcoin#16702. * bitcoin#17243. * bitcoin#17345. * bitcoin#17754. * bitcoin#17758. * bitcoin#17812. * bitcoin#18023. * bitcoin#18454. * bitcoin#18512. * bitcoin#19314. * bitcoin#19687 Keys and Addresses encoding: ---------------- * bitcoin#11372. * bitcoin#17511. * bitcoin#17721. Util: ---------------- * bitcoin#9140. * bitcoin#16577. * bitcoin#16889. * bitcoin#19593. Bench: ---------------- * bitcoin#16299. BIP155: ---------------- * bitcoin#19351. * bitcoin#19360. * bitcoin#19534. * bitcoin#19628. * bitcoin#19841. * bitcoin#19845. * bitcoin#19954. * bitcoin#19991 (pending). * bitcoin#19845. * bitcoin#20000 (pending). * bitcoin#20120. * bitcoin#20284. * bitcoin#20564. * bitcoin#21157 (pending). * bitcoin#21564 (pending). * Fully removed v2 onion addr support. * Add hardcoded seeds. * Add release-notes, changes to files.md and every needed documentation. I'm currently working on the PRs marked as "pending", this isn't over, but I'm pretty pretty close :). What a long road.. ACKs for top commit: random-zebra: utACK ecde04a Fuzzbawls: ACK ecde04a Tree-SHA512: 82c95fbda76fce63f96d8a9af7fa9a89cb1e1b302b7891e27118a6103af0be23606bf202c7332fa61908205e6b6351764e2ec23d753f1e2484028f57c2e8b51a

…ound attribute Summary: > span: (almost) match std::span's constructor behavior > > c++20's draft of std::span no longer includes move constructors. > span: add lifetimebound attribute > > See http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0936r0.pdf for > reference. > > This helps to guard against dangling references caused by construction from > temporaries such as: > > `Span<const int> sp(std::vector<int>{1,2,3});` > Add lifetimebound to attributes for general-purpose usage > > Co-authored-by: practicalswift <practicalswift@users.noreply.github.com> This is a backport of [[bitcoin/bitcoin#19387 | core#19387]] Test Plan: With clang and gcc: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D10888

sipa reviewed Jun 26, 2020

View reviewed changes

src/span.h Outdated Show resolved Hide resolved

sipa mentioned this pull request Jun 26, 2020

doc: Span pitfalls #19367

Merged

theuni force-pushed the lifetimebound2 branch from 6d47b23 to f9a1b94 Compare June 29, 2020 17:45

span: (almost) match std::span's constructor behavior

62733fe

c++20's draft of std::span no longer includes move constructors.

theuni force-pushed the lifetimebound2 branch 2 times, most recently from f3f66a4 to dafa901 Compare June 29, 2020 17:54

theuni force-pushed the lifetimebound2 branch from dafa901 to 56fa5b8 Compare June 29, 2020 19:00

span: add lifetimebound attribute

1d58cc7

See http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0936r0.pdf for reference. This helps to guard against dangling references caused by construction from temporaries such as: Span<const int> sp(std::vector<int>{1,2,3});

theuni force-pushed the lifetimebound2 branch from 56fa5b8 to 1d58cc7 Compare June 29, 2020 19:15

maflcko added the Refactoring label Jul 1, 2020

sipa mentioned this pull request Jul 1, 2020

refactor: Change * to & in MutableTransactionSignatureCreator #19426

Merged

maflcko reviewed Jul 1, 2020

View reviewed changes

jonatack reviewed Jul 3, 2020

View reviewed changes

Add lifetimebound to attributes for general-purpose usage

e3e7446

Co-authored-by: practicalswift <practicalswift@users.noreply.github.com>

theuni force-pushed the lifetimebound2 branch from ceed5eb to e3e7446 Compare July 8, 2020 17:32

sipa closed this Jul 8, 2020

sipa reopened this Jul 8, 2020

jonatack reviewed Jul 9, 2020

View reviewed changes

src/attributes.h Show resolved Hide resolved

maflcko mentioned this pull request Nov 25, 2020

lifetimebound compile attribute #20493

Closed

14 tasks

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 25, 2020

Merge bitcoin#19387: span: update constructors to match c++20 draft s…

f2c6cfa

…pec and…

kwvg mentioned this pull request Mar 10, 2021

partial #8149 and merge #19845, #19954: Complete the BIP155 implementation and upgrade to TORv3 dashpay/dash#4025

Closed

kwvg added a commit to kwvg/dash that referenced this pull request Mar 10, 2021

Partial bitcoin#19387: Add lifetimebound to attributes for general-pu…

04dff9a

…rpose usage bitcoin@e3e7446

kwvg added a commit to kwvg/dash that referenced this pull request Mar 10, 2021

Partial bitcoin#19387: Add lifetimebound to attributes for general-pu…

278a71c

…rpose usage bitcoin@e3e7446

kwvg added a commit to kwvg/dash that referenced this pull request Mar 10, 2021

Partial bitcoin#19387: (almost) match std::span's constructor behavior

6adf24a

bitcoin@62733fe

kwvg added a commit to kwvg/dash that referenced this pull request Mar 10, 2021

Partial bitcoin#19387: add lifetimebound attribute

5f07202

bitcoin@1d58cc7

This was referenced Mar 10, 2021

partial merge #13697, #18591, #19387, #18468: update constructors to match c++20 draft spec dashpay/dash#4036

Merged

partial merge #13815: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool dashpay/dash#4035

Merged

kwvg added a commit to kwvg/dash that referenced this pull request Mar 10, 2021

Partial bitcoin#19387: Add lifetimebound to attributes for general-pu…

f2d62e7

…rpose usage bitcoin@e3e7446

kwvg added a commit to kwvg/dash that referenced this pull request Mar 12, 2021

Partial bitcoin#19387: Add lifetimebound to attributes for general-pu…

dc62d4d

…rpose usage bitcoin@e3e7446

kwvg added a commit to kwvg/dash that referenced this pull request Mar 19, 2021

Partial bitcoin#19387: Add lifetimebound to attributes for general-pu…

e8782af

…rpose usage bitcoin@e3e7446

kwvg added a commit to kwvg/dash that referenced this pull request Mar 23, 2021

Partial bitcoin#19387: (almost) match std::span's constructor behavior

7feadd8

bitcoin@62733fe

kwvg added a commit to kwvg/dash that referenced this pull request Mar 23, 2021

Partial bitcoin#19387: add lifetimebound attribute

be1929d

bitcoin@1d58cc7

kwvg added a commit to kwvg/dash that referenced this pull request Mar 23, 2021

Merge bitcoin#19387: Add lifetimebound to attributes for general-purp…

17f15e4

…ose usage bitcoin@e3e7446

kwvg added a commit to kwvg/dash that referenced this pull request Mar 23, 2021

Merge bitcoin#19387: (almost) match std::span's constructor behavior

574cfa0

bitcoin@62733fe

kwvg added a commit to kwvg/dash that referenced this pull request Mar 23, 2021

Merge bitcoin#19387: add lifetimebound attribute

51a0633

bitcoin@1d58cc7

kwvg added a commit to kwvg/dash that referenced this pull request Mar 23, 2021

Merge bitcoin#19387: Add lifetimebound to attributes for general-purp…

1be361a

…ose usage bitcoin@e3e7446

kwvg added a commit to kwvg/dash that referenced this pull request Mar 23, 2021

Merge bitcoin#19387: (almost) match std::span's constructor behavior

127f847

bitcoin@62733fe

kwvg added a commit to kwvg/dash that referenced this pull request Mar 23, 2021

Merge bitcoin#19387: add lifetimebound attribute

2a643a3

bitcoin@1d58cc7

kwvg added a commit to kwvg/dash that referenced this pull request Mar 23, 2021

Merge bitcoin#19387: Add lifetimebound to attributes for general-purp…

768ee4e

…ose usage bitcoin@e3e7446

kwvg added a commit to kwvg/dash that referenced this pull request Apr 18, 2021

Merge bitcoin#19387: span: update constructors to match c++20 draft s…

1e79621

…pec and add lifetimebound attribute bitcoin@62733fe bitcoin@1d58cc7 bitcoin@e3e7446

kwvg added a commit to kwvg/dash that referenced this pull request Apr 23, 2021

Merge bitcoin#19387: span: update constructors to match c++20 draft s…

5667698

…pec and add lifetimebound attribute bitcoin@62733fe bitcoin@1d58cc7 bitcoin@e3e7446

UdjinM6 added a commit to dashpay/dash that referenced this pull request Apr 27, 2021

Merge pull request #4036 from kittywhiskers/spans

bf01ed7

partial merge bitcoin#13697, bitcoin#18591, bitcoin#19387, bitcoin#18468: update constructors to match c++20 draft spec

furszy mentioned this pull request Jun 7, 2021

Road to Tor v3 support (BIP155) PIVX-Project/PIVX#2411

Merged

furszy mentioned this pull request Jul 6, 2021

Span sources updates, up-to-date with current upstream. PIVX-Project/PIVX#2470

Merged

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

	#define SPAN_ATTR_LIFETIMEBOUND [[clang::lifetimebound]]
	#define ATTR_LIFETIMEBOUND [[clang::lifetimebound]]

span: update constructors to match c++20 draft spec and add lifetimebound attribute #19387

span: update constructors to match c++20 draft spec and add lifetimebound attribute #19387

Uh oh!

Conversation

theuni commented Jun 26, 2020

Uh oh!

Uh oh!

sipa commented Jun 26, 2020

Uh oh!

practicalswift commented Jun 28, 2020

Uh oh!

jonatack commented Jun 28, 2020

Uh oh!

theuni commented Jun 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theuni commented Jun 29, 2020

Uh oh!

sipa commented Jul 1, 2020

Uh oh!

maflcko commented Jul 1, 2020

Uh oh!

maflcko Jul 1, 2020

Choose a reason for hiding this comment

Uh oh!

theuni Jul 7, 2020

Choose a reason for hiding this comment

Uh oh!

sipa Jul 7, 2020

Choose a reason for hiding this comment

Uh oh!

sipa commented Jul 1, 2020

Uh oh!

sipa commented Jul 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

jonatack commented Jul 4, 2020

Uh oh!

sipa commented Jul 8, 2020

Uh oh!

sipa commented Jul 8, 2020

Uh oh!

jonatack left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

theuni commented Jun 29, 2020 •

edited

Loading

sipa commented Jul 2, 2020 •

edited

Loading

jonatack left a comment •

edited

Loading