Serialization improvements step 4 (undo.h) #18021

sipa · 2020-01-29T19:30:39Z

The next step of changes from #10785.

This one adds:

A meta-formatter for vectors, which serializes the vector elements using another formatter
Switch the undo.h code to the new framework, using the above (where undo entries are serialized as a vector, each of which uses a modified serializer for the UTXOs).

sipa · 2020-01-29T19:31:38Z

@ryanofsky I added another small improvement here that wasn't present in #10785, namely reusing the VectorUsing logic in the vector/prevector serializers themselves (avoiding code duplication).

src/serialize.h

kallewoof · 2020-02-03T06:27:53Z

Code review ACK 24235e5

src/serialize.h

ryanofsky

Code review ACK 24235e5. Left minor suggestions, feel free to ignore

src/serialize.h

ryanofsky · 2020-02-05T19:50:12Z

src/undo.h

-        if (count > MAX_INPUTS_PER_BLOCK) {
-            throw std::ios_base::failure("Too many input undo records");
-        }


In commit "Convert undo.h to new serialization framework" (24235e5)

Note: With this check going away, there doesn't appear to be any limit on the total size of the deserialized vprevout vector. The incremental allocation size is now limited to MAX_VECTOR_ALLOCATE, though.

Yeah, I'm aware. I don't think this is significant. The earlier code needed a sanity limit, and had custom code, so it used a custom limit. The new code is safe by default (even though the limit in practice is much higher).

src/serialize.h

This allows a very compact notation for serialization of vectors whose elements are not serialized using their default encoding.

DrahtBot · 2020-02-07T10:06:55Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#18088 (build: ensure we aren't using GNU extensions by fanquake)
#18087 (Get rid of VARINT default argument by sipa)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

jonatack

Qualified ACK 3c94b00

Code review, built/ran tests/ran bitcoind. I am not yet highly competent wrt C++ templates but this looks like a worthwhile refactoring. Would review again. Some thoughts below, feel free to ignore.

jonatack · 2020-02-07T14:00:26Z

src/serialize.h

+        while (allocated < size) {
+            // For DoS prevention, do not blindly allocate as much as the stream claims to contain.
+            // Instead, allocate in 5MiB batches, so that an attacker actually needs to provide
+            // X MiB of data to make us allocate X+5 Mib.


Lines 632 and 633, so the documentation doesn't go out of date if the value of MAX_VECTOR_ALLOCATE changes, perhaps replace "5 MiB" and "5 Mib" with "MAX_VECTOR_ALLOCATE" (and s/X Mib/X/ as the constant is defined in bytes).

jonatack · 2020-02-07T14:09:39Z

src/serialize.h

+            // Instead, allocate in 5MiB batches, so that an attacker actually needs to provide
+            // X MiB of data to make us allocate X+5 Mib.
+            static_assert(sizeof(typename V::value_type) <= MAX_VECTOR_ALLOCATE, "Vector element size too large");
+            allocated = std::min(size, allocated + MAX_VECTOR_ALLOCATE / sizeof(typename V::value_type));


~~Now that the static assert suggested in #18021 (comment) has been added, possibly worthwhile (or not) to calculate sizeof(typename V::value_type) once and cache it.~~

Noting that the result of sizeof is always nonzero, even if applied to an empty class type, so (normally) no risk of division by zero.

Unless I'm confused, sizeof(..) is determined at compile-time, so no reason to cache it.

Oops yes, static_assert requires a bool constexpr, otherwise a compile-time error is issued.

ryanofsky

Code review ACK 3c94b00. Changes since last review: renaming formatter classes, adding suggested static_assert, and removing temporary in VectorFormatter

laanwj · 2020-02-10T14:47:18Z

code review ACK 3c94b00

3c94b00 Convert undo.h to new serialization framework (Pieter Wuille) 3cd8ab9 Make std::vector and prevector reuse the VectorFormatter logic (Pieter Wuille) abf8624 Add custom vector-element formatter (Pieter Wuille) 37d800b Add a constant for the maximum vector allocation (5 Mbyte) (Pieter Wuille) Pull request description: The next step of changes from #10785. This one adds: * A meta-formatter for vectors, which serializes the vector elements using another formatter * Switch the undo.h code to the new framework, using the above (where undo entries are serialized as a vector, each of which uses a modified serializer for the UTXOs). ACKs for top commit: laanwj: code review ACK 3c94b00 jonatack: Qualified ACK 3c94b00 ryanofsky: Code review ACK 3c94b00. Changes since last review: renaming formatter classes, adding suggested static_assert, and removing temporary in VectorFormatter Tree-SHA512: 44eebf51a303f6adbbc1ca2b9d043e8ae7fd37e06778e026590892f8d09f8253067862a68ba8ca5d733fd2f8e7c84edd255370f5a4b6560259427a65f94632df

3c94b00 Convert undo.h to new serialization framework (Pieter Wuille) 3cd8ab9 Make std::vector and prevector reuse the VectorFormatter logic (Pieter Wuille) abf8624 Add custom vector-element formatter (Pieter Wuille) 37d800b Add a constant for the maximum vector allocation (5 Mbyte) (Pieter Wuille) Pull request description: The next step of changes from bitcoin#10785. This one adds: * A meta-formatter for vectors, which serializes the vector elements using another formatter * Switch the undo.h code to the new framework, using the above (where undo entries are serialized as a vector, each of which uses a modified serializer for the UTXOs). ACKs for top commit: laanwj: code review ACK 3c94b00 jonatack: Qualified ACK 3c94b00 ryanofsky: Code review ACK 3c94b00. Changes since last review: renaming formatter classes, adding suggested static_assert, and removing temporary in VectorFormatter Tree-SHA512: 44eebf51a303f6adbbc1ca2b9d043e8ae7fd37e06778e026590892f8d09f8253067862a68ba8ca5d733fd2f8e7c84edd255370f5a4b6560259427a65f94632df

Summary: This is a partial backport of Core [[bitcoin/bitcoin#18021 | PR18021]] [1/4] Commit bitcoin/bitcoin@37d800b Test Plan: `ninja all check all` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8742

Summary: This allows a very compact notation for serialization of vectors whose elements are not serialized using their default encoding. This is a partial backport of Core [[bitcoin/bitcoin#18021 | PR18021]] [2/4] bitcoin/bitcoin@abf8624 Depends on D8742 Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8743

Summary: This is a partial backport of Core [[bitcoin/bitcoin#18021 | PR18021]] [3/4] bitcoin/bitcoin@3cd8ab9 Depends on D8743 Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8744

Summary: This is a partial backport of Core [[bitcoin/bitcoin#18021 | PR18021]] [4/4] bitcoin/bitcoin@3c94b00 Depends on D8744 There are some important differences in the deserialization, due to differences in how the `Coin` object is implemented (coins.h) Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Subscribers: majcosta Differential Revision: https://reviews.bitcoinabc.org/D8745

…on (5 Mbyte) 37d800b

bitcoin@abf8624

…rFormatter logic bitcoin@3cd8ab9

bitcoin@3c94b00

bitcoin@3c94b00 Partial bitcoin#18021: Make std::vector and prevector reuse the VectorFormatter logic bitcoin@3cd8ab9 Partial bitcoin#18021: Add custom vector-element formatter bitcoin@abf8624 Partial bitcoin#18021: Add a constant for the maximum vector allocation (5 Mbyte) 37d800b

merge bitcoin#12752, bitcoin#10785, bitcoin#17896, bitcoin#17957, bitcoin#18021, bitcoin#18112: serialization improvements

bitcoin@3c94b00 Partial bitcoin#18021: Make std::vector and prevector reuse the VectorFormatter logic bitcoin@3cd8ab9 Partial bitcoin#18021: Add custom vector-element formatter bitcoin@abf8624 Partial bitcoin#18021: Add a constant for the maximum vector allocation (5 Mbyte) 37d800b

bd4b846 Remove old serialization primitives (Pieter Wuille) 060d62b Convert the last, non-trivial, serialization functions to the new form (furszy) 8c74c09 Convert LimitedString to formatter (Pieter Wuille) f021897 Fix CDiskBlockIndex serialization of dummy fields for old DB versions (random-zebra) 1ee0cb2 Convert CDiskBlockIndex to new serialization. (furszy) 221bf49 Convert wallet to new serialization (furszy) cf06950 Convert to new serialization (step 3) (furszy) dc0fc95 Remove old MESS_VER_STRMESS message version try-catch. (furszy) 35fca11 Convert Qt to new serialization (Pieter Wuille) 3f7826e Add comments to CustomUintFormatter (Pieter Wuille) eccd473 Convert to new serialization (step 2). Focused on object's serializations that doesn't require an special treatment. (furszy) 0f15784 Convert everything except wallet/qt to new serialization (step 1) (Pieter Wuille) 3d3ee64 Convert merkleblock to new serialization (Pieter Wuille) 13577fb Add SER_READ and SER_WRITE for read/write-dependent statements (Russell Yanofsky) 7344c1a Extend CustomUintFormatter to support enums (Russell Yanofsky) c4d6228 Merge BigEndian functionality into CustomUintFormatter (Pieter Wuille) 3765d6c Add static_asserts to ser_X_to_Y() methods (Samer Afach) 806213a Fix a violation of C++ standard rules that unions cannot be switched. (Samer Afach) d6380c4 Add CustomUintFormatter (Pieter Wuille) fd29a50 Make VectorFormatter support stateful formatters (Russell Yanofsky) 4e2afad Convert CCompactSize to proper formatter (Pieter Wuille) bb99030 Get rid of VARINT default argument (Pieter Wuille) e107a0c Convert undo.h to new serialization framework (Pieter Wuille) a926ba3 Make std::vector and prevector reuse the VectorFormatter logic (Pieter Wuille) 1dfddce Add custom vector-element formatter (Pieter Wuille) df4e1ba Add a constant for the maximum vector allocation (5 Mbyte) (Pieter Wuille) c2fdeaf Convert compression.h to new serialization framework (Pieter Wuille) aa35991 Add FORMATTER_METHODS, similar to SERIALIZE_METHODS, but for formatters (Pieter Wuille) 3e38199 Move compressor utility functions out of class (Pieter Wuille) 7376a95 Convert chain to new serialization (Pieter Wuille) bbfc55c Convert VARINT to the formatter/Using approach (Pieter Wuille) 39c58a1 Add a generic approach for (de)serialization of objects using code in other classes (Pieter Wuille) ace3895 Convert addrdb/addrman to new serialization (Pieter Wuille) 6bb135e Introduce new serialization macros without casts (Pieter Wuille) ace7d14 Drop minor GetSerializeSize template (Ben Woosley) f05e692 Drop unused GetType() from CSizeComputer (furszy) 5c36b3d Introduce BigEndian wrapper and use it for netaddress ports (Pieter Wuille) fb3c646 Migrate last FLATDATA calls to use Span. (furszy) 1ef2d90 Support serializing Span<unsigned char> and use that instead of FLATDATA (Pieter Wuille) 8fef544 Add Slice: a (pointer, size) array view that acts like a container (Pieter Wuille) Pull request description: Decoupled from #2411, built on top of #2359. Focused on creating the Span class and updating the serialization framework and every object using it up to latest upstream structure (3-4 years ahead of what we currently are in master). We will be up-to-date with them in the area after finishing with #2411 entirely (there are few more updates to the serialization code that comes down #2411 commits line that cannot cherry-pick here). Adapted the following PRs: * bitcoin#12886. * bitcoin#12916. * bitcoin#13558. * bitcoin#17850. * bitcoin#17896. * bitcoin#12752. * bitcoin#17957. * bitcoin#18021. * bitcoin#18087. * bitcoin#18112 (only from 353f376 that we don't support). * bitcoin#18167. * bitcoin#18317. * bitcoin#19032. ACKs for top commit: random-zebra: ACK bd4b846 Fuzzbawls: ACK bd4b846 Tree-SHA512: fe1b31d0976dff97bfeed0f9efeeb4c6c161277529880ede990c9b3fb0ea680f25b4be01b739f6bf7eeca79fa7687c9c2146c403c96e86bc6b052c6dd88e6930

ecde04a [Consensus] Bump Active Protocol version to 70923 for v5.3 (random-zebra) b63e4f5 Consensus: Add v5.3 enforcement height for testnet. (furszy) f44be94 Only relay IPv4, IPv6, Tor addresses (Pieter Wuille) 015298c fix: tor: Call event_base_loopbreak from the event's callback (furszy) 34ff7a8 Consensus: Add mnb ADDRv2 guard. (furszy) b4515dc GUI: Present v3 onion addresses properly in MNs list. (furszy) 337d43d tests: don't export in6addr_loopback (Vasil Dimov) 2cde8e0 GUI: Do not show the tor v3 onion address in the topbar. (furszy) 0b5f406 Doc: update tor.md with latest upstream information. (furszy) 89df7f2 addrman: ensure old versions don't parse peers.dat (Vasil Dimov) bb90c5c test: add getnetworkinfo network name regression tests (Jon Atack) d8e01b5 rpc: update GetNetworksInfo() to not return unsupported networks (Jon Atack) 57fc7b0 net: update GetNetworkName() with all enum Network cases (Jon Atack) 647d60b tests: Modify rpc_bind to conform to bitcoin#14532 behaviour. (Carl Dong) d4d6729 Allow running rpc_bind.py --nonloopback test without IPv6 (Kristaps Kaupe) 4a034d8 test: Add rpc_bind test to default-run tests (Wladimir J. van der Laan) 61a08af [tests] bind functional test nodes to 127.0.0.1 Prevents OSX firewall (Sjors Provoost) 6a4f1e0 test: Add basic addr relay test (furszy) 78aa61c net: Make addr relay mockable (furszy) ba954ca Send and require SENDADDRV2 before VERACK (Pieter Wuille) 61c2ed4 Bump net protocol version + don't send 'sendaddrv2' to pre-70923 software (furszy) ccd508a tor: make a TORv3 hidden service instead of TORv2 (Vasil Dimov) 6da9a14 net: advertise support for ADDRv2 via new message (furszy) e58d5d0 Migrate to test_large_inv() to Misbehaving logging. (furszy) d496b64 [QA] fix mininode CAddress ser/deser (Jonas Schnelli) cec9567 net: CAddress & CAddrMan: (un)serialize as ADDRv2 Change the serialization of `CAddrMan` to serialize its addresses in ADDRv2/BIP155 format by default. Introduce a new `CAddrMan` format version (3). (furszy) b8c1dda streams update: get rid of nType and nVersion. (furszy) 3eaa273 Support bypassing range check in ReadCompactSize (Pieter Wuille) a237ba4 net: recognize TORv3/I2P/CJDNS networks (Vasil Dimov) 8e50853 util: make EncodeBase32 consume Spans (Sebastian Falbesoner) 1f67e30 net: CNetAddr: add support to (un)serialize as ADDRv2 (Vasil Dimov) 2455420 test: move HasReason so it can be reused (furszy) d41adb4 util: move HasPrefix() so it can be reused (Vasil Dimov) f6f86af Unroll Keccak-f implementation (Pieter Wuille) 45222e6 Implement keccak-f[1600] and SHA3-256 (Pieter Wuille) 08ad06d net: change CNetAddr::ip to have flexible size (furszy) 3337219 net: improve encapsulation of CNetAddr. (furszy) 910d5c4 test: Do not instantiate CAddrDB for static call (Hennadii Stepanov) 6b607ef Drop IsLimited in favor of IsReachable (Ben Woosley) a40711b IsReachable is the inverse of IsLimited (DRY). Includes unit tests (marcaiaf) 8839828 net: don't accept non-left-contiguous netmasks (Vasil Dimov) 5d7f864 rpcbind: Warn about exposing RPC to untrusted networks (Luke Dashjr) 2a6abd8 CNetAddr: Add IsBindAny method to check for INADDR_ANY (Luke Dashjr) 4fdfa45 net: Always default rpcbind to localhost, never "all interfaces" (Luke Dashjr) 31064a8 net: Minor accumulated cleanups (furszy) 9f9c871 tests: Avoid using C-style NUL-terminated strings as arguments (practicalswift) f6c52a3 tests: Add tests to make sure lookup methods fail on std::string parameters with embedded NUL characters (practicalswift) a751b9b net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface (furszy) f30869d test: add IsRFC2544 tests (Mark Tyneway) ed5abe1 Net: Proper CService deserialization + GetIn6Addr return false if addr isn't an IPv6 addr (furszy) 86d73fb net: save the network type explicitly in CNetAddr (Vasil Dimov) ad57dfc net: document `enum Network` (Vasil Dimov) cb160de netaddress: Update CNetAddr for ORCHIDv2 (Carl Dong) c3c04e4 net: Better misbehaving logging (furszy) 3660487 net: Use C++11 member initialization in protocol (Marco) 082baa3 refactor: Drop unused CBufferedFile::Seek() (Hennadii Stepanov) e2d776a util: CBufferedFile fixes (Larry Ruane) 6921f42 streams: backport OverrideStream class (furszy) Pull request description: Conjunction of a large number of back ports, updates and refactorings that made with the final goal of implementing v3 Onion addresses support (BIP155 https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki) before the tor v2 addresses EOL, scheduled, by the Tor project, for (1) July 15th: v2 addr support removal from the code base, and (2) October 15th: v2 addr network disable, where **every peer in our network running under Tor will loose the connection and drop the network**. As BIP155 describes, this is introducing a new P2P message to gossip longer node addresses over the P2P network. This is required to support new-generation Onion addresses, I2P, and potentially other networks that have longer endpoint addresses than fit in the 128 bits of the current addr message. In order to achieve the end goal, had to: 1. Create Span class and push it up to latest Bitcoin implementation. 2. Update the whole serialization framework and every object using it up to latest Bitcoin implementation (3-4 years ahead of what we currently are in master). 3. Update the address manager implementing ASN-based bucketing of the network nodes. 4. Update and refactor the netAddress and address manager tests to latest Bitcoin implementation (4 years ahead of what we currently are in master). 5. Several util string, vector, encodings, parsing, hashing backports and more.. Important note: This PR it is not meant to be merged as a standalone PR, will decouple smaller ones moving on. Adding on each sub-PR its own description isolated from this big monster. Second note: This is still a **work-in-progress**, not ready for testing yet. I'm probably missing to mention few PRs that have already adapted to our sources. Just making it public so can decouple the changes, we can start merging them and i can continue working a bit more confortable (rebase a +170 commits separate branch is not fun..). ### List of back ported and adapted PRs: Span and Serialization: ---------------- * bitcoin#12886. * bitcoin#12916. * bitcoin#13558. * bitcoin#13697. (Only Span's commit 29943a9) * bitcoin#17850. * bitcoin#17896. * bitcoin#12752. * bitcoin#16577. * bitcoin#16670. (without faebf62) * bitcoin#17957. * bitcoin#18021. * bitcoin#18087. * bitcoin#18112 (only from 353f376 that we don't support). * bitcoin#18167. * bitcoin#18317. * bitcoin#18591 (only Span's commit 0fbde48) * bitcoin#18468. * bitcoin#19020. * bitcoin#19032. * bitcoin#19367. * bitcoin#19387. Net, NetAddress and AddrMan: ---------------- * bitcoin#7932. * bitcoin#10756. * bitcoin#10765. * bitcoin#12218. * bitcoin#12855. * bitcoin#13532. * bitcoin#13575. * bitcoin#13815. * bitcoin#14532. * bitcoin#15051. * bitcoin#15138. * bitcoin#15689. * bitcoin#16702. * bitcoin#17243. * bitcoin#17345. * bitcoin#17754. * bitcoin#17758. * bitcoin#17812. * bitcoin#18023. * bitcoin#18454. * bitcoin#18512. * bitcoin#19314. * bitcoin#19687 Keys and Addresses encoding: ---------------- * bitcoin#11372. * bitcoin#17511. * bitcoin#17721. Util: ---------------- * bitcoin#9140. * bitcoin#16577. * bitcoin#16889. * bitcoin#19593. Bench: ---------------- * bitcoin#16299. BIP155: ---------------- * bitcoin#19351. * bitcoin#19360. * bitcoin#19534. * bitcoin#19628. * bitcoin#19841. * bitcoin#19845. * bitcoin#19954. * bitcoin#19991 (pending). * bitcoin#19845. * bitcoin#20000 (pending). * bitcoin#20120. * bitcoin#20284. * bitcoin#20564. * bitcoin#21157 (pending). * bitcoin#21564 (pending). * Fully removed v2 onion addr support. * Add hardcoded seeds. * Add release-notes, changes to files.md and every needed documentation. I'm currently working on the PRs marked as "pending", this isn't over, but I'm pretty pretty close :). What a long road.. ACKs for top commit: random-zebra: utACK ecde04a Fuzzbawls: ACK ecde04a Tree-SHA512: 82c95fbda76fce63f96d8a9af7fa9a89cb1e1b302b7891e27118a6103af0be23606bf202c7332fa61908205e6b6351764e2ec23d753f1e2484028f57c2e8b51a

Empact reviewed Jan 29, 2020

View reviewed changes

src/serialize.h Outdated Show resolved Hide resolved

fanquake requested a review from jamesob January 29, 2020 23:38

Add a constant for the maximum vector allocation (5 Mbyte)

37d800b

sipa force-pushed the 202001_noncastserial_4 branch from 416300b to 24235e5 Compare January 30, 2020 04:57

laanwj reviewed Feb 5, 2020

View reviewed changes

src/serialize.h Outdated Show resolved Hide resolved

laanwj reviewed Feb 5, 2020

View reviewed changes

src/serialize.h Show resolved Hide resolved

ryanofsky approved these changes Feb 5, 2020

View reviewed changes

sipa added 3 commits February 6, 2020 18:58

Add custom vector-element formatter

abf8624

This allows a very compact notation for serialization of vectors whose elements are not serialized using their default encoding.

Make std::vector and prevector reuse the VectorFormatter logic

3cd8ab9

Convert undo.h to new serialization framework

3c94b00

sipa force-pushed the 202001_noncastserial_4 branch from 24235e5 to 3c94b00 Compare February 7, 2020 03:08

jonatack reviewed Feb 7, 2020

View reviewed changes

ryanofsky approved these changes Feb 7, 2020

View reviewed changes

laanwj merged commit 3c94b00 into bitcoin:master Feb 10, 2020

sipa mentioned this pull request Feb 15, 2020

Serialization improvements #10785

Closed

MarkLTZ mentioned this pull request Apr 4, 2020

Bitcoin PR tracking litecoinz-core/litecoinz#14

Closed

kwvg mentioned this pull request Mar 8, 2021

partial #8149 and merge #19845, #19954: Complete the BIP155 implementation and upgrade to TORv3 dashpay/dash#4025

Closed

kwvg added a commit to kwvg/dash that referenced this pull request Mar 10, 2021

Partial bitcoin#18021: Add a constant for the maximum vector allocati…

98b18b8

…on (5 Mbyte) 37d800b

kwvg added a commit to kwvg/dash that referenced this pull request Mar 10, 2021

Partial bitcoin#18021: Add custom vector-element formatter

aeb9240

bitcoin@abf8624

kwvg added a commit to kwvg/dash that referenced this pull request Mar 10, 2021

Partial bitcoin#18021: Make std::vector and prevector reuse the Vecto…

603db46

…rFormatter logic bitcoin@3cd8ab9

kwvg mentioned this pull request Mar 10, 2021

merge #12752, #10785, #17896, #17957, #18021, #18112: serialization improvements dashpay/dash#4037

Merged

kwvg added a commit to kwvg/dash that referenced this pull request Mar 16, 2021

Merge bitcoin#18021: Convert undo.h to new serialization framework

5bd678d

bitcoin@3c94b00

kwvg added a commit to kwvg/dash that referenced this pull request Mar 16, 2021

Merge bitcoin#18021: Convert undo.h to new serialization framework

ef07309

bitcoin@3c94b00

UdjinM6 added a commit to dashpay/dash that referenced this pull request May 14, 2021

Merge pull request #4037 from kittywhiskers/serialize

20b7170

merge bitcoin#12752, bitcoin#10785, bitcoin#17896, bitcoin#17957, bitcoin#18021, bitcoin#18112: serialization improvements

This was referenced Jun 7, 2021

Road to Tor v3 support (BIP155) PIVX-Project/PIVX#2411

Merged

[Backport] Serialization framework updates PIVX-Project/PIVX#2412

Merged

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

Serialization improvements step 4 (undo.h) #18021

Serialization improvements step 4 (undo.h) #18021

Uh oh!

Conversation

sipa commented Jan 29, 2020

Uh oh!

sipa commented Jan 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kallewoof commented Feb 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ryanofsky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ryanofsky Feb 5, 2020

Choose a reason for hiding this comment

Uh oh!

sipa Feb 7, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DrahtBot commented Feb 7, 2020

Conflicts

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

jonatack Feb 7, 2020

Choose a reason for hiding this comment

Uh oh!

jonatack Feb 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonatack Feb 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kallewoof Feb 7, 2020

Choose a reason for hiding this comment

Uh oh!

jonatack Feb 7, 2020

Choose a reason for hiding this comment

Uh oh!

ryanofsky left a comment

Choose a reason for hiding this comment

Uh oh!

laanwj commented Feb 10, 2020

Uh oh!

Uh oh!

sipa commented Jan 29, 2020 •

edited

Loading

kallewoof commented Feb 3, 2020 •

edited

Loading

jonatack Feb 7, 2020 •

edited

Loading

jonatack Feb 7, 2020 •

edited

Loading