Send ActivityReset flag to the worker in heartbeat response #7677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Would love to see functional test similar to
temporal/tests/activity_test.go
Line 1171 in 1afbdd2
gow
approved these changes
May 1, 2025
ychebotarev
added a commit
to temporalio/api
that referenced
this pull request
May 2, 2025
<!-- Describe what has changed in this PR --> **What changed?** Add two new flags to activity heartbeat response: * reset_requested // indicates that reset happen while activity is still running * reset_heartbeat //indicates that user asked to also reset heartbeats <!-- Tell your future self why have you made these changes --> **Why?** Product request. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** No Corresponding Server PR: temporalio/temporal#7677
temporal-cicd bot
pushed a commit
to temporalio/api-go
that referenced
this pull request
May 2, 2025
<!-- Describe what has changed in this PR --> **What changed?** Add two new flags to activity heartbeat response: * reset_requested // indicates that reset happen while activity is still running * reset_heartbeat //indicates that user asked to also reset heartbeats <!-- Tell your future self why have you made these changes --> **Why?** Product request. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** No Corresponding Server PR: temporalio/temporal#7677
1f2706b to
c97ffe9
Compare
fdd5c82 to
4a26fc1
Compare
josesa
added a commit
to josesa/temporal
that referenced
this pull request
May 12, 2025
* main: (22 commits) Add host health metrics gauge (temporalio#7728) add rule expiration check (temporalio#7749) Add activity options to the pending activity info (temporalio#7727) Enable DLQ V2 for replication (temporalio#7746) chore: be smarter about when to use Stringer vs String (temporalio#7743) versioning entity workflows: enabling auto-restart pt1 (temporalio#7715) Refactor code generators (temporalio#7734) allow passive to generate replication tasks (temporalio#7713) Validate links in completion callbacks (temporalio#7726) CHASM: Engine Update/ReadComponent implementation (temporalio#7696) Enable transition history in dev env and tests (temporalio#7737) chore: Add Stringer tags (temporalio#7738) Add internal pod health check to DeepHealthCheck (temporalio#7709) Rename internal CHASM task processing interface (temporalio#7730) [Frontend] Log slow gRPC requests (temporalio#7718) Remove cap for dynamic config callback pool (temporalio#7723) Refactor updateworkflowoptions package (temporalio#7725) Remove a bunch of redundant utf-8 validation (temporalio#7720) [CHASM] Pure task processing - GetPureTasks, ExecutePureTasks (temporalio#7701) Send ActivityReset flag to the worker in heartbeat response (temporalio#7677) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Corresponding API PR: temporalio/api#578
Why?
To notify the workers/SDK that reset happens.
How did you test it?
Running existing tests.
Note: replication in the next PR