Refactor code generators #7734
Merged
Refactor code generators #7734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
commented
May 8, 2025
| @@ -0,0 +1,167 @@ | |||
| {{- /*gotype: go.temporal.io/server/cmd/tools/gendynamicconfig.dynamicConfigData*/ -}} | |||
There was a problem hiding this comment.
This line enables intellisense in GoLand.
There was a problem hiding this comment.
ooh, very cool. I'm jealous of that, the template has been frustrating to edit
alexshtin
commented
May 8, 2025
| func generateFrontendOrAdminClient(w io.Writer, service service) { | ||
| writeTemplatedCode(w, service, ` | ||
| func generateFrontendOrAdminClient(w io.Writer, service service) error { | ||
| writeTemplatedCode(w, service, `// Code generated by cmd/tools/genrpcwrappers. DO NOT EDIT. |
There was a problem hiding this comment.
All templates here also can be extracted to separate files, but it is too much work. Maybe later.
dnr
approved these changes
May 9, 2025
Comment on lines
+25
to
+31
| {{end -}} | ||
| } | ||
| {{- end}} | ||
| {{- else}} | ||
| return nil | ||
| {{- end -}} | ||
| {{- end}} |
There was a problem hiding this comment.
I hope it didn't take that long to get all the {{- and -}} correct 😳
There was a problem hiding this comment.
Well, I mostly just copied it from what you had. But yes, spent some time on it :-)
| {{ if $T.IsGeneric -}} | ||
| type {{$P.Name}}TypedSetting[T any] setting[T, func({{$P.GoArgs}})] | ||
|
|
||
| // New{{$P.Name}}TypedSetting creates a setting that uses mapstructure to handle complex structured |
There was a problem hiding this comment.
aw, this is going to conflict with 7052 that's almost ready. I'll handle the conflicts
| @@ -0,0 +1,167 @@ | |||
| {{- /*gotype: go.temporal.io/server/cmd/tools/gendynamicconfig.dynamicConfigData*/ -}} | |||
There was a problem hiding this comment.
ooh, very cool. I'm jealous of that, the template has been frustrating to edit
63c318e to
e8c8dad
Compare
josesa
added a commit
to josesa/temporal
that referenced
this pull request
May 12, 2025
* main: (22 commits) Add host health metrics gauge (temporalio#7728) add rule expiration check (temporalio#7749) Add activity options to the pending activity info (temporalio#7727) Enable DLQ V2 for replication (temporalio#7746) chore: be smarter about when to use Stringer vs String (temporalio#7743) versioning entity workflows: enabling auto-restart pt1 (temporalio#7715) Refactor code generators (temporalio#7734) allow passive to generate replication tasks (temporalio#7713) Validate links in completion callbacks (temporalio#7726) CHASM: Engine Update/ReadComponent implementation (temporalio#7696) Enable transition history in dev env and tests (temporalio#7737) chore: Add Stringer tags (temporalio#7738) Add internal pod health check to DeepHealthCheck (temporalio#7709) Rename internal CHASM task processing interface (temporalio#7730) [Frontend] Log slow gRPC requests (temporalio#7718) Remove cap for dynamic config callback pool (temporalio#7723) Refactor updateworkflowoptions package (temporalio#7725) Remove a bunch of redundant utf-8 validation (temporalio#7720) [CHASM] Pure task processing - GetPureTasks, ExecutePureTasks (temporalio#7701) Send ActivityReset flag to the worker in heartbeat response (temporalio#7677) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Refactor code generators:
codegenpackage.All generated files are almost unchanged (removed leading empty line).
Why?
Better maintainability.
How did you test it?