Add reset info to the activity heartbeat response #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Apr 25, 2025
|
|
||
| // Will be set to true if the activity was reset. | ||
| // Applyes only to the current run. | ||
| bool activity_reset = 3; |
There was a problem hiding this comment.
Can I get confirmation that we want SDKs to interrupt running activities when this is true, same as we do for paused or cancel requested?
There was a problem hiding this comment.
My goal is to provide all the information.
I think we need to decide it separately.
There was a problem hiding this comment.
Would rather decide how we want SDK to react before merging this API (we obviously don't provide all information on heartbeat, we only provide what callers need, there is a ton of stuff about an activity we leave off).
In this case I suspect we will want to interrupt the activity.
96fd95e to
dec9a5e
Compare
cretz
approved these changes
Apr 29, 2025
Sushisource
approved these changes
Apr 29, 2025
gow
approved these changes
Apr 29, 2025
ychebotarev
added a commit
to temporalio/temporal
that referenced
this pull request
May 7, 2025
## What changed? <!-- Describe what has changed in this PR --> * Add "reset_activity" and "reset_heartbeat" flags to the activity info * send "reset_requested" flag to the worker in response to heartbeat request * if "reset_heartbeat" flag was set - reset heartbeats for new attempt only * remove "reset_activity" and "reset_heartbeat" flags for the new attempt Corresponding API PR: temporalio/api#578 ## Why? <!-- Tell your future self why have you made these changes --> To notify the workers/SDK that reset happens. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> Running existing tests. Note: replication in the next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add two new flags to activity heartbeat response:
Why?
Product request.
Breaking changes
No
Corresponding Server PR: temporalio/temporal#7677