Enable transition history in dev env and tests #7737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwduan
approved these changes
May 8, 2025
hai719
approved these changes
May 8, 2025
yycptt
commented
May 8, 2025
Comment on lines
180
to
185
| // VersionedTransition is for a specific run. After reset, the TransitionCount will | ||
| // start from 1 again. Reset the TransitionCount to 0 here to fallback to old ref | ||
| // validation logic. | ||
| ref.StateMachineRef.MutableStateVersionedTransition.TransitionCount = 0 | ||
| ref.StateMachineRef.MachineInitialVersionedTransition.TransitionCount = 0 | ||
| ref.StateMachineRef.MachineLastUpdateVersionedTransition.TransitionCount = 0 |
There was a problem hiding this comment.
Thanks!
Was this caught with test coverage?
Also something to consider finding a good abstraction for in CHASM.
There was a problem hiding this comment.
yup, TestNexusOperationAsyncCompletionAfterReset starts to fail after I enabled TransitionHistory.
Yeah I will need to think about how to handle it in CHASM world.
ychebotarev
pushed a commit
that referenced
this pull request
May 8, 2025
## What changed? - Enable transition history in dev env and tests - Reset state transition count when reporting nexus operation completion to a reset run ## Why? - Exercise transition history and state-based replication path more often - Make chasm development and testing easier since it relies on transition history ## How did you test it? - [x] built - [ ] run locally and tested manually - [x] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s)
josesa
added a commit
to josesa/temporal
that referenced
this pull request
May 12, 2025
* main: (22 commits) Add host health metrics gauge (temporalio#7728) add rule expiration check (temporalio#7749) Add activity options to the pending activity info (temporalio#7727) Enable DLQ V2 for replication (temporalio#7746) chore: be smarter about when to use Stringer vs String (temporalio#7743) versioning entity workflows: enabling auto-restart pt1 (temporalio#7715) Refactor code generators (temporalio#7734) allow passive to generate replication tasks (temporalio#7713) Validate links in completion callbacks (temporalio#7726) CHASM: Engine Update/ReadComponent implementation (temporalio#7696) Enable transition history in dev env and tests (temporalio#7737) chore: Add Stringer tags (temporalio#7738) Add internal pod health check to DeepHealthCheck (temporalio#7709) Rename internal CHASM task processing interface (temporalio#7730) [Frontend] Log slow gRPC requests (temporalio#7718) Remove cap for dynamic config callback pool (temporalio#7723) Refactor updateworkflowoptions package (temporalio#7725) Remove a bunch of redundant utf-8 validation (temporalio#7720) [CHASM] Pure task processing - GetPureTasks, ExecutePureTasks (temporalio#7701) Send ActivityReset flag to the worker in heartbeat response (temporalio#7677) ...
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Enable transition history in dev env and tests
Why?
How did you test it?