Skip to content

Reland Reland engine display features #93117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 5, 2021
Merged

Reland Reland engine display features #93117

merged 3 commits into from
Nov 5, 2021

Conversation

andreidiaconu
Copy link
Contributor

@andreidiaconu andreidiaconu commented Nov 5, 2021 •
edited
Loading

Previous reland was failing because the gallery repo also needed to be updated with compileSdkVersion 31 and new gradle lockfiles. There is a separate PR for this: flutter/gallery#557

This reverts #93098 (commit 7779ad3).

List which issues are fixed by this PR:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation engine flutter/engine repository. See also e: labels. f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 5, 2021
@google-cla google-cla bot added the cla: yes label Nov 5, 2021
@andreidiaconu
Copy link
Contributor Author

The gallery compiles on my machine without adding multidex support. This was needed in the flutter_gallery copy that this repo contains, but the gallery repo seems to be a lot different at this point. The tests that failed on previous reland (referenced in #93098) should pass once flutter/gallery#557 is merged.

@zanderso @blasten Please have a look. Thank you.

@andreidiaconu andreidiaconu mentioned this pull request Nov 5, 2021
Merged
8 tasks
@andreidiaconu
Copy link
Contributor Author

flutter/gallery#557 was merged. The only failing check is luci-flutter and this PR should help make the tree green again.

@zanderso
Copy link
Member

zanderso commented Nov 5, 2021

The tests that are now broken on the tree following the revert of the previous attempt to land this change should be made green before attempting to reland.

@andreidiaconu
Copy link
Contributor Author

The tree was red before that merge and revert but I agree with making the tree green a priority. Opening a separate PR with just that fix.

@andreidiaconu
Copy link
Contributor Author

andreidiaconu commented Nov 5, 2021 •
edited
Loading

Separate PR with just the failing test fix, which should make the tree green again: #93136

@andreidiaconu
Copy link
Contributor Author

Reverted one of the commits 6b17477, as it is no longer needed, due to #93148

@zanderso zanderso requested a review from blasten November 5, 2021 19:16
blasten
blasten approved these changes Nov 5, 2021
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten merged commit 9038fac into flutter:master Nov 5, 2021
zanderso added a commit that referenced this pull request Nov 7, 2021
@zanderso
Revert "Reland: display features (#93117)"
381cbb0 
This reverts commit 9038fac.
This was referenced Nov 7, 2021
Closed
Merged
zanderso added a commit that referenced this pull request Nov 7, 2021
@zanderso
Revert "Reland: display features (#93117)" (#93204)
2468f31 
This reverts commit 9038fac.
andreidiaconu added a commit to andreidiaconu/flutter that referenced this pull request Nov 8, 2021
@andreidiaconu
Revert "Revert "Reland: display features (flutter#93117)" (flutter#93204
13ca08c 
)"

This reverts commit 2468f31.
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
@andreidiaconu @WizzXu
Reland: display features (flutter#93117)
baa0861
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
@zanderso @WizzXu
Revert "Reland: display features (flutter#93117)" (flutter#93204)
8d090d6 
This reverts commit 9038fac.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@blasten blasten blasten approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos engine flutter/engine repository. See also e: labels. f: integration_test The flutter/packages/integration_test plugin tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreidiaconu @zanderso @blasten