Skip to content

Conversation

blasten
Copy link

@blasten blasten commented Nov 5, 2021

Fixes #93133

@blasten blasten requested review from GaryQian and zanderso November 5, 2021 18:15
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 5, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Nov 5, 2021
@blasten blasten merged commit 15d0a8b into flutter:master Nov 5, 2021
@blasten blasten deleted the pin_dependencies branch November 5, 2021 18:17
@GaryQian
Copy link
Contributor

GaryQian commented Nov 5, 2021

Cc @camsim99

godofredoc added a commit that referenced this pull request Nov 12, 2021
…93448)

* Added SharedAppData to the widgets library (#93175)

* 'add branch flutter-2.8-candidate.3 to enabled_branches in .ci.yaml'

* 'Update Engine revision to 09f1520 for beta release 2.8.0-3.1.pre'

* Pin to specific plugin version in multidex test (#93148)

Co-authored-by: Hans Muller <hans.muller@gmail.com>
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
ryanawhelan pushed a commit to ryanawhelan/flutter that referenced this pull request Jan 13, 2022
…lutter#93448)

* Added SharedAppData to the widgets library (flutter#93175)

* 'add branch flutter-2.8-candidate.3 to enabled_branches in .ci.yaml'

* 'Update Engine revision to 09f1520 for beta release 2.8.0-3.1.pre'

* Pin to specific plugin version in multidex test (flutter#93148)

Co-authored-by: Hans Muller <hans.muller@gmail.com>
Co-authored-by: Emmanuel Garcia <egarciad@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test/integration.shard/multidex_build_test.dart failing on CI
3 participants