Skip to content

Revert "Reland engine display features" #93098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2021
Merged

Revert "Reland engine display features" #93098

merged 1 commit into from
Nov 5, 2021

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Nov 5, 2021

@zanderso zanderso requested a review from blasten November 5, 2021 06:04
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation engine flutter/engine repository. See also e: labels. f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Nov 5, 2021
@google-cla google-cla bot added the cla: yes label Nov 5, 2021
@zanderso zanderso merged commit 7779ad3 into master Nov 5, 2021
@zanderso zanderso deleted the revert-89511-engine_display_features branch November 5, 2021 06:05
@andreidiaconu
Copy link
Contributor

Looks like the gallery repo also needs to update lockfiles, as those tests use the repo for testing. From what I can tell, these tests are not part of the checks that show up on GH https://github.com/flutter/flutter/pull/89511/checks

Am I missing something? I will open a separate PR on the gallery repo to update lockfiles and trey to reland everything again

@andreidiaconu andreidiaconu mentioned this pull request Nov 5, 2021
Merged
8 tasks
@andreidiaconu
Copy link
Contributor

Opened flutter/gallery#557 which should make the gallery compatible.

andreidiaconu added a commit to andreidiaconu/flutter that referenced this pull request Nov 5, 2021
@andreidiaconu
Revert "Revert "Reland engine display features (flutter#89511)" (flut…
39af3a6 
…ter#93098)"

This reverts commit 7779ad3.
@andreidiaconu andreidiaconu mentioned this pull request Nov 5, 2021
Merged
8 tasks
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
@zanderso @WizzXu
Revert "Reland engine display features (flutter#89511)" (flutter#93098)
cdd2453 
This reverts commit 058dfd4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blasten blasten Awaiting requested review from blasten

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos engine flutter/engine repository. See also e: labels. f: integration_test The flutter/packages/integration_test plugin tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanderso @andreidiaconu