Update minSdkVersion to 19 in multidex_project #93136
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@zanderso This fix addresses: |
|
I would like to better understand how the change to firesotre happened? Is that something under our control? /cc @blasten |
|
Related #93133 |
|
@zanderso out-of-band errors like this can occur when a plugin bumps a Gradle dependency (firebase/flutterfire#7298), and the version resolution of this test's pubspec.yml isn't deterministic. |
| @@ -179,7 +179,7 @@ class MultidexProject extends Project { | |||
| defaultConfig { | |||
| // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html). | |||
| applicationId "com.example.multidextest2" | |||
| minSdkVersion 16 | |||
There was a problem hiding this comment.
cc @GaryQian
Instead of changing the minSdkVersion, what about changing the constraint of the plugins?
cloud_firestore: 2.5.3
firebase_core: 1.6.0
There was a problem hiding this comment.
Pinning to known good dependency versions sounds like the safer solution to me.
|
#93148 will address this issue |
This should make the tree green again. One of the tests was failing because an external dependency (firestore) of one of the tests now requires a higher minSdk (19 instead of 16)
Fixes issue:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.