Skip to content

Conversation

domcross
Copy link
Owner

Description

(Description of what the PR does, such as fixes # {issue number})

How to test

(Description of how to validate or test this PR)

Contributor license agreement signed?

CLA [ ] (Whether you have signed a CLA - Contributor Licensing Agreement

Tanel.Alumae and others added 30 commits May 24, 2019 23:18
Fixes overriding settings from listener config
- Workaround, ensure asyncio event loop is launched on each thread.
Add more time idioms (half past, etc.)
Update adapt so there are no version conflicts for six
The clean will remove any files and directories installed onto the system by the
dev setup including pairing, skills and log files.
The dependency was previously added to try to suppress the SSL version
warning on the mark-1. This has been resolved via upgrading the mark-1
so the requirement is not of any importance right now.
Improve speed of pronounce_number_en
- Simplify broken test and make it work on python 3.8
- Add python 3.8 to mandatory test cases
- Add LICENSE file as part of skill creation
- Colorize the output
- Add basic manifest.yml as part of skill creation
- Fix passwords containing quotes (")
Fix using of hotword structure for custom wakeword
forslund and others added 28 commits December 3, 2019 17:11
At some point during refactoring the ability to hit Ctrl+C to exit the basic CLI was lost.

The signal.SIGINT handler is needed by the graphical GUI, but it
interfered with the use of sys.stdin.readline() in the simple CLI.
Rearrange the installation of the handler for only the GUI.

To test, run:
   mycroft-cli-client --simple
Then hit Ctrl+C.  Before this change nothing happens (you just see the "^C" printed out).  After the change it exits as expected.
When mycroft_skill.find_resource fails to load a resource for self.lang
fall back to lang 'en-us'
as most skills/resources are available in english by default.

==== Fixed Issues ====
Fix broken test case on Python 3.8
Fallback to 'en-us' when resource fails
Fixing dev_setup.sh for Arch Linux
removing the tmp files needed the recursive flag
Fix --clean option of dev_setup.sh
use default python version on redhat
If hotword entry is missing either add from old listener location
- Proper docstring
- " -> '
The DEBUG, has been filtered by default. This will disregard the DEBUG
filter completely since the same effect can be achieved by setting the
debug level using ":log level debug".
Make sure hotword entry has phonemes and threshold
Add support for the Porcupine wakeword engine.
Flagged by flake8 after merge
Fix incorrect porcupine shutdown and Exception
@domcross domcross merged commit f98eb66 into domcross:dev Dec 13, 2019
domcross pushed a commit that referenced this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants