Make sure hotword entry has phonemes and threshold #2418

forslund · 2019-12-07T19:27:41Z

Description

Pulls phonemes and threshold from "listener" entry if the hotword entry is missing these.

Resolves #2417

Use the mycroft.conf from issue pocketsphinx custom wake words broken (backend) #2417, make sure that "hey jarvis" can be selected on the webpage and used.
Add the andromeda entry from Fix using of hotword structure for custom wakeword #2395 and make sure that can be selected and used
Switch to the christopher wakeword on the backend and make sure that works as intended.

CLA [ Yes ]

If hotword entry is missing either add from old listener location

- Proper docstring - " -> '

chrisveilleux

nice commenting and test coverage!

forslund added 2 commits December 7, 2019 20:18

Make sure hotword entry has phonemes and threshold

2c2c933

If hotword entry is missing either add from old listener location

Clean up of create_wake_word_recognizer

f9585e4

- Proper docstring - " -> '

forslund requested review from chrisveilleux and JarbasAl December 7, 2019 19:27

devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Dec 7, 2019

Add Testcase to verify hotword fallback behaviour

0d8cbb5

chrisveilleux approved these changes Dec 9, 2019

View reviewed changes

forslund merged commit 2263fab into MycroftAI:dev Dec 9, 2019

forslund deleted the bugfix/missing-hotword-parts branch December 9, 2019 19:25