This repository was archived by the owner on Sep 8, 2024. It is now read-only.
Disregard DEBUG entry in CLI filter #2421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DEBUG, has been filtered by default. This will disregard the DEBUG filter completely since the same effect can be achieved by setting the debug level using ":log level debug".
KathyReid
approved these changes
Dec 9, 2019
There was a problem hiding this comment.
kathyreid@kathyreid-zenbook-ux533fd:~/mycroft-core$ git pull forslund feature/dont-filter-debug
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Total 6 (delta 5), reused 5 (delta 5), pack-reused 1
Unpacking objects: 100% (6/6), done.
From https://github.com/forslund/mycroft-core
* branch feature/dont-filter-debug -> FETCH_HEAD
* [new branch] feature/dont-filter-debug -> forslund/feature/dont-filter-debug
Updating 24071cdea0..2fa81aac52
Fast-forward
mycroft/client/text/text_client.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
kathyreid@kathyreid-zenbook-ux533fd:~/mycroft-core$ git status
On branch dev
Your branch is ahead of 'origin/dev' by 1 commit.
(use "git push" to publish your local commits)
nothing to commit, working tree clean
kathyreid@kathyreid-zenbook-ux533fd:~$ cat ~/.mycroft_cli.conf
{"filters": ["mouth.viseme", "mouth.display", "mouth.icon", "DEBUG"], "cy_chat_area": 7, "show_last_key": false, "max_log_lines": 5000, "show_meter": true}
Working as intended, thanks Ake!
Approving.
|
Thanks @KathyReid, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The DEBUG, has been filtered by default. This will disregard the DEBUG
filter completely since the same effect can be achieved by setting the
debug level using ":log level debug".
Should resolve #2420
How to test
Add "DEBUG" to the "filters" list in
~/.mycroft_cli.confand ensure that setting the log level in the cli using:log level debugwill show the debug messages.Contributor license agreement signed?
CLA [ Yes ]