This repository was archived by the owner on Sep 8, 2024. It is now read-only.
improve test runtime #2405
Merged
improve test runtime #2405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay. I was pondering if directly changing the internal values of the TTS object is really a good thing buuut the member isn't marked as no-tampering (leading _) so I guess this is alright to do. (In the future we might consider changing that and then the test will have to be updated) As always, thaks for contributing :) Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve runtime of test_ssml_support by 80%, since it is enough to update the supported ssml tags in between the tests.
How to test
unit tests are still passing but faster
Contributor license agreement signed?
CLA [ Yes]