Skip to content
This repository was archived by the owner on Sep 8, 2024. It is now read-only.

Conversation

forslund
Copy link
Collaborator

Description

Fixes overriding settings from listener config

How to test

  • Make sure a the default wakeword works

  • Make sure a change on home.mycroft.ai to "Hey Ezra" or "Cristopher" works.

  • Make sure a custom entry works:

  "listener": {
    "wake_word": "andromeda"
  },
  "hotwords": {
    "andromeda": {
      "module": "pocketsphinx",
      "phonemes": "AE N D R AA M AH D AH .",
      "sample_rate": 16000,
      "threshold": "1e-25",
      "lang": "en-us"
    }
  }

Contributor license agreement signed?

CLA [ Yes ]

Fixes overriding settings from listener config
@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Nov 26, 2019
@forslund forslund merged commit 2169929 into MycroftAI:dev Dec 3, 2019
@JarbasAl
Copy link
Contributor

JarbasAl commented Dec 7, 2019

this fix actually broke stuff (as seen in chat)

things were that way for server compatibility, the TODO in the comments should also be removed now, see original discussion here #1062 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants