Skip to content

Conversation

drich10
Copy link
Contributor

@drich10 drich10 commented Dec 9, 2024

Notes to reviewer

Rebases changes from master onto release branch 7.12.x to pull in CI and bug fixes

aliculPix4D and others added 14 commits October 10, 2024 16:59
Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
…t suite

Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
running on Broadcom's GCP workers now so we can run these tests again
(for now)
In the future we'll probably skip or remove them unless gdn starts
working with cgroups v2

Signed-off-by: Taylor Silva <dev@taydev.net>
merging main back into master
This reverts commit da8e4b2.

Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: claire tinati <mrt59@cornell.edu>
fix: topgun k8s container limits test supports cgroups v1 and v2
- if policy checker (e.g. OPA) does not allow the action the reason is never shown to the end user. The end user saw only Forbidden without the message why it is forbidden. To see more details end user was required to run the command with --verbose or inspect the request in web UI.
- this PR improves the error message the end user sees by printing also the reason from the response body

Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
…prove-error-msg

go-concourse:connection client prints response body to the end user
@drich10 drich10 requested a review from a team as a code owner December 9, 2024 20:04
Copy link
Contributor

@Spimtav Spimtav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a standard backport to me. Approving.

@drich10 drich10 added the misc label Dec 9, 2024
@drich10 drich10 merged commit f0da5fc into release/7.12.x Dec 9, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants