-
-
Notifications
You must be signed in to change notification settings - Fork 866
Rebase master onto release 7.12.x #9037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
…t suite Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
running on Broadcom's GCP workers now so we can run these tests again (for now) In the future we'll probably skip or remove them unless gdn starts working with cgroups v2 Signed-off-by: Taylor Silva <dev@taydev.net>
merging main back into master
This reverts commit da8e4b2. Signed-off-by: Taylor Silva <dev@taydev.net>
Revert "bump go dependencies"
Signed-off-by: claire tinati <mrt59@cornell.edu>
fix: topgun k8s container limits test supports cgroups v1 and v2
Split go-concourse client tests
- if policy checker (e.g. OPA) does not allow the action the reason is never shown to the end user. The end user saw only Forbidden without the message why it is forbidden. To see more details end user was required to run the command with --verbose or inspect the request in web UI. - this PR improves the error message the end user sees by printing also the reason from the response body Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
…prove-error-msg go-concourse:connection client prints response body to the end user
Spimtav
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a standard backport to me. Approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes to reviewer
Rebases changes from master onto release branch 7.12.x to pull in CI and bug fixes