go-concourse:connection client prints response body to the end user #9011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliculPix4D
commented
Oct 10, 2024
marco-m-pix4d
approved these changes
Oct 11, 2024
analytically
approved these changes
Oct 12, 2024
|
if you could resolve the conflict we are good to go. Thank you! |
- if policy checker (e.g. OPA) does not allow the action the reason is never shown to the end user. The end user saw only Forbidden without the message why it is forbidden. To see more details end user was required to run the command with --verbose or inspect the request in web UI. - this PR improves the error message the end user sees by printing also the reason from the response body Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
8e75eeb to
fa06840
Compare
Done. @xtremerui Thanks for taking care of these PRs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-concourse:connection client prints response body to the end user
--verboseor inspect the request in web UI (if possible e.g. by clicking on expose pipeline button).Almost every fly command (except e.g. set-pipeline) still uses the deprecated HTTP client called connection client, so this PR affects many commands.
Example:
fly expose-pipeline(and many other commands) when policy checker (OPA) returned200and denied the action (correct JSON body).What users saw before:
What users see now?