fix: topgun k8s container limits test supports cgroups v1 and v2 #9028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: claire tinati <mrt59@cornell.edu>
|
tag war! Hi 👋 |
taylorsilva
approved these changes
Nov 15, 2024
|
Dang that's some funny timing 😆. Sorry for stepping on your toes with the label a second ago! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed by this PR
cgroups v1 and v2 use completely different filenames and directory structures. Currently, this k8s-topgun container limits test can only handle cgroups v1 formats, and will fail on cgroups v2 containers due to "file not found" errors. The changes in this PR fix the implementation so that it can handle both cgroups v1 and v2-style formats, regardless of which is present.
Note: the changes in this PR were largely based on these fixes to the equivalent test in the
testflightpackage:Notes to reviewer
Testing this commit requires access to the k8s-topgun cluster, which is complex and time-consuming. Probably easier if i demo live.