-
-
Notifications
You must be signed in to change notification settings - Fork 866
merging main back into master #9022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
on systems where cgroupv1 is no longer enabled (Ubuntu 24.04, Fedora's last few releases) the worker fails to start containers or fails to set container limits on containers (if set). This happens because /sys/fs/cgroup/cgroup.subtree_control is empty in the parent cgroup. Ensuring the worker is in the hosts cgroup _usually_ ensures that it's in a cgroup that has its cgroup.subtree_control populated. When containerd makes cgroups from this cgroup it's then able to pass the controllers in /sys/fs/cgroup/cgroup.controllers to its child cgroups. If the cgroup that containerd starts in does not have these controllers then this can result in containerd failing to create containers or failing to set cpu/memory limits on containers. I've ran into both errors on Fedora 39, 40, and Ubuntu 24.04. Signed-off-by: Taylor Silva <dev@taydev.net>
when cgroupsv1 is disabled all the subfolders in /sys/fs/cgroup/ are gone and we have to use the cgroupv2 interface files instead Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
some of our external repos into this one Signed-off-by: Taylor Silva <dev@taydev.net>
on hosts running cgroup v2 only, which is all of the OSS workers, we need to start in the parent cgroup so we have access to all the controllers. Otherwise docker starts us in a cgroup with no controllers and we can only use controllers that are our parent cgroup passed down to us. Signed-off-by: Taylor Silva <dev@taydev.net>
and make LKE the default engine. We won't be running tests on GKE or PKS Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
should keep waiting Signed-off-by: Taylor Silva <dev@taydev.net>
ran: go get -u ./... go mod tidy Signed-off-by: Taylor Silva <dev@taydev.net>
ran in the root and web/wats/ yarn upgrade --latest --caret Signed-off-by: Taylor Silva <dev@taydev.net>
the library says it will just use the existing reader timeout value if this timeout is set to zero Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
Signed-off-by: Taylor Silva <dev@taydev.net>
running on Broadcom's GCP workers now so we can run these tests again (for now) In the future we'll probably skip or remove them unless gdn starts working with cgroups v2 Signed-off-by: Taylor Silva <dev@taydev.net>
The update from
->
Causes: unknown field IgnoredFields in struct literal of type merge.Updater |
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broadcom is back on board with providing the project infrastructure so merging back in the changes I had made on this branch. This is also the branch I had released 7.12.0 from.