Split go-concourse client tests #9010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
…t suite Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
Signed-off-by: aliculPix4D <aleksandar.licul@pix4d.com>
ea64e4c to
c8b68f0
Compare
marco-m-pix4d
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
@taylorsilva FYI these PRs by @aliculPix4D are a series of fixes/cleanups we did in our Concourse deployment.
|
Thanks @xtremerui ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split go-concourse client tests
HTTPAgentseparate and clean. If tests are mixed as before this PR, it will be easy to remove theHTTPAgenttest by accident at some later stage when connection client gets removed. This is especially true because there is only 1 test forHTTPAgent.The test coverage percentage remained the same.
commit 1: Connection fakes are unused. Let's remove them and never generate them
commit 2: Remove the HTTP agent test from the connection test suite
commit 3: Create go-concourse/concourse/internal/http_agent_test.go and add back the test removed in commit 2