-
Notifications
You must be signed in to change notification settings - Fork 37.7k
guix: consistently use -ffile-prefix-map #26018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Aside from being the newer, more comprehensive option, it's what we claim to use in the patch docs, and everywhere else in guix.
ACK af2a7c8 |
Guix Build (x86_64): b768cab742535aa13203cf0338204b197a841290be8ebe76bd41e3daed228758 guix-build-af2a7c894308/output/aarch64-linux-gnu/SHA256SUMS.part
574df26dfbed45ccd66467963d17a455d9b9b97252b112159a615d8fda05f500 guix-build-af2a7c894308/output/aarch64-linux-gnu/bitcoin-af2a7c894308-aarch64-linux-gnu-debug.tar.gz
626a9f4599045856da6fa1edb681351249d87657d64e970a07484c8a8374f81f guix-build-af2a7c894308/output/aarch64-linux-gnu/bitcoin-af2a7c894308-aarch64-linux-gnu.tar.gz
f6d0161af46b7c3de44c6f2c73193bcb1b1b031fd9a3295e6320a107b6f32c52 guix-build-af2a7c894308/output/arm-linux-gnueabihf/SHA256SUMS.part
9c756dddb69e680a8e724910d291b119a2e4406164b6e8c9e65af0e977779a79 guix-build-af2a7c894308/output/arm-linux-gnueabihf/bitcoin-af2a7c894308-arm-linux-gnueabihf-debug.tar.gz
d916d17e9c70aa1ce2b3f276621d671485a262bab3e86eae48d6b0ab754dab5a guix-build-af2a7c894308/output/arm-linux-gnueabihf/bitcoin-af2a7c894308-arm-linux-gnueabihf.tar.gz
c49a86c7d8d1302135efde244ff5e99e21ad4689b04e94d7b779c53c520f5908 guix-build-af2a7c894308/output/arm64-apple-darwin/SHA256SUMS.part
b08271888ed3072e8418d97a0d3965fb73f020060d251b952d586662dbcc44db guix-build-af2a7c894308/output/arm64-apple-darwin/bitcoin-af2a7c894308-arm64-apple-darwin-unsigned.dmg
ca3fae7652b144632ce5d51530851a8fcfad7a02c9754da0135ff935566c06d5 guix-build-af2a7c894308/output/arm64-apple-darwin/bitcoin-af2a7c894308-arm64-apple-darwin-unsigned.tar.gz
db1906c1bf155f36e1eaf85367995a4a8db7d94c4df435a2bf1361f72e424ec8 guix-build-af2a7c894308/output/arm64-apple-darwin/bitcoin-af2a7c894308-arm64-apple-darwin.tar.gz
422852cb5fda8156a9f3d83675d649d1fc9434b968c5fee5977fb8285fac9553 guix-build-af2a7c894308/output/dist-archive/bitcoin-af2a7c894308.tar.gz
5bd3bbf6eea045fbd70dd68d1665c717489777dc430a3636362e57235fbd1a54 guix-build-af2a7c894308/output/powerpc64-linux-gnu/SHA256SUMS.part
d151f2159781c299154c52504ed01ad0e70557b498ae7fc93149465697a37dfc guix-build-af2a7c894308/output/powerpc64-linux-gnu/bitcoin-af2a7c894308-powerpc64-linux-gnu-debug.tar.gz
a4fad39e5e7bda6f4f0a84081b40dab0a44c327df365546cb6ecc171849bd6a1 guix-build-af2a7c894308/output/powerpc64-linux-gnu/bitcoin-af2a7c894308-powerpc64-linux-gnu.tar.gz
df181acde6cbde8380c989a3d1af5b9b47af4dabcaeecc4b68bbe295ffa7aeb2 guix-build-af2a7c894308/output/powerpc64le-linux-gnu/SHA256SUMS.part
6eb59b4e2ab0f5cbadb1de90c57454d8f3460e3521f39bf3ad977071be58f47c guix-build-af2a7c894308/output/powerpc64le-linux-gnu/bitcoin-af2a7c894308-powerpc64le-linux-gnu-debug.tar.gz
3fbf0abb2e970250da805fc8138b2dc267279689ee7261980804adfd03cd2a76 guix-build-af2a7c894308/output/powerpc64le-linux-gnu/bitcoin-af2a7c894308-powerpc64le-linux-gnu.tar.gz
bff8f28e8cf57468dd04f72a4204e343f6a3b9e78d8867a8df377c57d009916f guix-build-af2a7c894308/output/riscv64-linux-gnu/SHA256SUMS.part
46f91d3ba858753d6269ce905a90bfb10b7ca0d397f9c07c4e2325d9c289497b guix-build-af2a7c894308/output/riscv64-linux-gnu/bitcoin-af2a7c894308-riscv64-linux-gnu-debug.tar.gz
f97347b75d96ecde3ac1d14fd5de965cdaa4e6882142911424a4a567a38b5502 guix-build-af2a7c894308/output/riscv64-linux-gnu/bitcoin-af2a7c894308-riscv64-linux-gnu.tar.gz
70e73849e2ec2a5b2a5e9430e610bd8526db87afd18f895f60110729060e47f5 guix-build-af2a7c894308/output/x86_64-apple-darwin/SHA256SUMS.part
20141ee9fc18a2dab27ba7df4db3bd874da1356e97f367f010ed84c058776789 guix-build-af2a7c894308/output/x86_64-apple-darwin/bitcoin-af2a7c894308-x86_64-apple-darwin-unsigned.dmg
c5d5463d6c1eba2d776b6e91b27574be33e5a03307788e85791ad68679fd1c99 guix-build-af2a7c894308/output/x86_64-apple-darwin/bitcoin-af2a7c894308-x86_64-apple-darwin-unsigned.tar.gz
1484b219bcf6471830aeceb0de1ff6303e49867157b1be49309f4a96b8cd5308 guix-build-af2a7c894308/output/x86_64-apple-darwin/bitcoin-af2a7c894308-x86_64-apple-darwin.tar.gz
a09afbe4ed7e8c6ec2943d9fd1383fb02ce6fa3175380d6a16487c5d5a8b029e guix-build-af2a7c894308/output/x86_64-linux-gnu/SHA256SUMS.part
318e25fad045477049c62ab7c180b9b69b857dbdcc4ddecb1ab9e1ecce6d857c guix-build-af2a7c894308/output/x86_64-linux-gnu/bitcoin-af2a7c894308-x86_64-linux-gnu-debug.tar.gz
2e0f7529ed38ef2f1a50f5d422c7ebd80ff8eeb5397ed8dfd9a00f98dd83ef54 guix-build-af2a7c894308/output/x86_64-linux-gnu/bitcoin-af2a7c894308-x86_64-linux-gnu.tar.gz
0987fe3eb9036521f0d5c36cceb49e6cb37b1128bb5762d876d5b57c50dbf9d4 guix-build-af2a7c894308/output/x86_64-w64-mingw32/SHA256SUMS.part
788cef75e8408db0a77aed3680cfdb4dc48eb17b26ffb5624bb7aac30aad71e2 guix-build-af2a7c894308/output/x86_64-w64-mingw32/bitcoin-af2a7c894308-win64-debug.zip
61b3c0e4b8bfcfeccd93d361bde532c2aa32b0c978fb05ce4acdeaee63c72e3e guix-build-af2a7c894308/output/x86_64-w64-mingw32/bitcoin-af2a7c894308-win64-setup-unsigned.exe
e071185aecfdf47a27d45b64b8c280c515237449d9c56af271c2ee3d0944424c guix-build-af2a7c894308/output/x86_64-w64-mingw32/bitcoin-af2a7c894308-win64-unsigned.tar.gz
884732a376465efdc65e8867ac23914f9c4d6db9fb5b6ae9df27617bd6d3ca55 guix-build-af2a7c894308/output/x86_64-w64-mingw32/bitcoin-af2a7c894308-win64.zip Guix Build (arm64): b768cab742535aa13203cf0338204b197a841290be8ebe76bd41e3daed228758 guix-build-af2a7c894308/output/aarch64-linux-gnu/SHA256SUMS.part
574df26dfbed45ccd66467963d17a455d9b9b97252b112159a615d8fda05f500 guix-build-af2a7c894308/output/aarch64-linux-gnu/bitcoin-af2a7c894308-aarch64-linux-gnu-debug.tar.gz
626a9f4599045856da6fa1edb681351249d87657d64e970a07484c8a8374f81f guix-build-af2a7c894308/output/aarch64-linux-gnu/bitcoin-af2a7c894308-aarch64-linux-gnu.tar.gz
f6d0161af46b7c3de44c6f2c73193bcb1b1b031fd9a3295e6320a107b6f32c52 guix-build-af2a7c894308/output/arm-linux-gnueabihf/SHA256SUMS.part
9c756dddb69e680a8e724910d291b119a2e4406164b6e8c9e65af0e977779a79 guix-build-af2a7c894308/output/arm-linux-gnueabihf/bitcoin-af2a7c894308-arm-linux-gnueabihf-debug.tar.gz
d916d17e9c70aa1ce2b3f276621d671485a262bab3e86eae48d6b0ab754dab5a guix-build-af2a7c894308/output/arm-linux-gnueabihf/bitcoin-af2a7c894308-arm-linux-gnueabihf.tar.gz
c49a86c7d8d1302135efde244ff5e99e21ad4689b04e94d7b779c53c520f5908 guix-build-af2a7c894308/output/arm64-apple-darwin/SHA256SUMS.part
b08271888ed3072e8418d97a0d3965fb73f020060d251b952d586662dbcc44db guix-build-af2a7c894308/output/arm64-apple-darwin/bitcoin-af2a7c894308-arm64-apple-darwin-unsigned.dmg
ca3fae7652b144632ce5d51530851a8fcfad7a02c9754da0135ff935566c06d5 guix-build-af2a7c894308/output/arm64-apple-darwin/bitcoin-af2a7c894308-arm64-apple-darwin-unsigned.tar.gz
db1906c1bf155f36e1eaf85367995a4a8db7d94c4df435a2bf1361f72e424ec8 guix-build-af2a7c894308/output/arm64-apple-darwin/bitcoin-af2a7c894308-arm64-apple-darwin.tar.gz
422852cb5fda8156a9f3d83675d649d1fc9434b968c5fee5977fb8285fac9553 guix-build-af2a7c894308/output/dist-archive/bitcoin-af2a7c894308.tar.gz
5bd3bbf6eea045fbd70dd68d1665c717489777dc430a3636362e57235fbd1a54 guix-build-af2a7c894308/output/powerpc64-linux-gnu/SHA256SUMS.part
d151f2159781c299154c52504ed01ad0e70557b498ae7fc93149465697a37dfc guix-build-af2a7c894308/output/powerpc64-linux-gnu/bitcoin-af2a7c894308-powerpc64-linux-gnu-debug.tar.gz
a4fad39e5e7bda6f4f0a84081b40dab0a44c327df365546cb6ecc171849bd6a1 guix-build-af2a7c894308/output/powerpc64-linux-gnu/bitcoin-af2a7c894308-powerpc64-linux-gnu.tar.gz
df181acde6cbde8380c989a3d1af5b9b47af4dabcaeecc4b68bbe295ffa7aeb2 guix-build-af2a7c894308/output/powerpc64le-linux-gnu/SHA256SUMS.part
6eb59b4e2ab0f5cbadb1de90c57454d8f3460e3521f39bf3ad977071be58f47c guix-build-af2a7c894308/output/powerpc64le-linux-gnu/bitcoin-af2a7c894308-powerpc64le-linux-gnu-debug.tar.gz
3fbf0abb2e970250da805fc8138b2dc267279689ee7261980804adfd03cd2a76 guix-build-af2a7c894308/output/powerpc64le-linux-gnu/bitcoin-af2a7c894308-powerpc64le-linux-gnu.tar.gz
bff8f28e8cf57468dd04f72a4204e343f6a3b9e78d8867a8df377c57d009916f guix-build-af2a7c894308/output/riscv64-linux-gnu/SHA256SUMS.part
46f91d3ba858753d6269ce905a90bfb10b7ca0d397f9c07c4e2325d9c289497b guix-build-af2a7c894308/output/riscv64-linux-gnu/bitcoin-af2a7c894308-riscv64-linux-gnu-debug.tar.gz
f97347b75d96ecde3ac1d14fd5de965cdaa4e6882142911424a4a567a38b5502 guix-build-af2a7c894308/output/riscv64-linux-gnu/bitcoin-af2a7c894308-riscv64-linux-gnu.tar.gz
70e73849e2ec2a5b2a5e9430e610bd8526db87afd18f895f60110729060e47f5 guix-build-af2a7c894308/output/x86_64-apple-darwin/SHA256SUMS.part
20141ee9fc18a2dab27ba7df4db3bd874da1356e97f367f010ed84c058776789 guix-build-af2a7c894308/output/x86_64-apple-darwin/bitcoin-af2a7c894308-x86_64-apple-darwin-unsigned.dmg
c5d5463d6c1eba2d776b6e91b27574be33e5a03307788e85791ad68679fd1c99 guix-build-af2a7c894308/output/x86_64-apple-darwin/bitcoin-af2a7c894308-x86_64-apple-darwin-unsigned.tar.gz
1484b219bcf6471830aeceb0de1ff6303e49867157b1be49309f4a96b8cd5308 guix-build-af2a7c894308/output/x86_64-apple-darwin/bitcoin-af2a7c894308-x86_64-apple-darwin.tar.gz
a09afbe4ed7e8c6ec2943d9fd1383fb02ce6fa3175380d6a16487c5d5a8b029e guix-build-af2a7c894308/output/x86_64-linux-gnu/SHA256SUMS.part
318e25fad045477049c62ab7c180b9b69b857dbdcc4ddecb1ab9e1ecce6d857c guix-build-af2a7c894308/output/x86_64-linux-gnu/bitcoin-af2a7c894308-x86_64-linux-gnu-debug.tar.gz
2e0f7529ed38ef2f1a50f5d422c7ebd80ff8eeb5397ed8dfd9a00f98dd83ef54 guix-build-af2a7c894308/output/x86_64-linux-gnu/bitcoin-af2a7c894308-x86_64-linux-gnu.tar.gz
0987fe3eb9036521f0d5c36cceb49e6cb37b1128bb5762d876d5b57c50dbf9d4 guix-build-af2a7c894308/output/x86_64-w64-mingw32/SHA256SUMS.part
788cef75e8408db0a77aed3680cfdb4dc48eb17b26ffb5624bb7aac30aad71e2 guix-build-af2a7c894308/output/x86_64-w64-mingw32/bitcoin-af2a7c894308-win64-debug.zip
61b3c0e4b8bfcfeccd93d361bde532c2aa32b0c978fb05ce4acdeaee63c72e3e guix-build-af2a7c894308/output/x86_64-w64-mingw32/bitcoin-af2a7c894308-win64-setup-unsigned.exe
e071185aecfdf47a27d45b64b8c280c515237449d9c56af271c2ee3d0944424c guix-build-af2a7c894308/output/x86_64-w64-mingw32/bitcoin-af2a7c894308-win64-unsigned.tar.gz
884732a376465efdc65e8867ac23914f9c4d6db9fb5b6ae9df27617bd6d3ca55 guix-build-af2a7c894308/output/x86_64-w64-mingw32/bitcoin-af2a7c894308-win64.zip |
No need to use "newer, more comprehensive option", when job is done with the current option. But it won't hurt :)
Then patch docs should be adjusted.
Agree with this point. Considering all points above, approach ACK af2a7c8. |
GUIX hashes x86:
arm64:
|
Guix build on
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK af2a7c8
af2a7c8 guix: consistently use -ffile-prefix-map (fanquake) Pull request description: Aside from being the [newer, more comprehensive option](https://reproducible-builds.org/docs/build-path/), it's what we claim to use in the patch docs, and everywhere else in guix. ACKs for top commit: achow101: ACK af2a7c8 hebasto: ACK af2a7c8 Tree-SHA512: d34f6bc2a52811be42b911643adfefe0f232247a89dca992429a32964e1fc32225c7e996d53db4cecf455a492940d6492ad15c0e7360a98e4265b51f72a1b6d4
backport: merge bitcoin#25643, bitcoin#23583, bitcoin#23618, bitcoin#23603, bitcoin#23817, bitcoin#24520, bitcoin#24508, bitcoin#25639, bitcoin#26018, bitcoin#25437, bitcoin#25484, bitcoin#23585, bitcoin#24549, bitcoin#24733, bitcoin#21991, bitcoin#22526, bitcoin#25633, bitcoin#24597, bitcoin#24955, bitcoin#25099, bitcoin#24552, bitcoin#21851, bitcoin#25389, bitcoin#25357, partial bitcoin#22318 (guix backports: part 3)
Aside from being the newer, more comprehensive option, it's what we
claim to use in the patch docs, and everywhere else in guix.