-
Notifications
You must be signed in to change notification settings - Fork 37.8k
build: Fix "ERR: Unsigned tarballs do not exist" #24733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 7762c56 |
I ran into the same error. Can I just apply this patch and continue guix-attest, or do we need a new RC? |
I guess not, because guix will think I'm trying to build a random commit instead of a release. Anyway, this would confuse too many other signers. |
Applying this patch after building the binaries but before code signing worked for me. |
Not for me, |
7762c56 build: Fix "ERR: Unsigned tarballs do not exist" (Hennadii Stepanov) Pull request description: This was missed in 53dd616 (bitcoin#24549). ACKs for top commit: laanwj: ACK 7762c56 fanquake: ACK 7762c56 - this should have been a part of bitcoin#24549. Tree-SHA512: 526e4e6ee1463003059b9703030c5b0537445783c45a205024c9c9e3493da967733153a1dc80594fed15a336805c1cf14c8d13cd106186a7544f51d0d542f335
Github-Pull: bitcoin#24733 Rebased-From: 7762c56
Being backported in #24755. |
39396ab build: Fix "ERR: Unsigned tarballs do not exist" (Hennadii Stepanov) db8a5d6 guix: fix vmov alignment issues with gcc 10.3.0 & mingw-w64 (fanquake) Pull request description: Backports: * #24733 * #24736 ACKs for top commit: gruve-p: ACK 39396ab hebasto: ACK 39396ab, backported locally, got zero diff with the PR branch. jarolrod: ACK 39396ab Tree-SHA512: 3573870c48fbde538a490c8b7103779987d3cce1165ca639c164aaf8ef82290fb99fcd461d0fed0208b43174b21284b21eb032c00512b986ae824295cc7935a8
This was missed in 53dd616 (#24549).