Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 1, 2022

This was missed in 53dd616 (#24549).

@fanquake fanquake added this to the 23.0 milestone Apr 1, 2022
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7762c56 - this should have been a part of #24549.

@laanwj
Copy link
Member

laanwj commented Apr 1, 2022

ACK 7762c56
Needed to make exactly this change before the codesign attachment worked.

@laanwj laanwj merged commit afac75f into bitcoin:master Apr 1, 2022
@hebasto hebasto deleted the 220401-sign branch April 1, 2022 09:38
@Sjors
Copy link
Member

Sjors commented Apr 1, 2022

I ran into the same error. Can I just apply this patch and continue guix-attest, or do we need a new RC?

@Sjors
Copy link
Member

Sjors commented Apr 1, 2022

I guess not, because guix will think I'm trying to build a random commit instead of a release. Anyway, this would confuse too many other signers.

@guggero
Copy link
Contributor

guggero commented Apr 1, 2022

Applying this patch after building the binaries but before code signing worked for me.

@Sjors
Copy link
Member

Sjors commented Apr 1, 2022

Not for me, ./contrib/guix/guix-codesign triggered it.

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 3, 2022
7762c56 build: Fix "ERR: Unsigned tarballs do not exist" (Hennadii Stepanov)

Pull request description:

  This was missed in 53dd616 (bitcoin#24549).

ACKs for top commit:
  laanwj:
    ACK 7762c56
  fanquake:
    ACK 7762c56 - this should have been a part of bitcoin#24549.

Tree-SHA512: 526e4e6ee1463003059b9703030c5b0537445783c45a205024c9c9e3493da967733153a1dc80594fed15a336805c1cf14c8d13cd106186a7544f51d0d542f335
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Apr 4, 2022
@fanquake
Copy link
Member

fanquake commented Apr 4, 2022

Being backported in #24755.

maflcko pushed a commit that referenced this pull request Apr 5, 2022
39396ab build: Fix "ERR: Unsigned tarballs do not exist" (Hennadii Stepanov)
db8a5d6 guix: fix vmov alignment issues with gcc 10.3.0 & mingw-w64 (fanquake)

Pull request description:

  Backports:
  * #24733
  * #24736

ACKs for top commit:
  gruve-p:
    ACK 39396ab
  hebasto:
    ACK 39396ab, backported locally, got zero diff with the PR branch.
  jarolrod:
    ACK 39396ab

Tree-SHA512: 3573870c48fbde538a490c8b7103779987d3cce1165ca639c164aaf8ef82290fb99fcd461d0fed0208b43174b21284b21eb032c00512b986ae824295cc7935a8
@bitcoin bitcoin locked and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants