depends: don't restrict --enable-lto to non-guix cctools #25633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did |
I'm not exactly sure, but I wouldn't have thought so, as we would have been using the same clang / llvm-config versions in Guix. It looks like it's just been working silently for a while, as the option defaults to yes, and llvm-config is found even if not specified explicitly. |
|
GUIX hashes x86: arm64: |
|
Concept ACK |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jul 20, 2022
c12d4f1 to
b218a0c
Compare
|
I've rebased to incorporate recent changes to master. However this branch is still not quite working for macOS Guix builds. Our libtool isn't properly recognizing LLVM bitcode, and it's not yet clear to me why that is the case, as cctools (libtool) is definitely being compiled with lto support enabled. |
|
Just a dump of what I've looked at so far. Doing builds with the branch in #25391 (which includes this change) for convenience. Building depends locally with However building the same branch in Guix, i.e /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool -static -o libminiupnpc.a miniwget.o minixml.o igd_desc_parse.o minisoap.o miniupnpc.o upnpreplyparse.o upnpcommands.o upnperrors.o connecthostport.o portlistingparse.o receivedata.o upnpdev.o addr_is_reserved.o minissdpc.o
error: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool: file: miniwget.o is not an object file (not allowed in a library)
error: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool: file: minixml.o is not an object file (not allowed in a library)
error: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool: file: igd_desc_parse.o is not an object file (not allowed in a library)
error: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool: file: minisoap.o is not an object file (not allowed in a library)
error: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool: file: miniupnpc.o is not an object file (not allowed in a library)
error: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool: file: upnpreplyparse.o is not an object file (not allowed in a library)
error: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool: file: upnpcommands.o is not an object file (not allowed in a library)
error: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool: file: upnperrors.o is not an object file (not allowed in a library)
error: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool: file: connecthostport.o is not an object file (not allowed in a library)
error: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool: file: portlistingparse.o is not an object file (not allowed in a library)
error: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool: file: receivedata.o is not an object file (not allowed in a library)
error: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool: file: upnpdev.o is not an object file (not allowed in a library)
error: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool: file: addr_is_reserved.o is not an object file (not allowed in a library)
error: /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool: file: minissdpc.o is not an object file (not allowed in a library)
make[1]: *** [Makefile:302: libminiupnpc.a] Error 1Looking at file miniupnpc/2.2.2-fcea302a1da/miniupnpc.o
miniupnpc/2.2.2-fcea302a1da/miniupnpc.o: LLVM bitcode, wrapper x86_64and they should be supported if libtool in cctools is compiled with LTO support ( /root/.guix-profile/bin/clang -DPACKAGE_NAME=\"cctools\" -DPACKAGE_TARNAME=\"cctools\" -DPACKAGE_VERSION=\"973.0.1\" -DPACKAGE_STRING=\"cctools\ 973.0.1\" -DPACKAGE_BUGREPORT=\"t.poechtrager@gmail.com\" -DPACKAGE_URL=\"\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DEMULATED_HOST_CPU_TYPE=16777223 -DEMULATED_HOST_CPU_SUBTYPE=3 -D__STDC_LIMIT_MACROS=1 -D__STDC_CONSTANT_MACROS=1 -DHAVE_EXECINFO_H=1 -DHAVE_UTIMENSAT=1 -DHAVE_BCOPY=1 -DHAVE_BCMP=1 -DHAVE_BZERO=1 -DHAVE_INDEX=1 -DHAVE_RINDEX=1 -DHAVE_STAT_ST_MTIM=1 -DHAVE_CLOCK_GETTIME=1 -I. -I/bitcoin/depends/x86_64-apple-darwin/native/include -I../include -I../include/foreign -I../libstuff -Wall -Wno-long-long -Wno-import -Wno-format -Wno-deprecated -Wno-unused-variable -Wno-unused-private-field -Wno-unused-function -Wno-invalid-offsetof -Wno-int-conversion -Wno-char-subscripts -Wno-shift-negative-value -Wno-misleading-indentation -Wno-gnu-folding-constant -DLTO_SUPPORT -D__DARWIN_UNIX03 -D__LITTLE_ENDIAN__=1 -O3 -isystem /usr/local/include -isystem /usr/pkg/include -DLD64_VERSION_NUM=609 -fblocks -D__arm64__ -c -o libtool.o libtool.cWe can further confirm that by checking that the libtool binary has symbols that would only be compiled in under LTO support, i.e nm -C /bitcoin/depends/x86_64-apple-darwin/native/bin/x86_64-apple-darwin-libtool | grep lto_
0000000000437480 b lto_create
0000000000437488 b lto_create_local
0000000000437490 b lto_dispose
00000000004374c0 b lto_error
000000000040e558 T lto_free
00000000004374b8 b lto_get_cputype
000000000040e5e8 T lto_get_nlist_64
000000000040e564 T lto_get_nsyms
00000000004374a0 b lto_get_num_symbols
00000000004374a8 b lto_get_sym_attr
00000000004374b0 b lto_get_sym_name
0000000000437498 b lto_get_target
0000000000437470 b lto_handle
0000000000437478 b lto_is_object
000000000040e7a8 T lto_symbol_name
000000000040e570 T lto_toc_symbol
0000000000408230 t save_lto_member_toc_infoLooking at the error message, |
|
Based on the exact error message, looks to me like it has to be: https://github.com/tpoechtrager/cctools-port/blob/6540086c5e12e9c1649fed524b527d8c1793ddc0/cctools/misc/libtool.c#L1663 Which indicates that the file is EITHER:
I see that it's defined along with Or, different question, if that's actually the x86_64 build, why is "__arm64__" defined? |
@theuni thanks for taking a look. I was performing the |
Guix building for |
b218a0c to
b670d9e
Compare
|
Rebased, and added some additional changes. This is now working for macOS Guix builds with LTO. |
Use lto.h from clang+llvm not libtapi. The later is older, and comes bundled with the libtapi repo. Copy libLTO.so when building with FORCE_USE_SYSTEM_CLANG.
This wasn't actually disabling LTO support anyways, because it's enabled by default.
b670d9e to
7f73f42
Compare
|
Squash the first two commits together to fix a build issue due to missing lto.h. |
hebasto
reviewed
Jul 29, 2022
|
Concept ACK. Definitely makes more sense to be taking headers from llvm/cctools than tapi. |
hebasto
approved these changes
Aug 3, 2022
|
Guix builds on |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 4, 2022
… cctools 7f73f42 depends: don't restrict --enable-lto to non-guix cctools (fanquake) 9b60690 cctools: fixup building with LTO (fanquake) Pull request description: This wasn't actually disabling LTO support anyways, because it's enabled by default. Guix Build (x86_64): ```bash af6e0b5fd494f714a84716161352aee415700c1f50f1f08665a474dc2ed56bad guix-build-7f73f422a49f/output/aarch64-linux-gnu/SHA256SUMS.part 1ecdbf2b579204cf2086001df3887da2ba50cd3f7b8f735113cce8f1b634fdb2 guix-build-7f73f422a49f/output/aarch64-linux-gnu/bitcoin-7f73f422a49f-aarch64-linux-gnu-debug.tar.gz 878ea08855dc559e62fd1932f8a54d53fc63e0ce7d587345c7326892622feee9 guix-build-7f73f422a49f/output/aarch64-linux-gnu/bitcoin-7f73f422a49f-aarch64-linux-gnu.tar.gz 4d1d35bd329935bc74b82a78a7fb8dd39c3268d4bbb33ecd877079e49de97a88 guix-build-7f73f422a49f/output/arm-linux-gnueabihf/SHA256SUMS.part c0c5418dc270d716b354d2190fddde3d25794758dee45c9068e9f5aac20e5617 guix-build-7f73f422a49f/output/arm-linux-gnueabihf/bitcoin-7f73f422a49f-arm-linux-gnueabihf-debug.tar.gz 5e13ac8cacf1042746eef7e85695469c50d6afc06dfdb5da53039175e5185b52 guix-build-7f73f422a49f/output/arm-linux-gnueabihf/bitcoin-7f73f422a49f-arm-linux-gnueabihf.tar.gz 218b2463a07503e77711fcf0245bc642eb9ed76e4a3e8b61d66a5c76bdc25c62 guix-build-7f73f422a49f/output/arm64-apple-darwin/SHA256SUMS.part dd15af2b7a333f3c4b3f75abd307e1789a1629728a0ae33d8a509478ace91134 guix-build-7f73f422a49f/output/arm64-apple-darwin/bitcoin-7f73f422a49f-arm64-apple-darwin-unsigned.dmg 5cdfd9fc347007890991c68746b1bb36e0cced57fee685337b3d079d498f687d guix-build-7f73f422a49f/output/arm64-apple-darwin/bitcoin-7f73f422a49f-arm64-apple-darwin-unsigned.tar.gz 80f957e78177927ace323ea90d4bad2e8d2b846b199a0dcb085c3ceae8516631 guix-build-7f73f422a49f/output/arm64-apple-darwin/bitcoin-7f73f422a49f-arm64-apple-darwin.tar.gz 3cb9cb04db3ebf328bfabfda874fce09764f3840c98bd850d85f71892617fb99 guix-build-7f73f422a49f/output/dist-archive/bitcoin-7f73f422a49f.tar.gz e4e7c9d5366b658fc420c1fd3cf12bfb9863b8061c83b06fe2492e934bb75ae9 guix-build-7f73f422a49f/output/powerpc64-linux-gnu/SHA256SUMS.part da4ea7dd9a131901ff2f7fcd6eba573fe946ea671ae6ada418a4ceebcc4bd3b6 guix-build-7f73f422a49f/output/powerpc64-linux-gnu/bitcoin-7f73f422a49f-powerpc64-linux-gnu-debug.tar.gz 221f6e1d5193207eed400c186c8f83747fbf90c3244cd044b36acadbed0c83a6 guix-build-7f73f422a49f/output/powerpc64-linux-gnu/bitcoin-7f73f422a49f-powerpc64-linux-gnu.tar.gz 12d36079b330ec75209219ce58ca580ca5a5eeac64fb7ae424c64e7f3d466ee5 guix-build-7f73f422a49f/output/powerpc64le-linux-gnu/SHA256SUMS.part 3cef0194569d6fa968e92be1d2189be4f1337272dc213c25b8d4afe6b174310c guix-build-7f73f422a49f/output/powerpc64le-linux-gnu/bitcoin-7f73f422a49f-powerpc64le-linux-gnu-debug.tar.gz a8ff109153926b3240f830c3501977046b6c470b67380a01c55aea2401a1a833 guix-build-7f73f422a49f/output/powerpc64le-linux-gnu/bitcoin-7f73f422a49f-powerpc64le-linux-gnu.tar.gz 70b3a841bb232fefe27f857ee826ea6a84f59bc781acda608bd6d9385a1ef149 guix-build-7f73f422a49f/output/riscv64-linux-gnu/SHA256SUMS.part 841a276263877027f256c3b7ad1c5bc3ae3ad4d6a7157690daa947f6809776e2 guix-build-7f73f422a49f/output/riscv64-linux-gnu/bitcoin-7f73f422a49f-riscv64-linux-gnu-debug.tar.gz 6cce2c36c2a53035d7ee5d285c8b4b99256772c7a9dca1739f0639ecc0bed71d guix-build-7f73f422a49f/output/riscv64-linux-gnu/bitcoin-7f73f422a49f-riscv64-linux-gnu.tar.gz e910b32efebca682cf8bc3994d2c7513b16cdeb6f94cef906efb6629ec53268d guix-build-7f73f422a49f/output/x86_64-apple-darwin/SHA256SUMS.part 3a4bc1573d9c576184d69b953ea6a85650d4e15b71503b909ccd4fb8a69ca383 guix-build-7f73f422a49f/output/x86_64-apple-darwin/bitcoin-7f73f422a49f-x86_64-apple-darwin-unsigned.dmg 60a114ece1d9a274d9f3d80a9633eb22d589213ba53a956f3b1138d7c8f55560 guix-build-7f73f422a49f/output/x86_64-apple-darwin/bitcoin-7f73f422a49f-x86_64-apple-darwin-unsigned.tar.gz b6c6eca3e81bfadfed3ddcb7830857c954c8a7b0ff458f14050f4952240ebf27 guix-build-7f73f422a49f/output/x86_64-apple-darwin/bitcoin-7f73f422a49f-x86_64-apple-darwin.tar.gz aab972c6f051c379a20eb694128a4df4e3737758fbca3902d28d72cd93e6d33a guix-build-7f73f422a49f/output/x86_64-linux-gnu/SHA256SUMS.part b8e643eeb72cf04664462f815497cbef1443f2e113de14bc93b058d83836c7df guix-build-7f73f422a49f/output/x86_64-linux-gnu/bitcoin-7f73f422a49f-x86_64-linux-gnu-debug.tar.gz 3b40fb5f1341cc3b49c9eccc68fc75e1cc7e7d2c6a5664fa2f8f095290e3733a guix-build-7f73f422a49f/output/x86_64-linux-gnu/bitcoin-7f73f422a49f-x86_64-linux-gnu.tar.gz 96138d5f591a8ba8589eb81d2c79ee269556996ae93c6a3fc77746e101b60cab guix-build-7f73f422a49f/output/x86_64-w64-mingw32/SHA256SUMS.part 6ef2d9436caa550bec7defda1d769bffc2e0fe8f7acf99e2fbcefd2e9b920a64 guix-build-7f73f422a49f/output/x86_64-w64-mingw32/bitcoin-7f73f422a49f-win64-debug.zip 91c8c3f0aec623f4183c4ebc141816dddb4482509e99812d32298f3e83da920f guix-build-7f73f422a49f/output/x86_64-w64-mingw32/bitcoin-7f73f422a49f-win64-setup-unsigned.exe 1de7cd32d74990cfcd4e00428c53a35742b7a480f18ae1bd60dbf91b60400947 guix-build-7f73f422a49f/output/x86_64-w64-mingw32/bitcoin-7f73f422a49f-win64-unsigned.tar.gz e4d4ba33bbdd8d9181c8422af31ad6127f3627c327a93cbe8245d7154b5a936c guix-build-7f73f422a49f/output/x86_64-w64-mingw32/bitcoin-7f73f422a49f-win64.zip ``` Guix Build (arm64): ```bash 4d1d35bd329935bc74b82a78a7fb8dd39c3268d4bbb33ecd877079e49de97a88 guix-build-7f73f422a49f/output/arm-linux-gnueabihf/SHA256SUMS.part c0c5418dc270d716b354d2190fddde3d25794758dee45c9068e9f5aac20e5617 guix-build-7f73f422a49f/output/arm-linux-gnueabihf/bitcoin-7f73f422a49f-arm-linux-gnueabihf-debug.tar.gz 5e13ac8cacf1042746eef7e85695469c50d6afc06dfdb5da53039175e5185b52 guix-build-7f73f422a49f/output/arm-linux-gnueabihf/bitcoin-7f73f422a49f-arm-linux-gnueabihf.tar.gz 5768bc05947954f8d0caa1869edbba7a9102339d43c47a43cbc5eabdabebfd16 guix-build-7f73f422a49f/output/arm64-apple-darwin/SHA256SUMS.part e506d3a635364751eaeccf553bd8c8847e5a2ab4a28bb03108052ae697b49e7e guix-build-7f73f422a49f/output/arm64-apple-darwin/bitcoin-7f73f422a49f-arm64-apple-darwin-unsigned.dmg 76fd8b6954ead8bbbba56fbf747459019dcd2def22ab6615ce817f2fff7adcb8 guix-build-7f73f422a49f/output/arm64-apple-darwin/bitcoin-7f73f422a49f-arm64-apple-darwin-unsigned.tar.gz f369a59d44cd31a505faf1eefd84b9ecde91f4cb036e79d38188c9ed0f9c094c guix-build-7f73f422a49f/output/arm64-apple-darwin/bitcoin-7f73f422a49f-arm64-apple-darwin.tar.gz 3cb9cb04db3ebf328bfabfda874fce09764f3840c98bd850d85f71892617fb99 guix-build-7f73f422a49f/output/dist-archive/bitcoin-7f73f422a49f.tar.gz e4e7c9d5366b658fc420c1fd3cf12bfb9863b8061c83b06fe2492e934bb75ae9 guix-build-7f73f422a49f/output/powerpc64-linux-gnu/SHA256SUMS.part da4ea7dd9a131901ff2f7fcd6eba573fe946ea671ae6ada418a4ceebcc4bd3b6 guix-build-7f73f422a49f/output/powerpc64-linux-gnu/bitcoin-7f73f422a49f-powerpc64-linux-gnu-debug.tar.gz 221f6e1d5193207eed400c186c8f83747fbf90c3244cd044b36acadbed0c83a6 guix-build-7f73f422a49f/output/powerpc64-linux-gnu/bitcoin-7f73f422a49f-powerpc64-linux-gnu.tar.gz 12d36079b330ec75209219ce58ca580ca5a5eeac64fb7ae424c64e7f3d466ee5 guix-build-7f73f422a49f/output/powerpc64le-linux-gnu/SHA256SUMS.part 3cef0194569d6fa968e92be1d2189be4f1337272dc213c25b8d4afe6b174310c guix-build-7f73f422a49f/output/powerpc64le-linux-gnu/bitcoin-7f73f422a49f-powerpc64le-linux-gnu-debug.tar.gz a8ff109153926b3240f830c3501977046b6c470b67380a01c55aea2401a1a833 guix-build-7f73f422a49f/output/powerpc64le-linux-gnu/bitcoin-7f73f422a49f-powerpc64le-linux-gnu.tar.gz 70b3a841bb232fefe27f857ee826ea6a84f59bc781acda608bd6d9385a1ef149 guix-build-7f73f422a49f/output/riscv64-linux-gnu/SHA256SUMS.part 841a276263877027f256c3b7ad1c5bc3ae3ad4d6a7157690daa947f6809776e2 guix-build-7f73f422a49f/output/riscv64-linux-gnu/bitcoin-7f73f422a49f-riscv64-linux-gnu-debug.tar.gz 6cce2c36c2a53035d7ee5d285c8b4b99256772c7a9dca1739f0639ecc0bed71d guix-build-7f73f422a49f/output/riscv64-linux-gnu/bitcoin-7f73f422a49f-riscv64-linux-gnu.tar.gz e910b32efebca682cf8bc3994d2c7513b16cdeb6f94cef906efb6629ec53268d guix-build-7f73f422a49f/output/x86_64-apple-darwin/SHA256SUMS.part 3a4bc1573d9c576184d69b953ea6a85650d4e15b71503b909ccd4fb8a69ca383 guix-build-7f73f422a49f/output/x86_64-apple-darwin/bitcoin-7f73f422a49f-x86_64-apple-darwin-unsigned.dmg 60a114ece1d9a274d9f3d80a9633eb22d589213ba53a956f3b1138d7c8f55560 guix-build-7f73f422a49f/output/x86_64-apple-darwin/bitcoin-7f73f422a49f-x86_64-apple-darwin-unsigned.tar.gz b6c6eca3e81bfadfed3ddcb7830857c954c8a7b0ff458f14050f4952240ebf27 guix-build-7f73f422a49f/output/x86_64-apple-darwin/bitcoin-7f73f422a49f-x86_64-apple-darwin.tar.gz aab972c6f051c379a20eb694128a4df4e3737758fbca3902d28d72cd93e6d33a guix-build-7f73f422a49f/output/x86_64-linux-gnu/SHA256SUMS.part b8e643eeb72cf04664462f815497cbef1443f2e113de14bc93b058d83836c7df guix-build-7f73f422a49f/output/x86_64-linux-gnu/bitcoin-7f73f422a49f-x86_64-linux-gnu-debug.tar.gz 3b40fb5f1341cc3b49c9eccc68fc75e1cc7e7d2c6a5664fa2f8f095290e3733a guix-build-7f73f422a49f/output/x86_64-linux-gnu/bitcoin-7f73f422a49f-x86_64-linux-gnu.tar.gz 96138d5f591a8ba8589eb81d2c79ee269556996ae93c6a3fc77746e101b60cab guix-build-7f73f422a49f/output/x86_64-w64-mingw32/SHA256SUMS.part 6ef2d9436caa550bec7defda1d769bffc2e0fe8f7acf99e2fbcefd2e9b920a64 guix-build-7f73f422a49f/output/x86_64-w64-mingw32/bitcoin-7f73f422a49f-win64-debug.zip 91c8c3f0aec623f4183c4ebc141816dddb4482509e99812d32298f3e83da920f guix-build-7f73f422a49f/output/x86_64-w64-mingw32/bitcoin-7f73f422a49f-win64-setup-unsigned.exe 1de7cd32d74990cfcd4e00428c53a35742b7a480f18ae1bd60dbf91b60400947 guix-build-7f73f422a49f/output/x86_64-w64-mingw32/bitcoin-7f73f422a49f-win64-unsigned.tar.gz e4d4ba33bbdd8d9181c8422af31ad6127f3627c327a93cbe8245d7154b5a936c guix-build-7f73f422a49f/output/x86_64-w64-mingw32/bitcoin-7f73f422a49f-win64.zip ``` ACKs for top commit: hebasto: ACK 7f73f42 Tree-SHA512: 8e49bed15b9f92e9905a004c01134ebcef9d7e006c96a8bab1606b1af8a20d495e3aa9846344bac5169fee86fa611dc660cf0bd04dd07f393e5e3f1b12ad4a01
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 9, 2023
Summary: This brings the following files up to date with the current Bitcoin Core master branch: - native_cctools.mk - native_clang.mk - native_ds_store.mk - native_mac_alias.mk - native_libtapi.mk It has at least one fix needed for ARM64 MacOS support. ---- [[bitcoin/bitcoin#24288 | core#24288]] > build, refactor: Drop redundant `$(package)_download_file` assignments > > No need to specify `$(package)_download_file` when it is equal to > `$(package)_file_name`. ---- [[bitcoin/bitcoin#24326 | core#24326]] > build: remove unused include dir from clang package > build: remove -f from clang cp invocation ---- [[bitcoin/bitcoin#25633 | core#25633]] > cctools: fixup building with LTO > > Use lto.h from clang+llvm not libtapi. The later is older, > and comes bundled with the libtapi repo. > > Copy libLTO.so when building with FORCE_USE_SYSTEM_CLANG. > depends: don't restrict --enable-lto to non-guix cctools > > This wasn't actually disabling LTO support anyways, because it's enabled > by default. ---- [[bitcoin/bitcoin#21658 | core#21658]] > build: mac_alias 2.2.0 > > Bumps mac_alias version to one that's arm64-darwin compatible ---- [[bitcoin/bitcoin#25605 | core#25605]] > depends: update urls for dmg tools > > These repos have migrated from https://github.com/al45tair/ to > https://github.com/dmgbuild/, so update our URLs to point to the new > location. Note that GitHub is also already performing the redirect > automatically. > ---- This is a backport of [[bitcoin/bitcoin#24288 | core#24288]], [[bitcoin/bitcoin#24326 | core#24326]], [[bitcoin/bitcoin#25633 | core#25633]], [[bitcoin/bitcoin#21658 | core#21658]] and [[bitcoin/bitcoin#25605 | core#25605]] Test Plan: gitian builds Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D14027
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 20, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 20, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 20, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 21, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 22, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 25, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 25, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 27, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 27, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 28, 2023
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jun 28, 2023
PastaPastaPasta
pushed a commit
to kwvg/dash
that referenced
this pull request
Jun 29, 2023
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Jun 29, 2023
backport: merge bitcoin#25643, bitcoin#23583, bitcoin#23618, bitcoin#23603, bitcoin#23817, bitcoin#24520, bitcoin#24508, bitcoin#25639, bitcoin#26018, bitcoin#25437, bitcoin#25484, bitcoin#23585, bitcoin#24549, bitcoin#24733, bitcoin#21991, bitcoin#22526, bitcoin#25633, bitcoin#24597, bitcoin#24955, bitcoin#25099, bitcoin#24552, bitcoin#21851, bitcoin#25389, bitcoin#25357, partial bitcoin#22318 (guix backports: part 3)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't actually disabling LTO support anyways, because it's enabled
by default.
Guix Build (x86_64):
Guix Build (arm64):