Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 24, 2022

The error message now mentions another option for users to specify the path to the macOS SDK.

@laanwj
Copy link
Member

laanwj commented Apr 24, 2022

ACK on the updated message.

Looking further, it seems that now that the SDK is deterministic, it would be possible to regard the .tar.gz in SOURCES_PATH (default depends/sources) as just another input, instead of handling it as some separate thing. But dunno. It would need special handling as it needs to be manually provided.

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 914076e

@fanquake fanquake merged commit 10a626a into bitcoin:master Apr 25, 2022
@hebasto hebasto deleted the 220424-guix-sdk branch April 25, 2022 09:05
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 26, 2022
914076e guix: Improve error message about missed macOS SDK (Hennadii Stepanov)

Pull request description:

  The error message now mentions another option for users to specify the path to the macOS SDK.

ACKs for top commit:
  fanquake:
    ACK 914076e

Tree-SHA512: e8b9a6c8aa984f02cdb4ad1eeb6c22510c0c74c47c831104ac410ef68b3bc40024a52400b5065a3e25603f8a040e72c8c464436cb9a0a018ca73b0d28e0d609d
@bitcoin bitcoin locked and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants