Skip to content

Conversation

shesek
Copy link
Contributor

@shesek shesek commented Aug 21, 2020

It does count the coinbase transaction.

Refs #19766

@maflcko
Copy link
Member

maflcko commented Aug 21, 2020

ACK 4148f55

1 similar comment
@theStack
Copy link
Contributor

ACK 4148f55

@maflcko maflcko merged commit 197450f into bitcoin:master Aug 22, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 23, 2020
…s field

4148f55 docs: Correct description for getblockstats's txs field (Nadav Ivgi)

Pull request description:

  It does count the coinbase transaction.

  Refs bitcoin#19766

ACKs for top commit:
  MarcoFalke:
    ACK 4148f55
  theStack:
    ACK 4148f55

Tree-SHA512: ccd420f19242efbbbecfe822c825363bc89e26618834de0d805f5cdb07461c8bdc6e077c61ea8cd0d40564a96c67d8a71c68175c8543bb849909d7ae375b2a92
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Oct 14, 2020
It does count the coinbase transaction.

Refs bitcoin#19766

Github-Pull: bitcoin#19777
Rebased-From: 4148f55
@fanquake fanquake mentioned this pull request Oct 15, 2020
@fanquake
Copy link
Member

Being backported to 0.19 in #20150.

fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Oct 16, 2020
It does count the coinbase transaction.

Refs bitcoin#19766

Github-Pull: bitcoin#19777
Rebased-From: 4148f55
@fanquake fanquake mentioned this pull request Oct 16, 2020
@fanquake
Copy link
Member

Being backported to 0.20 in #20166.

maflcko pushed a commit that referenced this pull request Nov 18, 2020
7566af4 doc: Update data directory path comments (Hennadii Stepanov)
09261de util: Add StripRedundantLastElementsOfPath function (Hennadii Stepanov)
8ef0dac macOS deploy: use the new plistlib API (Jonas Schnelli)
314e795 build: fix mutex detection when building bdb on macOS (fanquake)
1f67a30 random: fixes read buffer resizing in RandAddSeedPerfmon (Ethan Heilman)
6113b54 net: Send post-verack handshake messages at most once (MarcoFalke)
bdf15d0 rpc: Adjust witness-tx deserialize error message (MarcoFalke)
731502a rpc: Properly deserialize txs with witness before signing (MarcoFalke)
ee0082b Avoid the use of abs64 in timedata (Pieter Wuille)
05bd0c2 docs: Correct description for getblockstats's txs field (Nadav Ivgi)

Pull request description:

  Backports the following PRs to the 0.20 branch:
  * #19777 - docs: Correct description for getblockstats's txs field
  * #19836 - rpc: Properly deserialize txs with witness before signing
  * #20080 - Strip any trailing `/` in -datadir and -blocksdir paths
  * #20082 - [bugfix] random: fixes read buffer to use min rather than max
  * #20141 - Avoid the use of abs64 in timedata
  * #20146 - net: Send post-verack handshake messages at most once
  * #20195 - build: fix mutex detection when building bdb on macOS
  * #20298 - macOS deploy: use the new plistlib API

  Will add additional commits as they become available.

ACKs for top commit:
  MarcoFalke:
    review ACK 7566af4 🗡

Tree-SHA512: add6bb978313c12c3e07bc232636ae9d1ab0edd0b816705c5c70eeb1cc04097165fd5e29d60c706886943ceb1f749a422020766b4aa2d23be51e9f839157a4bb
maflcko pushed a commit that referenced this pull request Dec 2, 2020
9c71499 rpc: Adjust witness-tx deserialize error message (MarcoFalke)
a7bdf5c rpc: Properly deserialize txs with witness before signing (MarcoFalke)
0b64310 Avoid the use of abs64 in timedata (Pieter Wuille)
5b2de04 Bump vcpkg commit ID to get new msys mirror list (Aaron Clauson)
6957419 build: set minimum required Boost to 1.48.0 (fanquake)
27bb2cc util: Don't reference errno when pthread fails. (MIZUTA Takeshi)
8bd2ab1 docs: Correct description for getblockstats's txs field (Nadav Ivgi)
a8411b3 qt: Fix QFileDialog for static builds (Hennadii Stepanov)

Pull request description:

  Backports the following to the 0.19 branch:
  * #19194 - util: Don't reference errno when pthread fails. - not clean.
  * #19536 - qt, build: Fix QFileDialog for static builds
  * #19777 - docs: Correct description for getblockstats's txs field
  * #19836 - rpc: Properly deserialize txs with witness before signing
  * #20095 - CI: Bump vcpkg commit ID to get new msys mirror list
  * #20141 - Avoid the use of abs64 in timedata
  * #20142 - [0.20] build: set minimum required Boost to 1.48.0

ACKs for top commit:
  jnewbery:
    utACK 9c71499
  dergoegge:
    utACK 9c71499
  MarcoFalke:
    ACK 9c71499

Tree-SHA512: 2151f22bc37a6a2f51a8f36c27376622016b51ff99b570e95354356fce1f1761cf19cb4f8ebfa26d38485a0bff6ff6ee834d2798fb383e2ae2abb175548b8fe6
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Sep 15, 2021
Summary:
It does count the coinbase transaction.

Refs #19766

This is a backport of [[bitcoin/bitcoin#19777 | core#19777]]

Test Plan:
Verified the output for recent blocks on a block explorer.
```
$ src/bitcoin-cli getblockstats '"000000000000000009078f13b271c8bd3075bf77ed1fb70b08ac0cbc92545ce2"'
{
  ...
  "txs": 14,
  ...
}
$ src/bitcoin-cli getblockstats 704983
{
  ...
  "txs": 9,
  ...
}
```

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10121
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants