Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Oct 15, 2020

Backports the following to the 0.19 branch:

hebasto and others added 2 commits October 15, 2020 07:34
This change partially reverts 248e22b.

Github-Pull: bitcoin#19536
Rebased-From: 6457361
It does count the coinbase transaction.

Refs bitcoin#19766

Github-Pull: bitcoin#19777
Rebased-From: 4148f55
@fanquake
Copy link
Member Author

Have just realised that 6148f52 should probably be a backport of c83155b (#20095) instead, as that is newer.

miztake and others added 4 commits October 16, 2020 08:06
Pthread library does not set errno.
Pthread library's errno is returned by return value.

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

Github-Pull: bitcoin#19194
Rebased-From: cb38b06
Due to the use of boost::filesystem::canonical(), the minimum required
version of Boost is actually 1.48.0. Use of canonical was introduced
in bitcoin#14146.

See also Boost filesystem 1.48.0 release notes:
https://github.com/boostorg/filesystem/blob/6b5e38134a336b6ea777cd8a69b6ae929819db7e/doc/release_history.html#L508

Github-Pull: bitcoin#20142
Rebased-From: 3562c15
This fixes the appveyor CI job, see bitcoin#20066.

Currently the job fails because some of the vcpkg dependencies need to install msys2 and the hardcoded mirror in the vcpkg config is down.

Vcpkg commit 76a7e9248fb3c57350b559966dcaa2d52a5e4458 adds new mirrors to the hardcoded list.

Github-Pull: bitcoin#20095
Rebased-From: c83155b
@jnewbery
Copy link
Contributor

utACK 9c71499

Manually verified that the backport commits were the same as master.

@dergoegge
Copy link
Member

utACK 9c71499

a8411b3 - 9c71499: apply the same changes as the commits on master. (9c71499 is missing the change from rpc/mining.cpp but thats ok because it is located in the generateblock RPC which will not be backported to 0.19)

@maflcko
Copy link
Member

maflcko commented Dec 2, 2020

ACK 9c71499

@maflcko maflcko merged commit 5baaea4 into bitcoin:0.19 Dec 2, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
@fanquake fanquake deleted the more_019_backports branch November 9, 2022 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.