Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Oct 16, 2020

Backports the following PRs to the 0.20 branch:

Will add additional commits as they become available.

+ Replaces std::max with std::min to resize buffer in RandAddSeedPerfmon
+ Documents behavior of RandAddSeedPerfmon

Github-Pull: bitcoin#20082
Rebased-From: bd52151
@jnewbery
Copy link
Contributor

utACK 1f67a30

Manually verified all the cherry picks were the same as master.

Starting with the Clang shipped with Xcode 12, Apple has enabled
-Werror=implicit-function-declaration by default. This causes bdbs mutex
detection to fail when building on macOS (not cross-compiling):

checking for mutexes... UNIX/fcntl
configure: WARNING: NO SHARED LATCH IMPLEMENTATION FOUND FOR THIS PLATFORM.
configure: error: Unable to find a mutex implementation

as previously emitted warnings are being turned into errors. i.e:

error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror,-Wimplicit-function-declaration]

Append -Wno-error=implicit-function-declaration to cflags so that
-Wimplicit-function-declaration returns to being a warning, and the
configure checks will succeed.

Fixes bitcoin#19411.

Github-Pull: bitcoin#20195
Rebased-From: d0a829e
See https://docs.python.org/3/library/plistlib.html.
The new API was added in 3.4 and old removed in 3.9.

Github-Pull: 20298
Rebased-From: 04a69c2
Co-authored-by: saibato <saibato.naga@pm.me>
Co-authored-by: MarcoFalke <falke.marco@gmail.com>

Github-Pull: 20080
Rebased-From: b19e882
@maflcko
Copy link
Member

maflcko commented Nov 16, 2020

review ACK 7566af4 🗡

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

review ACK 7566af419f3e7060152ae062f5a578f543a16a5a 🗡
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUjV0wv/YkXQDPhIjXO8ZKqVRZyyMi+RQtx4FiU5hL/PJKfZg2UEogGrORfOdxdc
FZw3zI9h580R6b3fqZPclPv3n+jpaBKfF98m5TKTfm0dsVX9XPmH2brB8eKA+yDo
bck5dyrdkootE52vzq5fQwcd3jb2SliIaYvLUBPvrlTe3oqWTZTdg+tjRNplAjUa
0hPps6Sn2m/GXypk4ZqcuclFiG+OiRak4mPGY7G++eCxh+eFYdvEpPi0z7z6RZK5
9i/Bw0eZACX6i5kDRsfBENdwRKZn6aW6SaSDdOOxMC+IM4cq2vEo0EXHXm5D1mEl
x7RyISFUyLz4fL7Adgme/+Ppwc6jgWu70JpcZa0BU2CLex3O7Ek9Wck/unJx6wBx
dLFckqS8rLI/SYfcswWOqLR9xmIQapa5lifuLn3JKKWcFYSO6H2mQEnlNJCRaVt4
99uXmAece9icmR90xLwKyeEGQ4gNyPCiKE4+mywvsYJchk4P38NIU+q0RljoO/6P
elRfqGXN
=SLep
-----END PGP SIGNATURE-----

python: error while loading shared libraries: libpython3.8.so.1.0: cannot open shared object file: No such file or directory

@maflcko maflcko merged commit a2fa11f into bitcoin:0.20 Nov 18, 2020
@fanquake fanquake deleted the more_020_backports branch April 8, 2021 05:15
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants