util: Don't reference errno when pthread fails. #19194

miztake · 2020-06-06T17:56:12Z

Pthread library does not set errno.
Pthread library's errno is returned by return value.

practicalswift · 2020-06-06T19:31:53Z

Concept ACK: nice catch and nice first-time contribution!

May I ask how did you found this issue? :)

Warm welcome as a contributor @miztake :)

pstratem · 2020-06-07T00:21:14Z

ACK c7601ab

you can move the declaration into the if statement like this:
if ((int rc = pthread_setschedparam(pthread_self(), SCHED_BATCH, &param)) != 0) {

hebasto

ACK c7601ab, tested on Linux Mint 19.3 (x86_64).

From the pthread_setschedparam() docs:

On success, these functions return 0; on error, they return a nonzero error number.

src/util/system.cpp

hebasto · 2020-06-07T10:50:55Z

you can move the declaration into the if statement like this:
if ((int rc = pthread_setschedparam(pthread_self(), SCHED_BATCH, &param)) != 0) {

It won't compile :) (at least on GCC 7.5).

miztake · 2020-06-07T15:26:24Z

Hi, @practicalswift

May I ask how did you found this issue? :)

Thank you for your comment.
I didn't actually output this log.
It's a common bug when using pthread and I found it in a code review.
( just greped "pthread" :) )

donaloconnor · 2020-06-07T15:49:17Z

ACK 0e7b64b

hebasto

ACK 0e7b64b.

Mind squashing commits into one commit?

kristapsk · 2020-06-07T16:29:25Z

Concept ACK, checked man pthread_setschedparam, change seems correct, but commits should be squashed into one.

Pthread library does not set errno. Pthread library's errno is returned by return value. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

miztake · 2020-06-08T07:42:23Z

Hi, @kristapsk

Thank you for your comment.
I squashed the commits into one.

hebasto

ACK cb38b06, only squashed commits since the previous review.

maflcko · 2020-06-08T10:41:31Z

review ACK cb38b06

practicalswift · 2020-06-08T11:13:11Z

ACK cb38b06 -- patch looks correct

laanwj · 2020-06-09T11:58:35Z

Poshumous ACK, good catch!

Pthread library does not set errno. Pthread library's errno is returned by return value. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Github-Pull: bitcoin#19194 Rebased-From: cb38b06

2b79ac7 Clean up separated ban/discourage interface (Pieter Wuille) 0477348 Replace automatic bans with discouragement filter (Pieter Wuille) e7f06f9 test: remove Cirrus CI FreeBSD job (fanquake) eb6b82a qa: Test concurrent wallet loading (João Barbosa) c9b49d2 wallet: Handle concurrent wallet loading (João Barbosa) cf0b5a9 tests: Check that segwit inputs in psbt have both UTXO types (Andrew Chow) 3228b59 psbt: always put a non_witness_utxo and don't remove it (Andrew Chow) ed5ec30 psbt: Allow both non_witness_utxo and witness_utxo (Andrew Chow) 68e0e6f rpc: show both UTXOs in decodepsbt (Andrew Chow) 27786d0 trivial: Suggested cleanups to surrounding code (Russell Yanofsky) 654420d wallet: Minimal fix to restore conflicted transaction notifications (Russell Yanofsky) febebc4 Fix WSL file locking by using flock instead of fcntl (Samuel Dobson) 5c7151a gui: update Qt base translations for macOS release (fanquake) c219d21 build: improved output of configure for build OS (sachinkm77) 0596a6e util: Don't reference errno when pthread fails. (MIZUTA Takeshi) Pull request description: Currently backports the following to the 0.20 branch: * #18700 - Fix locking on WSL using flock instead of fcntl * #18982 - wallet: Minimal fix to restore conflicted transaction notifications * #19059 - gui: update Qt base translations for macOS release * #19152 - build: improve build OS configure output * #19194 - util: Don't reference errno when pthread fails. * #19215 - psbt: Include and allow both non_witness_utxo and witness_utxo for segwit inputs * #19219 - Replace automatic bans with discouragement filter * #19300 - wallet: Handle concurrent wallet loading ACKs for top commit: amitiuttarwar: ACK 0477348 2b79ac7 by comparing to original changes, double checking the diff sipa: utACK 2b79ac7 laanwj: ACK 2b79ac7 Tree-SHA512: e5eb31d08288fa4a6e8aba08e60b16ce1988f14f249238b1cfd18ab2c8f6fcd9f07e3c0c491d32d2361fca26e3037fb0374f37464bddcabecea29069d6737539

Pthread library does not set errno. Pthread library's errno is returned by return value. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Github-Pull: #19194 Rebased-From: cb38b06

Pthread library does not set errno. Pthread library's errno is returned by return value. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Github-Pull: bitcoin#19194 Rebased-From: cb38b06

9c71499 rpc: Adjust witness-tx deserialize error message (MarcoFalke) a7bdf5c rpc: Properly deserialize txs with witness before signing (MarcoFalke) 0b64310 Avoid the use of abs64 in timedata (Pieter Wuille) 5b2de04 Bump vcpkg commit ID to get new msys mirror list (Aaron Clauson) 6957419 build: set minimum required Boost to 1.48.0 (fanquake) 27bb2cc util: Don't reference errno when pthread fails. (MIZUTA Takeshi) 8bd2ab1 docs: Correct description for getblockstats's txs field (Nadav Ivgi) a8411b3 qt: Fix QFileDialog for static builds (Hennadii Stepanov) Pull request description: Backports the following to the 0.19 branch: * #19194 - util: Don't reference errno when pthread fails. - not clean. * #19536 - qt, build: Fix QFileDialog for static builds * #19777 - docs: Correct description for getblockstats's txs field * #19836 - rpc: Properly deserialize txs with witness before signing * #20095 - CI: Bump vcpkg commit ID to get new msys mirror list * #20141 - Avoid the use of abs64 in timedata * #20142 - [0.20] build: set minimum required Boost to 1.48.0 ACKs for top commit: jnewbery: utACK 9c71499 dergoegge: utACK 9c71499 MarcoFalke: ACK 9c71499 Tree-SHA512: 2151f22bc37a6a2f51a8f36c27376622016b51ff99b570e95354356fce1f1761cf19cb4f8ebfa26d38485a0bff6ff6ee834d2798fb383e2ae2abb175548b8fe6

Summary: Pthread library does not set errno. Pthread library's errno is returned by return value. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> This is a backport of [[bitcoin/bitcoin#19194 | core#19194]] Test Plan: `ninja check-functional` Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D9524

DrahtBot added the Utils/log/libs label Jun 6, 2020

hebasto reviewed Jun 7, 2020

View reviewed changes

src/util/system.cpp Outdated Show resolved Hide resolved

hebasto approved these changes Jun 7, 2020

View reviewed changes

util: Don't reference errno when pthread fails.

cb38b06

Pthread library does not set errno. Pthread library's errno is returned by return value. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

hebasto approved these changes Jun 8, 2020

View reviewed changes

fanquake merged commit 9573d2b into bitcoin:master Jun 8, 2020

fanquake added the Needs backport (0.20) label Jun 8, 2020

fanquake mentioned this pull request Jun 9, 2020

[0.20] Backports #19224

Merged

fanquake removed the Needs backport (0.20) label Jun 9, 2020

fanquake mentioned this pull request Oct 15, 2020

[0.19] Backports #20150

Merged

Platinumwrist referenced this pull request in syscoin/syscoin Oct 25, 2020

doc: Add historical release notes for 0.20.1

05e2740

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

util: Don't reference errno when pthread fails. #19194

util: Don't reference errno when pthread fails. #19194

miztake commented Jun 6, 2020 •

edited by fanquake

Loading

Uh oh!

practicalswift commented Jun 6, 2020

Uh oh!

pstratem commented Jun 7, 2020

Uh oh!

hebasto left a comment

Uh oh!

Uh oh!

hebasto commented Jun 7, 2020

Uh oh!

miztake commented Jun 7, 2020

Uh oh!

donaloconnor commented Jun 7, 2020

Uh oh!

hebasto left a comment

Uh oh!

kristapsk commented Jun 7, 2020

Uh oh!

miztake commented Jun 8, 2020

Uh oh!

hebasto left a comment

Uh oh!

maflcko commented Jun 8, 2020

Uh oh!

practicalswift commented Jun 8, 2020

Uh oh!

laanwj commented Jun 9, 2020

Uh oh!

Uh oh!

util: Don't reference errno when pthread fails. #19194

util: Don't reference errno when pthread fails. #19194

Conversation

miztake commented Jun 6, 2020 • edited by fanquake Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

practicalswift commented Jun 6, 2020

Uh oh!

pstratem commented Jun 7, 2020

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hebasto commented Jun 7, 2020

Uh oh!

miztake commented Jun 7, 2020

Uh oh!

donaloconnor commented Jun 7, 2020

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

kristapsk commented Jun 7, 2020

Uh oh!

miztake commented Jun 8, 2020

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

maflcko commented Jun 8, 2020

Uh oh!

practicalswift commented Jun 8, 2020

Uh oh!

laanwj commented Jun 9, 2020

Uh oh!

Uh oh!

miztake commented Jun 6, 2020 •

edited by fanquake

Loading