[0.20] Backports #19224
Merged
[0.20] Backports #19224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pthread library does not set errno. Pthread library's errno is returned by return value. Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Github-Pull: bitcoin#19194 Rebased-From: cb38b06
Github-Pull: bitcoin#19152 Rebased-From: 0fef60c
These haven't been updated since their addition, so this updates the list that controls which qt base translations are bundled with the macOS binary, to all the languages that are available with qt 5.9.8. This could probably be improved in some way, however qt updates are infrequent, and I didn't want to spend any more time looking at this. Also given that no-one seems to have noticed and/or reported this it wouldn't seem high-priority. Could be backported to 0.20.1. Github-Pull: bitcoin#19059 Rebased-From: 69bfcac
Co-authored-by: sipa <pieter@wuille.net> Github-Pull: bitcoin#18700 Rebased-From: e8fa0a3
This fix is a based on the fix by Antoine Riard <ariard@student.42.fr> in bitcoin#18600. Unlike that PR, which implements some new behavior, this just restores previous wallet notification and status behavior for transactions removed from the mempool because they conflict with transactions in a block. The behavior was accidentally changed in two `CWallet::BlockConnected` updates: a31be09 and 7e89994 from bitcoin#16624, causing issue bitcoin#18325. The change here could be improved and replaced with a more comprehensive cleanup, so it includes a detailed comment explaining future considerations. Fixes bitcoin#18325 Co-authored-by: Antoine Riard <ariard@student.42.fr> Github-Pull: bitcoin#18982 Rebased-From: b604c5c
bitcoin#18982 (review) Github-Pull: bitcoin#18982 Rebased-From: 7eaf86d
|
#19300 was merged. |
Github-Pull: bitcoin#19215 Rebased-From: 72f6bec
Github-Pull: bitcoin#19215 Rebased-From: 5279d8b
Offline signers will always need a non_witness_utxo so make sure it is there. Github-Pull: bitcoin#19215 Rebased-From: 4600479
Github-Pull: bitcoin#19215 Rebased-From: 84d295e
Github-Pull: bitcoin#19300 Rebased-From: b9971ae
Github-Pull: bitcoin#19300 Rebased-From: 9b009fa
This has been removed from the master branch, and always seems to fail at the installing packages phase. i.e: ```bash pkg install -y autoconf automake boost-libs git gmake libevent libtool pkgconf python3 ccache Updating FreeBSD repository catalogue... Fetching meta.txz: . done pkg: repository meta /var/db/pkg/FreeBSD.meta has wrong version 2 repository FreeBSD has no meta file, using default settings Fetching packagesite.txz: .......... done pkg: repository meta /var/db/pkg/FreeBSD.meta has wrong version 2 pkg: Repository FreeBSD load error: meta cannot be loaded No error: 0 Unable to open created repository FreeBSD Unable to update repository FreeBSD Error updating repositories! Exit status: 3 ```
This patch improves performance and resource usage around IP addresses that are banned for misbehavior. They're already not actually banned, as connections from them are still allowed, but they are preferred for eviction if the inbound connection slots are full. Stop treating these like manually banned IP ranges, and instead just keep them in a rolling Bloom filter of misbehaving nodes, which isn't persisted to disk or exposed through the ban framework. The effect remains the same: preferred for eviction, avoided for outgoing connections, and not relayed to other peers. Also change the name of this mechanism to better reflect reality; they're not banned, just discouraged. Contains release notes and several interface improvements by John Newbery. Github-Pull: bitcoin#19219 Rebased-From: b691f2d
Github-Pull: bitcoin#19219 Rebased-From: 2ad5838
|
ACK 2b79ac7 |
|
See #19440 for the appveyor fix |
|
Thanks, so we might want to backport #19444 as well, if we care about AppVeyor passing on the branch (I guess so). |
sdaftuar
pushed a commit
to sdaftuar/bitcoin
that referenced
this pull request
Aug 7, 2020
This has been removed from the master branch, and always seems to fail at the installing packages phase. i.e: ```bash pkg install -y autoconf automake boost-libs git gmake libevent libtool pkgconf python3 ccache Updating FreeBSD repository catalogue... Fetching meta.txz: . done pkg: repository meta /var/db/pkg/FreeBSD.meta has wrong version 2 repository FreeBSD has no meta file, using default settings Fetching packagesite.txz: .......... done pkg: repository meta /var/db/pkg/FreeBSD.meta has wrong version 2 pkg: Repository FreeBSD load error: meta cannot be loaded No error: 0 Unable to open created repository FreeBSD Unable to update repository FreeBSD Error updating repositories! Exit status: 3 ``` Github-Pull: bitcoin#19224 Rebased-From: e7f06f9
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Aug 11, 2020
This has been removed from the master branch, and always seems to fail at the installing packages phase. i.e: ```bash pkg install -y autoconf automake boost-libs git gmake libevent libtool pkgconf python3 ccache Updating FreeBSD repository catalogue... Fetching meta.txz: . done pkg: repository meta /var/db/pkg/FreeBSD.meta has wrong version 2 repository FreeBSD has no meta file, using default settings Fetching packagesite.txz: .......... done pkg: repository meta /var/db/pkg/FreeBSD.meta has wrong version 2 pkg: Repository FreeBSD load error: meta cannot be loaded No error: 0 Unable to open created repository FreeBSD Unable to update repository FreeBSD Error updating repositories! Exit status: 3 ``` Github-Pull: bitcoin#19224 Rebased-From: e7f06f9
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently backports the following to the 0.20 branch: