Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Apr 2, 2020

This is needed for rebranding efforts such as #18489

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested facace8 on Linux Mint 19.3:

$ diff -u ~/version-master ~/version-18503 
--- /home/hebasto/version-master	2020-04-02 15:27:50.139783797 +0300
+++ /home/hebasto/version-18503	2020-04-02 15:29:25.639331357 +0300
@@ -1,8 +1,8 @@
-Bitcoin Core version v0.19.99.0-41fa2926d
+Bitcoin Core version v0.19.99.0-facace878
 Copyright (C) 2009-2020 The Bitcoin Core developers
 
 Please contribute if you find Bitcoin Core useful. Visit
-<https://bitcoincore.org> for further information about the software.
+https://bitcoincore.org/ for further information about the software.
 The source code is available from <https://github.com/bitcoin/bitcoin>.
 
 This is experimental software.

It seems better to use the unified style for both links: with < and > or without them at all.

@maflcko maflcko force-pushed the 2004-initRebrand branch from facace8 to fad2f68 Compare April 2, 2020 12:53
@maflcko
Copy link
Member Author

maflcko commented Apr 2, 2020

Whoopsie. Those chevrons are needed in the GUI to make the link clickable.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fad2f68, tested on Linux Mint 19.3:
Screenshot from 2020-04-02 16-04-04

All of the links are clickable.

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fad2f68 - clicked a link.

@fanquake fanquake merged commit 08c4994 into bitcoin:master Apr 3, 2020
@maflcko maflcko deleted the 2004-initRebrand branch April 3, 2020 11:56
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 3, 2020
fad2f68 init: Replace URL_WEBSITE with PACKAGE_URL (MarcoFalke)

Pull request description:

  This is needed for rebranding efforts such as bitcoin#18489

ACKs for top commit:
  hebasto:
    ACK fad2f68, tested on Linux Mint 19.3:
  fanquake:
    ACK fad2f68 - clicked a link.

Tree-SHA512: c26e18cd328d3dd3fd7e25413e1bab780026687a148f126b8673e5f6cc13249f6c16689e45eba9da1545915c6001f96cd33f4e656c08cda3eae1c3fd88da23ea
MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Apr 7, 2020
- doc: fix git add argument bitcoin#18513
- build: Fix libevent linking for bench_bitcoin binary bitcoin#18397
- script: fix SCRIPT_ERR_SIG_PUSHONLY error string bitcoin#18412
- doc: Comment fix merkle.cpp bitcoin#18379
- log: Fix UB with bench on genesis block bitcoin#15283
- test: Fix mining to an invalid target + ensure that a new block has the correct hash internally bitcoin#18350
- Fix missing header in sync.h bitcoin#18357
- refactor: Fix implicit value conversion in formatPingTime bitcoin#18260
- Fix .gitignore policy in build_msvc directory bitcoin#18108
- build: Fix behavior when ALLOW_HOST_PACKAGES unset bitcoin#18051
- test: Fix p2p_invalid_messages failing in Python 3.8 because of warning bitcoin#17931
- qa: Fix double-negative arg test bitcoin#17893
- build: Fix configure report about qr bitcoin#17547
- log: Fix log message for -par=1 bitcoin#17325
- bench: Fix negative values and zero for -evals flag bitcoin#17267
- depends: fix boost mac cross build with clang 9+ bitcoin#17231
- doc: Fix broken bitcoin-cli examples bitcoin#17119
- doc: fix Makefile target in benchmarking.md bitcoin#17081
- contrib: fix minor typos in makeseeds.py bitcoin#17042
- test: Fix Python Docstring to include all Args. bitcoin#17030
- doc: Fix some misspellings bitcoin#17351
- doc: Doxygen-friendly script/descriptor.h comments bitcoin#16947
- doc: Fix doxygen errors bitcoin#17945
- doc: Doxygen-friendly CuckooCache comments bitcoin#16986
- doc: Add to Doxygen documentation guidelines bitcoin#17873
- depends: Consistent use of package variable bitcoin#17928
- init: Replace URL_WEBSITE with PACKAGE_URL bitcoin#18503
- doc: Add missed copyright headers bitcoin#17691
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants